Fix Idna Test #72817
Merged
Fix Idna Test #72817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-globalization Issue DetailsFixes #72749
|
|
@eerhardt could you please have a look? |
|
Is this something we should report to Windows? |
filipnavara
reviewed
Jul 26, 2022
...es/System.Globalization.Extensions/tests/IdnMapping/Data/Unicode_9_0/Unicode_9_0_IdnaTest.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jul 26, 2022
...es/System.Globalization.Extensions/tests/IdnMapping/Data/Unicode_9_0/Unicode_9_0_IdnaTest.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Jul 26, 2022
eerhardt
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
LGTM - once the comment is cleaned up as suggested by @stephentoub
…/Data/Unicode_9_0/Unicode_9_0_IdnaTest.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
No, it happens on Windows Server 2019 carrying ICU v61.1 which has this behavior. I don't think Windows can risk upgrading ICU there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72749