[iOS] Enable Diagnostics.Tracing tests #72545

steveisok · 2022-07-20T20:49:42Z

Fixes an issue where a test project that contains native libraries will fool the AOT compiler task in thinking there are assemblies in different locations. This causes .aotdata files to not be bundled with the test app and ends up causing a runtime assertion.

Fixes #51382

Fixes an issue where a test project that contains native libraries will fool the AOT compiler task in thinking there are assemblies in different locations. This causes .aotdata files to not be bundled with the test app and ends up causing a runtime assertion.

dotnet-issue-labeler · 2022-07-20T20:49:49Z

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

steveisok · 2022-07-20T20:50:59Z

@radical I'm not sure if switching the Filter / Ensure methods are going to impact you.

steveisok · 2022-07-20T20:51:18Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-07-20T20:51:31Z

Azure Pipelines successfully started running 1 pipeline(s).

radical · 2022-07-20T20:54:13Z

@radical I'm not sure if switching the Filter / Ensure methods are going to impact you.

I think it should be fine. FilterAssemblies does not try to load any dependencies, so location shouldn't matter. But let's see what the tests say :)

radical · 2022-07-20T20:54:27Z

/azp run runtime-wasm

azure-pipelines · 2022-07-20T20:54:36Z

Azure Pipelines successfully started running 1 pipeline(s).

src/libraries/tests.proj

mdh1418 · 2022-07-20T21:56:43Z

We can reenable these as well #56073
We just need to add RuntimeComponents="$(RuntimeComponents)" to AppleAppBuilderTask in AppleApp.targets and setting this property in System.Diagnostics.Tracing.Tests.csproj <RuntimeComponents>diagnostics_tracing</RuntimeComponents>

We probably also need to add <EventSourceSupport>true</EventSourceSupport> if the test suite fails with EnableAggressiveTrimming=true

radical · 2022-07-21T20:00:21Z

Precompiling failed for /datadisks/disk1/work/A48F08FA/w/A9BB08F7/e/blazorwasm_Release_aot/obj/Release/net7.0/wasm/for-publish/aot-in/Microsoft.AspNetCore.Components.WebAssembly.dll with exit code 1.
Failed to load method 0x6000065 from '/datadisks/disk1/work/A48F08FA/w/A9BB08F7/e/blazorwasm_Release_aot/obj/Release/net7.0/wasm/for-publish/aot-in/Microsoft.AspNetCore.Components.WebAssembly.dll' due to Could not load file or assembly 'Microsoft.JSInterop.WebAssembly, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60' or one of its dependencies..
Run with MONO_LOG_LEVEL=debug for more information.
AOT of image Microsoft.AspNetCore.Components.WebAssembly.dll failed.
Mono Ahead of Time compiler - compiling assembly /datadisks/disk1/work/A48F08FA/w/A9BB08F7/e/blazorwasm_Release_aot/obj/Release/net7.0/wasm/for-publish/aot-in/Microsoft.AspNetCore.Components.WebAssembly.dll

Hm Failed to load method 0x6000065 from '/datadisks/disk1/work/A48F08FA/w/A9BB08F7/e/blazorwasm_Release_aot/obj/Release/net7.0/wasm/for-publish/aot-in/Microsoft.AspNetCore.Components.WebAssembly.dll' due to Could not load file or assembly 'Microsoft.JSInterop.WebAssembly, ..

Microsoft.JSInterop.WebAssembly is skipped for AOT, but looks like it is still needed by mono-aot-cross. Hm I'll push a fix for this.

radical · 2022-07-21T20:42:18Z

Fixes an issue where a test project that contains native libraries will fool the AOT compiler task in thinking there are assemblies in different locations. This causes .aotdata files to not be bundled with the test app and ends up causing a runtime assertion.

Could you explain what exactly is happening here?

test project contains native dlls, in location different from the managed assemblies
which makes the aot compiler task to move all of them (including the native ones) to a single directory
but how does that affect the aotdata being bundled?

…assemblies `iOS` targets depend on these files being next to the original assemblies. But that assumption breaks when `MonoAOTCompiler` copies the assemblies to `aot-in` directory, and emits the `.aotdata` files there.

.. unmanaged assemblies. 1. Completely ignore unmanaged assemblies 2. Assemblies to be skipped for AOT, should still get copied to `aot-in` dir. If this is not done, then blazor apps would break because they skip` Microsoft.JSInterop.WebAssembly` but other assemblies depend on it, thus causing `mono-aot-cross` to fail because it can't find the JSInterop assembly.

radical · 2022-07-21T22:05:56Z

I have pushed some changes that fixes the issue in two ways:

The .aotdata files will be emitted next to the original assemblies
Unmanaged assemblies won't be used to decide whether we need to move all the assemblies to a aot-in directory

radical · 2022-07-21T22:06:10Z

/azp run runtime-extra-platforms,runtime-wasm

azure-pipelines · 2022-07-21T22:06:28Z

Azure Pipelines successfully started running 2 pipeline(s).

steveisok · 2022-07-22T18:57:50Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-07-22T18:58:09Z

Azure Pipelines successfully started running 1 pipeline(s).

…managed assemblies

radical · 2022-07-22T21:01:57Z

/azp run runtime-extra-platforms,runtime-wasm

azure-pipelines · 2022-07-22T21:02:13Z

Azure Pipelines successfully started running 2 pipeline(s).

steveisok · 2022-07-25T02:08:50Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-07-25T02:09:02Z

Azure Pipelines successfully started running 1 pipeline(s).

steveisok · 2022-07-25T16:05:34Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-07-25T16:05:51Z

Azure Pipelines successfully started running 1 pipeline(s).

steveisok · 2022-07-25T20:18:58Z

System.Diagnostics.Tracing tests pass on tvOS. The other failures are unrelated.

mdh1418

Looks good to me! If we can add new issues/reference existing ones for any new project/test skips that'd be good.

mdh1418 · 2022-07-25T20:26:24Z

src/libraries/tests.proj

+    <!-- 
+      System.Formats.Cbor crashes on tvOS 
+    -->
+    <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Formats.Cbor\tests\System.Formats.Cbor.Tests.csproj" />
+
+    <!--
+      Test apps that are too large and take too long to build 
+      Keep here until aggressive trimming targets can work on helix.
+    -->
+    <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Text.RegularExpressions\tests\UnitTests\System.Text.RegularExpressions.Tests.csproj" />
+    <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Text.Json\tests\System.Text.Json.SourceGeneration.Tests\System.Text.Json.SourceGeneration.Roslyn4.0.Tests.csproj" />
+
+


Are these new failures? Are there issues associated that we can put in the comments?

If it's just links that we need to add, then we can do that in a follow up PR.

There will be. I would rather address it in #67861

steveisok requested a review from radical as a code owner July 20, 2022 20:49

ghost assigned steveisok Jul 20, 2022

steveisok requested a review from mdh1418 July 20, 2022 20:49

radical approved these changes Jul 20, 2022

View reviewed changes

mdh1418 requested changes Jul 20, 2022

View reviewed changes

src/libraries/tests.proj Show resolved Hide resolved

ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 20, 2022

This was referenced Jul 21, 2022

system.io.pipes.tests work item timeout when running long running test #72585

Closed

System.Text.Json.SourceGeneration intermittent failures #72101

Closed

system.io.compression.tests.zipfile_extract.extracttodirectoryunicode #72537

Open

radical added 3 commits July 21, 2022 21:11

Merge remote-tracking branch 'origin/main' into enable-diag-tracing-ios

8d7e6a2

ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 21, 2022

Re-enable more iOS tests and set diagnostics_tracing runtime component

303f469

radical added 3 commits July 22, 2022 16:58

MonoAOTCompiler: revert hack for .aotdata files on ios

a5f5b5a

Merge remote-tracking branch 'origin/main' into enable-diag-tracing-ios

0cccd0d

MonoAOTCompiler: emit a message instead of a warning when skipping un…

1b81263

…managed assemblies

Add AppleAppBuilder change that reads path in from AotDataFile item

972cd2b

Properly enable tracing tests

3fe3b2f

steveisok requested a review from marek-safar as a code owner July 25, 2022 16:05

mdh1418 approved these changes Jul 25, 2022

View reviewed changes

steveisok merged commit bbdd837 into dotnet:main Jul 25, 2022

steveisok deleted the enable-diag-tracing-ios branch July 25, 2022 20:32

karelz mentioned this pull request Aug 7, 2022

System.Net.Security.Tests crashed on Alpine.arm32 and OSX.1200 #72227

Closed

mdh1418 mentioned this pull request Aug 8, 2022

[MONO] Move marshal-ilgen into a component #71203

Merged

ghost locked as resolved and limited conversation to collaborators Aug 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[iOS] Enable Diagnostics.Tracing tests #72545

[iOS] Enable Diagnostics.Tracing tests #72545

steveisok commented Jul 20, 2022

dotnet-issue-labeler bot commented Jul 20, 2022

steveisok commented Jul 20, 2022

steveisok commented Jul 20, 2022

azure-pipelines bot commented Jul 20, 2022

radical commented Jul 20, 2022

radical commented Jul 20, 2022

azure-pipelines bot commented Jul 20, 2022

mdh1418 commented Jul 20, 2022 •

edited

Loading

radical commented Jul 21, 2022

radical commented Jul 21, 2022

radical commented Jul 21, 2022

radical commented Jul 21, 2022

azure-pipelines bot commented Jul 21, 2022

steveisok commented Jul 22, 2022

azure-pipelines bot commented Jul 22, 2022

radical commented Jul 22, 2022

azure-pipelines bot commented Jul 22, 2022

steveisok commented Jul 25, 2022

azure-pipelines bot commented Jul 25, 2022

steveisok commented Jul 25, 2022

azure-pipelines bot commented Jul 25, 2022

steveisok commented Jul 25, 2022

mdh1418 left a comment

mdh1418 Jul 25, 2022

radical Jul 25, 2022

steveisok Jul 25, 2022

[iOS] Enable Diagnostics.Tracing tests #72545

[iOS] Enable Diagnostics.Tracing tests #72545

Conversation

steveisok commented Jul 20, 2022

dotnet-issue-labeler bot commented Jul 20, 2022

steveisok commented Jul 20, 2022

steveisok commented Jul 20, 2022

azure-pipelines bot commented Jul 20, 2022

radical commented Jul 20, 2022

radical commented Jul 20, 2022

azure-pipelines bot commented Jul 20, 2022

mdh1418 commented Jul 20, 2022 • edited Loading

radical commented Jul 21, 2022

radical commented Jul 21, 2022

radical commented Jul 21, 2022

radical commented Jul 21, 2022

azure-pipelines bot commented Jul 21, 2022

steveisok commented Jul 22, 2022

azure-pipelines bot commented Jul 22, 2022

radical commented Jul 22, 2022

azure-pipelines bot commented Jul 22, 2022

steveisok commented Jul 25, 2022

azure-pipelines bot commented Jul 25, 2022

steveisok commented Jul 25, 2022

azure-pipelines bot commented Jul 25, 2022

steveisok commented Jul 25, 2022

mdh1418 left a comment

Choose a reason for hiding this comment

mdh1418 Jul 25, 2022

Choose a reason for hiding this comment

radical Jul 25, 2022

Choose a reason for hiding this comment

steveisok Jul 25, 2022

Choose a reason for hiding this comment

mdh1418 commented Jul 20, 2022 •

edited

Loading