Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip localized System.CommandLine resources from CoreCLR tools #72478

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Strip localized System.CommandLine resources from CoreCLR tools #72478

merged 1 commit into from
Jul 19, 2022

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Jul 19, 2022

No description provided.

@ghost ghost assigned jkotas Jul 19, 2022
@ghost
Copy link

ghost commented Jul 19, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: jkotas
Assignees: -
Labels:

area-Infrastructure-coreclr
Milestone: -

@jkotas jkotas mentioned this pull request Jul 19, 2022
Merged
@jkotas jkotas requested a review from ViktorHofer July 19, 2022 18:39
@ViktorHofer
Copy link
Member

Just to double check, did you verify that this works as expected?

@jkotas
Copy link
Member Author

jkotas commented Jul 19, 2022

Yes, it works as expected. There are no System.CommandLine.resources.dll under artifacts with this change.

@jkotas jkotas merged commit c37f002 into dotnet:main Jul 19, 2022
@jkotas jkotas deleted the en-us-only branch July 19, 2022 21:37
@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@hoyosjs hoyosjs hoyosjs approved these changes

Assignees

@jkotas jkotas

Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkotas @ViktorHofer @stephentoub @hoyosjs