Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for m_alignpad == 0 assertion failure #72475

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Fix for m_alignpad == 0 assertion failure #72475

merged 3 commits into from
Jul 20, 2022

Conversation

mrsharm
Copy link
Member

@mrsharm mrsharm commented Jul 19, 2022

Fixes #70231 by:

  1. Removing the demotion check
  2. Adding a null check on the GCSafeMethodTable

Also, we are now logging the m_alignpad value instead of the object address in the IllegalAlignPad function.

@ghost ghost assigned mrsharm Jul 19, 2022
@ghost
Copy link

ghost commented Jul 19, 2022

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #70231 by:

  1. Removing the demotion check
  2. Adding a null check on the GCSafeMethodTable

Also, we are now logging the m_alignpad value instead of the object address in the IllegalAlignPad function.

Author: mrsharm
Assignees: -
Labels:

area-GC-coreclr
Milestone: -

@Maoni0
Copy link
Member

Maoni0 commented Jul 19, 2022

does the LogSpewAlways actually log something in the stress log the way these tests are run? when I looked at the dumps this message was not there.

@mrsharm mrsharm marked this pull request as ready for review July 20, 2022 14:48
@mrsharm mrsharm merged commit bc05381 into dotnet:main Jul 20, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Maoni0 Maoni0 Maoni0 approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

@cshung cshung Awaiting requested review from cshung

@mangod9 mangod9 Awaiting requested review from mangod9

@PeterSolMS PeterSolMS Awaiting requested review from PeterSolMS

Assignees

@mrsharm mrsharm

Labels
area-GC-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assert failure: m_alignpad == 0 in libraries tests
3 participants
@mrsharm @Maoni0 @AaronRobinsonMSFT