Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Remove npm audit call in CI since internal npm doesn't support it and the official registry is blocked #72386

Merged
merged 1 commit into from
Jul 18, 2022
Merged

[wasm] Remove npm audit call in CI since internal npm doesn't support it and the official registry is blocked #72386

merged 1 commit into from
Jul 18, 2022

Conversation

lewing
Copy link
Member

@lewing lewing commented Jul 18, 2022

No description provided.

@lewing lewing requested a review from pavelsavara as a code owner July 18, 2022 18:17
@ghost ghost assigned lewing Jul 18, 2022
@lewing lewing requested review from radical and steveisok July 18, 2022 18:17
@radical
Copy link
Member

radical commented Jul 18, 2022

CG will catch any issues, right?

@lewing lewing requested a review from vargaz July 18, 2022 18:21
@lewing lewing mentioned this pull request Jul 18, 2022
Merged
@lewing
Copy link
Member Author

lewing commented Jul 18, 2022

Merging to unblock CI

@lewing lewing merged commit f7cba48 into dotnet:main Jul 18, 2022
@lewing lewing deleted the remove-audit branch July 18, 2022 19:08
This was referenced Jul 18, 2022
Closed
Closed
@radical
Copy link
Member

radical commented Jul 25, 2022

/backport to release/7.0-preview7

@github-actions
Copy link
Contributor

Started backporting to release/7.0-preview7: https://github.com/dotnet/runtime/actions/runs/2735432851

@github-actions
Copy link
Contributor

@radical an error occurred while backporting to release/7.0-preview7, please check the run log for details!

Error: @radical is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=radical

radical pushed a commit to radical/runtime that referenced this pull request Jul 25, 2022
@lewing @radical
Remove npm audit call in CI (dotnet#72386)
3ee67f8 
Backport from `main`.
(cherry picked from commit f7cba48)
carlossanlop pushed a commit that referenced this pull request Jul 26, 2022
@radical @lewing
Remove npm audit call in CI (#72386) (#72813)
eecb028 
Backport from `main`.
(cherry picked from commit f7cba48)

Co-authored-by: Larry Ewing <lewing@microsoft.com>
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical approved these changes

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

@steveisok steveisok Awaiting requested review from steveisok

@vargaz vargaz Awaiting requested review from vargaz

Assignees

@lewing lewing

Labels
area-Build-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lewing @radical