You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perf pipeline builds broke recently as detailed in #72104, and #72105 . AOT builds broke because il-linking would result in 10 assemblies, instead of 145! This was because the default is TrimMode=full now.
The fix is to set TrimMode=partialto opt-in to the olderlink behavior.
Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.
Issue Details
Perf pipeline builds broke recently as detailed in #72104, and #72105 . AOT builds broke because il-linking would result in 10 assemblies, instead of 145! This was because the default is TrimMode=full now.
The fix is to set TrimMode=partialto opt-in to the olderlink behavior.
I don't think we should make partial the default, the only thing breaking in this case is the perf pipeline and making more aggressive trimming is the right default for wasm outside of blazor
I don't think we should make partial the default, the only thing breaking in this case is the perf pipeline and making more aggressive trimming is the right default for wasm outside of blazor
I'm testing TrimMode=full in #72244 . And this PR will unblock the perf pipeline.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghost
assigned 
radical
force-pushed
the
fix-perf-pipeline
branch
from
Perf pipeline builds broke recently as detailed in #72104, and #72105 . AOT builds broke because il-linking would result in 10 assemblies, instead of 145! This was because the default is
TrimMode=fullnow.TrimMode=partialto opt-in to the olderlinkbehavior.TrimModevalues changed in Change linker to trim everything by default in 7.0 sdk#26246 .Note: This restores the old behavior. But we want to eventually enable
TrimMode=full.Fixes #72104
Fixes #72105