Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily exclude NativeAOT from source-build until we figure out how to handle it #71853

Closed
wants to merge 1 commit into from

Conversation

crummel
Copy link
Contributor

@crummel crummel commented Jul 8, 2022

As-is, we don't believe NativeAOT will work in source-build anyway. Removing it from the build while we decide what to do removes a prebuilt.

See #69611 for further discussion.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned crummel Jul 8, 2022
@MichalStrehovsky
Copy link
Member

Is it difficult to include llvm-project in source build? It sounds like there are two issues with NativeAOT and source build:

Cc @agocke

@MichalStrehovsky
Copy link
Member

When it comes to the build time of LLVM, objwriter only builds a small subset of LLVM and we can also do sparse checkout like this:

https://github.com/dotnet/runtimelab/blob/b2dc37ba181a7fa4427e717eab819ba3543d0ae4/src/coreclr/tools/aot/ObjWriter/build.cmd#L24-L29

It builds in about 5 minutes on my 7 year old laptop on Windows.

@@ -2,5 +2,6 @@
<Import Project="../Directory.Build.props" />
<PropertyGroup>
<IsTrimmable>true</IsTrimmable>
<ExcludeFromSourceBuild>true</ExcludeFromSourceBuild>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also exclude crossgen2 that you want to keep for source build. This would need to be done differently.

@crummel
Copy link
Contributor Author

crummel commented Jul 18, 2022

I think including the minimal subset of llvm-project for the ObjWriter package sounds reasonable and I'll give this a try. Closing this issue for now.

@crummel crummel closed this Jul 18, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants