Fix DynamicMethodDesc::Destroy vs code heap enumeration race #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a race between DynamicMethodDesc::Destroy called from the finalizer thread and the MethodDescs enumeration called from ETW::MethodLog::SendEventsForJitMethods at process exit. DynamicMethodDesc::Destroy cleanos up its members m_pSig and m_pszMethodName and then it calls GetLCGMethodResolver()->Destroy(); That calls EEJitManager::FreeCodeMemory, which tries to take the m_CodeHeapCritSec lock. But this lock is already held by the ETW::MethodLog::SendEventsForJitMethods. So the iterator can see half-destroyed DynamicMethodDesc and a crash happens when trying to get the dynamic method name from the m_pszMethodName for the ETW event purposes. The fix is to call the GetLCGMethodResolver()->Destroy() before destroying the m_pSig and m_pszMethodName.
jkotas
approved these changes
Dec 9, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race between DynamicMethodDesc::Destroy called from
the finalizer thread and the MethodDescs enumeration called from
ETW::MethodLog::SendEventsForJitMethods at process exit.
DynamicMethodDesc::Destroy cleanos up its members m_pSig and
m_pszMethodName and then it calls GetLCGMethodResolver()->Destroy();
That calls EEJitManager::FreeCodeMemory, which tries to take the
m_CodeHeapCritSec lock. But this lock is already held by
the ETW::MethodLog::SendEventsForJitMethods.
So the iterator can see half-destroyed DynamicMethodDesc and
a crash happens when trying to get the dynamic method name
from the m_pszMethodName for the ETW event purposes.
The fix is to call the GetLCGMethodResolver()->Destroy() before
destroying the m_pSig and m_pszMethodName.