Avoid some unnecessary signed casts #70884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not need a signed cast if we know the sign bit is already zero.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsWe do not need a signed cast if we know the sign bit is already zero.
|
jakobbotsch
changed the title
|
This fixes an assertion in the tailcall validation seen in the Fuzzlyn run in #70222. |
|
Minor diffs. Mainly this is just fixing another case where the inliner was inserting unnecessary IR after a tailcall. cc @dotnet/jit-contrib PTAL @EgorBo |
|
ping @EgorBo |
1 similar comment
|
ping @EgorBo |
EgorBo
approved these changes
Jun 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not need a signed cast if we know the sign bit is already zero.