Set UnusedValue correctly for the operands of ARR_ADDR/BOX
#70498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Details#70398 exposed a previously unseen case of top-level ***** BB05
STMT00032 ( ??? ... 0x0E9 )
N010 ( 10, 9) [001316] -A--------- * ARR_ADDR byref ubyte[] $301
N009 ( 10, 9) [001317] -A-----N--- \--* ADD byref $2ca
N007 ( 10, 9) [002064] -A--------- +--* COMMA byref $2c0
N005 ( 7, 7) [002062] -A------R-- | +--* ASG byref $VN.Void
N004 ( 3, 2) [002061] D------N--- | | +--* LCL_VAR byref V70 cse3 d:1 $2c0
N003 ( 3, 4) [001318] ----------- | | \--* ADD byref $2c0
N001 ( 1, 1) [001319] ----------- | | +--* LCL_VAR ref V03 loc3 u:2 $241
N002 ( 1, 2) [001320] ----------- | | \--* CNS_INT long 16 $1c1
N006 ( 3, 2) [002063] ----------- | \--* LCL_VAR byref V70 cse3 u:1 $2c0
N008 ( 1, 2) [002085] ----------- \--* CNS_INT long 1 $1c4When we rationalize these nodes, we replace them with their operands. That handling was not quite complete, resulting in some missed Fixes #70466.
|
SingleAccretion
changed the title
UnusedValue when replacing dummy defsUnusedValue correctly for ARR_ADDR/BOX operands
SingleAccretion
force-pushed
the
Fix-LIR-Unused-Value
branch
from
d85bfef
to
5cb80f6
Compare
SingleAccretion
force-pushed
the
Fix-LIR-Unused-Value
branch
from
5cb80f6
to
f991889
Compare
SingleAccretion
changed the title
UnusedValue correctly for ARR_ADDR/BOX operandsUnusedValue correctly for the operands of ARR_ADDR/BOX
|
@dotnet/jit-contrib Fixing stress. |
jakobbotsch
approved these changes
Jun 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#70398 exposed a previously unseen case of a top-level
ARR_ADDRnode:When we rationalize these nodes, we replace them with their operands. That handling was not quite complete, resulting in some missed
UnusedValueflags.Fixes #70466.
No diffs as expected.