Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not retype SIMD nodes #70265

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Do not retype SIMD nodes #70265

merged 2 commits into from
Jun 7, 2022

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Jun 5, 2022 •
edited
Loading

Fixes #70124.
Fixes #70260.

No diffs as expected.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 5, 2022
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 5, 2022
@ghost
Copy link

ghost commented Jun 5, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #70124.
Fixes #70260.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@SingleAccretion
Do not retype SIMD nodes
d9768bc 
It is not necessary: the only case where it is required, SIMD8 to
LONG bitcasts on Windows x64, is already handled by lowering.

It is dangerous: in case we CSE the retyped tree, its other uses
will be (effectively) retyped as well.
@SingleAccretion
Add a test
55b6671
@SingleAccretion
Copy link
Contributor Author

@dotnet/jit-contrib We need a libraries stress run for this change.

@BruceForstall
Copy link
Member

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@SingleAccretion SingleAccretion marked this pull request as ready for review June 6, 2022 09:06
@SingleAccretion
Copy link
Contributor Author

Stress failure:

Libraries stress failures:

@dotnet/jit-contrib

@JulieLeeMSFT JulieLeeMSFT added this to the 7.0.0 milestone Jun 6, 2022
@BruceForstall BruceForstall merged commit 09b2da8 into dotnet:main Jun 7, 2022
@SingleAccretion SingleAccretion mentioned this pull request Jun 7, 2022
Merged
@SingleAccretion SingleAccretion deleted the No-Simd-Retyping branch June 7, 2022 08:56
@ghost ghost locked as resolved and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BruceForstall BruceForstall BruceForstall approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
7.0.0
3 participants
@SingleAccretion @BruceForstall @JulieLeeMSFT