Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use LEAs in HIR #69992

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Do not use LEAs in HIR #69992

merged 2 commits into from
Jun 7, 2022

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented May 30, 2022 •
edited
Loading

The canonical form of a LEA-equivalent expression in HIR is explicit address arithmetic.

Fixes #64375.

Diffs - some improvements from LCL_FLD folding, some regressions from inserting the zero-extending casts. Also a small TP regression, payed for with #69958.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 30, 2022
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 30, 2022
@ghost
Copy link

ghost commented May 30, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

The canonical form of a LEA-equivalent expression in HIR is explicit address arithmetic.

Fixes #64375.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@runfoapp runfoapp bot mentioned this pull request May 31, 2022
Closed
@SingleAccretion SingleAccretion marked this pull request as ready for review May 31, 2022 18:13
@SingleAccretion
Copy link
Contributor Author

@dotnet/jit-contrib

@JulieLeeMSFT JulieLeeMSFT requested a review from EgorBo June 2, 2022 19:06
@JulieLeeMSFT JulieLeeMSFT added this to the 7.0.0 milestone Jun 2, 2022
@SingleAccretion
Make LEAs backend-only
95e8cef 
In the frontend, for better or worse, the canonical form
of address arithmetic is explicit pointer arithmetic.
@SingleAccretion
Add a test
c0cfc6d
BruceForstall
BruceForstall approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BruceForstall BruceForstall merged commit 019a009 into dotnet:main Jun 7, 2022
@SingleAccretion SingleAccretion deleted the No-LEA-In-HIR branch June 7, 2022 08:56
@tannergooding tannergooding mentioned this pull request Jun 7, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BruceForstall BruceForstall BruceForstall approved these changes

@EgorBo EgorBo Awaiting requested review from EgorBo

Assignees

@EgorBo EgorBo

@SingleAccretion SingleAccretion

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Vector3.Cross calculates wrong value
4 participants
@SingleAccretion @BruceForstall @EgorBo @JulieLeeMSFT