Store actual signature types in CallArg and normalize to that type #69969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, for struct args, we would use the class handle of the argument (from the IL stack) instead of the class handle from the signature. These may sometimes differ in __Canon when inlining shared code. This change switches the class handle stored in CallArg to always be the type reported back by the EE when asking about the signature.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsPreviously, for struct args, we would use the class handle of the This should no longer have the positive diffs the comment talks about; those positive diffs (and more) were realized in #68986 by the removal of
|
|
cc @dotnet/jit-contrib, some tiny diffs. |
EgorBo
approved these changes
May 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, for struct args, we would use the class handle of the
argument (from the IL stack) instead of the class handle from the
signature. These may sometimes differ in __Canon when inlining shared
code. This change switches the class handle stored in CallArg to always
be the type reported back by the EE when asking about the signature.
This should no longer have the positive diffs the comment talks about; those positive diffs (and more) were realized in #68986 by the removal of
fgMorphCanUseLclFldForCopy.