Implement constant-folding for VNF_BitCast
#68979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsCompletes the support for said function. A small number of diffs in tests where we form new constants from
|
SingleAccretion
force-pushed
the
Physical-VN-BitCast-Upstream
branch
from
2fda552
to
c73ed51
Compare
|
Windows ARM64 failures with empty logs look like infrastructure issues. @dotnet/jit-contrib |
|
Still needs some work. |
SingleAccretion
force-pushed
the
Physical-VN-BitCast-Upstream
branch
3 times, most recently
from
628eeba
to
1e1aaa2
Compare
|
Should be complete at this point. |
SingleAccretion
force-pushed
the
Physical-VN-BitCast-Upstream
branch
from
1e1aaa2
to
163a537
Compare
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
A few small diffs in tests where we now form new constants for "long/int <-> double/float>" reinterpretations. Completes the support for "VNF_BitCast" and removes the SIMD quirk from "VNForLoadStoreBitCast".
SingleAccretion
force-pushed
the
Physical-VN-BitCast-Upstream
branch
from
163a537
to
ed4d088
Compare
jakobbotsch
reviewed
May 14, 2022
Only usage of "active" union members is well-defined in C++.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes the support for said function.
A small number of diffs:
FP <-> integerreinterpretations.BitCastlogic can skip redundant casts for small types in some cases. This new precision is not all that useful however because the new CSE defs throw exceptions different from their uses (typical case:Def: field = array[0]; Use: read field; Use: read field).