Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parts of an assert back #68481

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Add parts of an assert back #68481

merged 1 commit into from
Apr 25, 2022

Conversation

jakobbotsch
Copy link
Member

Under JitRepeatOpts we sometimes turn early-arg stores into GT_NOP
nodes.

Fix #68472 (the test there runs under JitRepeatOpts=*).

This assert can be removed in #68460 again.

Under JitRepeatOpts we sometimes turn early-arg stores into GT_NOP
nodes.

Fix dotnet#68472
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 25, 2022
@ghost ghost assigned jakobbotsch Apr 25, 2022
@ghost
Copy link

ghost commented Apr 25, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Under JitRepeatOpts we sometimes turn early-arg stores into GT_NOP
nodes.

Fix #68472 (the test there runs under JitRepeatOpts=*).

This assert can be removed in #68460 again.

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@jakobbotsch jakobbotsch changed the title Add an assert back Add parts of an assert back Apr 25, 2022
@AndyAyersMS
Copy link
Member

Fix #68472 (the test there runs under JitRepeatOpts=*).

The PGO runs don't use JitRepeatOpts.

@jakobbotsch
Copy link
Member Author

The PGO runs don't use JitRepeatOpts.

The failing test is Runtime_56953 which sets it for all methods in its .csproj file:

<CLRTestBatchPreCommands><![CDATA[
$(CLRTestBatchPreCommands)
set COMPlus_JitOptRepeat=*
]]></CLRTestBatchPreCommands>
<BashCLRTestPreCommands><![CDATA[
$(BashCLRTestPreCommands)
export COMPlus_JitOptRepeat=*
]]></BashCLRTestPreCommands>

This combined with COMPlus_ReadyToRun=0 hits the problem in a few methods in SPC.

@jakobbotsch jakobbotsch requested a review from AndyAyersMS April 25, 2022 17:11
@jakobbotsch jakobbotsch merged commit 08dcd6f into dotnet:main Apr 25, 2022
@jakobbotsch jakobbotsch deleted the fix-68472 branch April 25, 2022 18:13
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIT: Assertion failed 'arg->OperIsStore() || arg->OperIsCopyBlkOp()' in PGO testing
2 participants