-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure floating-point types write the exponent/significand as little-endian #68331
Ensure floating-point types write the exponent/significand as little-endian #68331
Conversation
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsDiscovered by @uweigand in #68141 (comment)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Are there existing unit tests that catch this bug, at least before you fixed it?
Yes. The problem is that we don't run any CI legs that cover This was caught in the outer loop on some jobs running against an s390x on Mono. |
The CI is running the full runtime test suite on s390x (this is the dotnet runtime using the Mono JIT): But this is just running twice a day and not as part of the PR checks, so big endian breakages are usually not detected pre-commit unfortunately. |
Thank, @tannergooding! This fixes the binary floating-point tests, but there's still a failure in a decimal floating-point test:
Looks like this place also needs to be updated: runtime/src/libraries/System.Private.CoreLib/src/System/Decimal.cs Lines 1194 to 1195 in a9d25b6
|
Discovered by @uweigand in #68141 (comment)