-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][debugger] Fix a randomly failing JS test #67945
Conversation
`DebuggerTests.ExceptionTests.JSExceptionTestAll` can some times fail with: ``` [xUnit.net 00:01:08.51] DebuggerTests.ExceptionTests.JSExceptionTestAll [FAIL] Failed DebuggerTests.ExceptionTests.JSExceptionTestAll [105 ms] Error Message: [{ "callFrameId": "-2618252572970282349.1.0", "functionName": "lookup", ... Expected: exception_caught_test Actual: lookup Stack Trace: at DebuggerTests.DebuggerTestBase.AssertEqual(Object expected, Object actual, String label) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 1119 at DebuggerTests.DebuggerTestBase.SendCommandAndCheck(JObject args, String method, String script_loc, Int32 line, Int32 column, String function_name, Func`2 wait_for_event_fn, Func`2 locals_fn, String waitForEvent) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 562 at DebuggerTests.DebuggerTestBase.EvaluateAndCheck(String expression, String script_loc, Int32 line, Int32 column, String function_name, Func`2 wait_for_event_fn, Func`2 locals_fn) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 542 at DebuggerTests.ExceptionTests.JSExceptionTestAll() in /_/src/mono/wasm/debugger/DebuggerTestSuite/ExceptionTests.cs:line 70 ``` This test is set to pause on every exception thrown, but the test assumes that the first exception that it gets will be the expected one. But we can get other JS exceptions before that. So, wait for the correct one, while ignoring any *js* ones.
Tagging subscribers to 'arch-wasm': @lewing Issue Details
This test is set to pause on every exception thrown, but the test
|
Failure is unrelated |
DebuggerTests.ExceptionTests.JSExceptionTestAll
can some times failwith:
This test is set to pause on every exception thrown, but the test
assumes that the first exception that it gets will be the expected one.
But we can get other JS exceptions before that. So, wait for the correct
one, while ignoring any other js ones.