[wasm] Update line numbers to track recent changes in JSConditionalBr… #67944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eakpoint test `debugger-driver.html` was changed in ae5d422e873016d558db236d15c135453b8d603d, but not all the line numbers in JSConditionalBreakpoint were updated. This can cause the breakpoint to not be hit, and the test to timeout instead.
ghost
assigned 
|
Tagging subscribers to this area: @thaystg Issue Details…eakpoint test
This can cause the breakpoint to not be hit, and the test to timeout
|
thaystg
approved these changes
Apr 13, 2022
|
Unrelated failing test is #67948 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eakpoint test
debugger-driver.htmlwas changed inae5d422e873016d558db236d15c135453b8d603d, but not all the line numbers in
JSConditionalBreakpoint were updated.
This can cause the breakpoint to not be hit, and the test to timeout
instead.