Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip SIP in walk_relocation #67889

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

cshung
Copy link
Member

@cshung cshung commented Apr 12, 2022

This change skips the SIP regions during walk_relocation.

This does not report all survivors and it will be done in a separate PR.

Fixes #64263.

@ghost
Copy link

ghost commented Apr 12, 2022

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

This change skips the SIP regions during walk_relocation.

Fixes #64263.

Author: cshung
Assignees: -
Labels:

area-GC-coreclr

Milestone: -

@cshung cshung force-pushed the public/skip-sip-in-walk-relocation branch 2 times, most recently from 15a5648 to 5cd8007 Compare April 12, 2022 21:01
@cshung cshung force-pushed the public/skip-sip-in-walk-relocation branch from 5cd8007 to fc807c6 Compare April 12, 2022 21:54
@cshung cshung changed the title [WIP] Skip SIP in walk_relocation Skip SIP in walk_relocation Apr 12, 2022
Copy link
Member

@Maoni0 Maoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cshung cshung merged commit 537a547 into dotnet:main Apr 13, 2022
@cshung cshung deleted the public/skip-sip-in-walk-relocation branch April 13, 2022 00:54
@cshung cshung mentioned this pull request Apr 13, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With .NET 7 SDK, create razor project failed with error when running PerfView
2 participants