Fix exception thrown when MsQuicStream write direction is locally aborted or canceled

[rzikm]

Fixes #67612.

The issue with the original code was that when MsQuicStream s write direction was locally aborted, subsequent WriteAsync calls threw OperationCanceledException which does not make sense since the associated CancellationToken was not expired (or wasn't even cancellable for that matter).

This PR changes that behavior to throw QuicOperationAbortedException instead, which is in line with #55619.

Also, when a WriteAsync call si canceled (either during actual write or pre-canceled), subsequent (non-pre-canceled) operations now throw QuicOperationAbortedException like we do on the reading side of the stream.

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #67612.

The issue with the original code was that when MsQuicStream s write direction was locally aborted, subsequent WriteAsync calls threw OperationCanceledException instead of QuicOperationAbortedException. The original exception did not make sense since the associated CancellationToken was not expired (or wasn't even cancellable for that matter). The new exception is more in line with #55619

Author:	rzikm
Assignees:	-
Labels:	area-System.Net.Quic
Milestone:	-

[ManickaP]

One question, otherwise LGTM, thanks!

[ManickaP]

Any reason for not providing a message here?

[rzikm]

no reason, I forgot to put it there when copying

[rzikm]

Looks like this will not be so simple, the stream conformance tests are failing

[xUnit.net 00:00:33.05]     System.Net.Quic.Tests.MsQuicQuicStreamConformanceTests.ReadWriteAsync_PrecanceledOperations_ThrowsCancellationException [FAIL]
  Failed System.Net.Quic.Tests.MsQuicQuicStreamConformanceTests.ReadWriteAsync_PrecanceledOperations_ThrowsCancellationException [17 ms]
  Error Message:
   Assert.Throws() Failure
Expected: typeof(System.OperationCanceledException)
Actual:   typeof(System.Net.Quic.QuicOperationAbortedException): Sending has already been aborted on the stream
---- System.Net.Quic.QuicOperationAbortedException : Sending has already been aborted on the stream
  Stack Trace:
     at System.Net.Quic.Implementations.MsQuic.MsQuicStream.HandleWriteStartState(Boolean emptyBuffer, CancellationToken cancellationToken) in C:\source\runtime\src\libraries\System.Net.Quic\src\System\Net\Quic\Implementations\MsQuic\MsQuicStream.cs:line 332
   at System.Net.Quic.Implementations.MsQuic.MsQuicStream.WriteAsync(ReadOnlyMemory`1 buffer, Boolean endStream, CancellationToken cancellationToken) in C:\source\runtime\src\libraries\System.Net.Quic\src\System\Net\Quic\Implementations\MsQuic\MsQuicStream.cs:line 310
   at System.IO.Tests.StreamConformanceTests.<>c__DisplayClass54_0.<<ValidatePrecanceledOperations_ThrowsCancellationException>b__3>d.MoveNext() in C:\source\runtime\src\libraries\Common\tests\StreamConformanceTests\System\IO\StreamConformanceTests.cs:line 515
--- End of stack trace from previous location ---
----- Inner Stack Trace -----

[rzikm]

/azp run runtime-libraries-coreclr outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[rzikm]

It seems we need to change the exception after canceling WriteAsync, after consulting with @CarnaViire, I followed what we do on the read side of the stream to make the behavior consistent. I updated the PR description to reflect this.

@ManickaP can you please review again?

[ManickaP]

LGTM, thanks!

[rzikm]

The failing test is unrelated (System.Security.Cryptography.Pkcs.Tests.SignedCmsTests.AddSignerWithNegativeSerial)