Add some documentation on GT_CAST's semantics
#67208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The semantics of cast nodes are notoriously complicated. It was requested documentation be added clarifying some of the less obvious bits, this change does just that.
ghost
added
the
community-contribution
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThe semantics of cast nodes are notoriously complicated. It was requested documentation be added clarifying some of the less obvious bits, this change does just that.
|
|
@dotnet/jit-contrib, @EgorBo |
"Integer -> FP" (always) unchecked casts also use "IsUnsigned".
jakobbotsch
approved these changes
Mar 27, 2022
BruceForstall
approved these changes
Mar 28, 2022
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
* Add documentation on GT_CAST's semantics The semantics of cast nodes are notoriously complicated. It was requested documentation be added clarifying some of the less obvious bits, this change does just that. * Fix a typo, add the "integer -> FP" case "Integer -> FP" (always) unchecked casts also use "IsUnsigned".
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The semantics of cast nodes are notoriously complicated. It was requested documentation be added clarifying some of the less obvious bits, this change does just that.