-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix loop cloning for OSR #67067
Fix loop cloning for OSR #67067
Conversation
Fix a previously unused piece of code to handle a loop cloning case where the `head` block of a loop branches to the entry block.
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsFix a previously unused piece of code to handle a loop cloning case
|
The code in question was unused, as the comment stated. The fix: remove simple C++ variable name shadow declaration :-) |
@AndyAyersMS PTAL |
@AndyAyersMS Feel free to suggest or kick off appropriate OSR testing. |
/azp run runtime-jit-experimental |
Azure Pipelines successfully started running 1 pipeline(s). |
Note the experimental tests are seeing ARM64 failures because of #66924, so some failures are expected. |
@AndyAyersMS Can you advise if the failures in https://dev.azure.com/dnceng/public/_build/results?buildId=1679130&view=ms.vss-test-web.build-test-results-tab are "expected"? They are all arm64. |
Yeah, those look like the expected ones. |
Fix a previously unused piece of code to handle a loop cloning case where the `head` block of a loop branches to the entry block.
Fix a previously unused piece of code to handle a loop cloning case
where the
head
block of a loop branches to the entry block.