Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loop cloning for OSR #67067

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Conversation

BruceForstall
Copy link
Member

Fix a previously unused piece of code to handle a loop cloning case
where the head block of a loop branches to the entry block.

Fix a previously unused piece of code to handle a loop cloning case
where the `head` block of a loop branches to the entry block.
@ghost ghost assigned BruceForstall Mar 23, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 23, 2022
@ghost
Copy link

ghost commented Mar 23, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix a previously unused piece of code to handle a loop cloning case
where the head block of a loop branches to the entry block.

Author: BruceForstall
Assignees: BruceForstall
Labels:

area-CodeGen-coreclr

Milestone: -

@BruceForstall
Copy link
Member Author

The code in question was unused, as the comment stated. The fix: remove simple C++ variable name shadow declaration :-)

@BruceForstall
Copy link
Member Author

@AndyAyersMS PTAL
cc @dotnet/jit-contrib

@BruceForstall
Copy link
Member Author

@AndyAyersMS Feel free to suggest or kick off appropriate OSR testing.

@AndyAyersMS
Copy link
Member

/azp run runtime-jit-experimental

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AndyAyersMS
Copy link
Member

Note the experimental tests are seeing ARM64 failures because of #66924, so some failures are expected.

@BruceForstall
Copy link
Member Author

@AndyAyersMS Can you advise if the failures in https://dev.azure.com/dnceng/public/_build/results?buildId=1679130&view=ms.vss-test-web.build-test-results-tab are "expected"? They are all arm64.

@AndyAyersMS
Copy link
Member

@AndyAyersMS Can you advise if the failures in https://dev.azure.com/dnceng/public/_build/results?buildId=1679130&view=ms.vss-test-web.build-test-results-tab are "expected"? They are all arm64

Yeah, those look like the expected ones.

@BruceForstall BruceForstall merged commit 3fe2959 into dotnet:main Mar 24, 2022
@BruceForstall BruceForstall deleted the FixOsrCloning branch March 24, 2022 17:18
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
Fix a previously unused piece of code to handle a loop cloning case
where the `head` block of a loop branches to the entry block.
@ghost ghost locked as resolved and limited conversation to collaborators Apr 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants