Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete System.Runtime.Experimental leftovers #66819

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Conversation

ViktorHofer
Copy link
Member

e34e8dd merged the API surface of System.Runtime.Experimental inbox and deleted the project and the package. Hence we should delete leftovers that reference it.

e34e8dd merged the API surface of System.Runtime.Experimental inbox and deleted the project and the package. Hence we should delete leftovers that reference it.
@ViktorHofer ViktorHofer self-assigned this Mar 18, 2022
@ViktorHofer
Copy link
Member Author

@tannergooding are these two lines still required?

<!-- The following 2 lines disable the automatic generation of the [RequiresPreviewFeatures] assembly level attribute and set LangVersion to Preview on the latest TFM-->
<EnablePreviewFeatures>True</EnablePreviewFeatures>
<GenerateRequiresPreviewFeaturesAttribute>False</GenerateRequiresPreviewFeaturesAttribute>

@tannergooding
Copy link
Member

@ViktorHofer, not sure. I don't recall exactly how use of static abstracts in interfaces plays here with the analyzer and what will or will not cause issues.

@ghost
Copy link

ghost commented Mar 18, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

e34e8dd merged the API surface of System.Runtime.Experimental inbox and deleted the project and the package. Hence we should delete leftovers that reference it.

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries

Milestone: -

@danmoseley
Copy link
Member

Failure has an issue open.

@danmoseley danmoseley merged commit 0b1eb7f into main Mar 23, 2022
@danmoseley danmoseley deleted the ViktorHofer-patch-1 branch March 23, 2022 15:12
@danmoseley
Copy link
Member

Who can answer the question about EnablePreviewFeatures above (@jeffhandley ?)

@jeffhandley
Copy link
Member

Who can answer the question about EnablePreviewFeatures above (@jeffhandley ?)

Addressed in #67162

radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
* Delete System.Runtime.Experimental leftovers

e34e8dd merged the API surface of System.Runtime.Experimental inbox and deleted the project and the package. Hence we should delete leftovers that reference it.

* Update System.Runtime.csproj
@ghost ghost locked as resolved and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants