Port Access violation occurring in System.DirectoryServices.ActiveDirectory.ForestTrustRelationshipInformation fix from .netfx to .net-core

[kumarravi]

• Description: Access violation occurring in System.DirectoryServices.ActiveDirectory.ForestTrustRelationshipInformation.GetForestTrustInfoHelper
• Customer Impact: None yet, customer had an issue in .netfx because they were using .netfx to fetch forest trust information. If any customer uses .netcore to do something similar then this fix should mitigate the issue. None of the customers have reported any issues with .netcore yet.
• Regression: Yes, The issue was introduced when windows 1B security fixes were released. We missed the corresponding fix in ,net code and hence this pr.
• Risk: Very low
• Original Issue: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1465335
• Original PR: https://vstfdevdiv/DevDiv2/DevDiv/_versionControl/changeset/1764922

[dnfadmin]

All CLA requirements met.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-directoryservices, @jay98014
See info in area-owners.md if you want to be subscribed.

Issue Details

---

• Description: Access violation occurring in System.DirectoryServices.ActiveDirectory.ForestTrustRelationshipInformation.GetForestTrustInfoHelper
• Customer Impact: None yet, customer had an issue in .netfx because they were using .netfx to fetch forest trust information. If any customer uses .netcore to do something similar then this fix should mitigate the issue. None of the customers have reported any issues with .netcore yet.
• Regression: Yes, The issue was introduced when windows 1B security fixes were released. We missed the corresponding fix in ,net code and hence this pr.
• Risk: Very low
• Original Issue: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1465335
• Original PR: https://vstfdevdiv/DevDiv2/DevDiv/_versionControl/changeset/1764922

Author:	kumarravi
Assignees:	-
Labels:	area-System.DirectoryServices, community-contribution
Milestone:	-

[danmoseley]

@kumarravi unlike the .NET Framework sources, this codebase uses nullable reference type annotations hence the error. If you know a reference is undoubtedly not nullable, it may be appropriate to use the ! operator to stop the error.

BTW, should we include you in https://github.com/dotnet/runtime/blob/main/docs/area-owners.md ?

[kumarravi]

@danmoseley Thanks for the review. Apologies for not being clear but this PR is work in progress. And thanks again for the resolution of the errors I was seeing. You saved me some time which I would have spent trying to resolve these.

Since Active directory team is the owner of this code, I would like to be added as the co-owner of the repo. Thanks

[danmoseley]

@kumarravi Feel free to offer a PR to the markdown I linked. (It's easy, no builds/tests will run)

[kumarravi]

@danmoseley Apologies but I cannot find the markdown that you linked. Can you let me know what you mean by "offer a PR to the markup"?

[joperezr]

Thanks for the contribution @kumarravi I will take a look at this very soon.

Apologies but I cannot find the markdown that you linked. Can you let me know what you mean by "offer a PR to the markup"?

He means that if you want to be included as a area-owner for DirectoryServices, you can submit a separate PR where you are modifying this file: https://github.com/dotnet/runtime/blob/main/docs/area-owners.md

In particular, you would want to add your alias right next to the DirectoryServices area like:

-| area-System.DirectoryServices                  | @ericstj      | @dotnet/area-system-directoryservices               | Consultants: @BRDPM @grubioe @jay98014               
+| area-System.DirectoryServices                  | @ericstj      | @dotnet/area-system-directoryservices               | Consultants: @BRDPM @grubioe @jay98014 @kumarravi         

[kumarravi]

@joperezr a gentle reminder about the above request. Thanks!

[joperezr]

Sorry for missing the review here. I'm not familiar with this code, but the changes look good and match the internal checked in fix. Is there a test that we can add for regression protection here?

[kumarravi]

@joperezr Thanks for the approval. I really appreciate it. I think the reason we did not put any tests for this fix was that this
scenario is so end case and complex that is not easy to put in a test case. @jay98014 please feel to correct me if I am wrong.

Looks like I do not have the permissions to merge this PR. I would have to request write access. Can someone with write access merge this PR or tell me how to request the same.