Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Roslyn Testing SDK #66681

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Conversation

jkoritzinsky
Copy link
Member

Update the Roslyn testing SDK to pick up fixes for the NuGet package download that's part of the ReferenceAssemblies API.

…download that's part of the ReferenceAssemblies API.
@ghost
Copy link

ghost commented Mar 15, 2022

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Update the Roslyn testing SDK to pick up fixes for the NuGet package download that's part of the ReferenceAssemblies API.

Author: jkoritzinsky
Assignees: -
Labels:

area-System.Runtime.InteropServices

Milestone: -

@elinor-fung
Copy link
Member

We should also be able to get rid of this, right?

internal static void ThrowSkipExceptionIfPackagingException(Exception e)

@jkoritzinsky
Copy link
Member Author

I thought I removed that... I'll go back and make sure I delete it

@jkoritzinsky
Copy link
Member Author

Test failure is unrelated. This is ready for another round of review

Copy link
Member

@elinor-fung elinor-fung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurray!

@jkoritzinsky jkoritzinsky merged commit e118c90 into dotnet:main Mar 16, 2022
@jkoritzinsky jkoritzinsky deleted the update-roslyn-sdk branch March 16, 2022 22:38
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants