Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use StartsWith(..., OrdinalIgnoreCase) in RegexCompiler / source generator #66339

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Use StartsWith(..., OrdinalIgnoreCase) in RegexCompiler / source generator #66339

merged 2 commits into from
Mar 10, 2022

Commits on Mar 9, 2022

  1. Use StartsWith(..., OrdinalIgnoreCase) in RegexCompiler / source gene… 

    …rator

When we encounter a sequence of sets representing case-insensitive ASCII, we can simplify the code generated to just call StartsWith, which both makes it more readable but also takes advantage of the new JIT optimization to lower that into efficient vectorized comparisons based on the supplied literal.

This also cleans up some formatting in the source generator emitted code to make things much more concise and less noisy.
    @stephentoub
    stephentoub committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    b28af20 View commit details
    Browse the repository at this point in the history

  2. Address PR feedback

    @stephentoub
    stephentoub committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    5622dc2 View commit details
    Browse the repository at this point in the history