Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Binding to non-null IEnumerable doesn't work #36390 #66131

Merged
merged 6 commits into from
Mar 17, 2022
Merged

Fixes Binding to non-null IEnumerable doesn't work #36390 #66131

merged 6 commits into from
Mar 17, 2022

Conversation

SteveDunn
Copy link
Contributor

Fixes Binding to non-null IEnumerable doesn't work #36390

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Mar 3, 2022
@ghost
Copy link

ghost commented Mar 3, 2022

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes Binding to non-null IEnumerable doesn't work #36390

Author: SteveDunn
Assignees: -
Labels:

area-Extensions-Configuration
Milestone: -

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Mar 3, 2022
@maryamariyan maryamariyan requested a review from halter73 March 3, 2022 12:57
@SteveDunn SteveDunn force-pushed the bind-non-null-ienumerable branch from 3918952 to c9ef81a Compare March 3, 2022 21:23
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Mar 3, 2022
@SteveDunn SteveDunn mentioned this pull request Mar 8, 2022
Closed
@maryamariyan
Copy link
Member

Hi @maryamariyan . Do I need to do anything else for this PR? Do I 'Resolve conversation ' or so you do it?

@SteveDunn the ones you addressed you could mark as resolved.

Also note, the blank line is still in the diff, you'd want to reconfirm if the commit/changes you wanted is showing up in the PR through the diff tab.

@maryamariyan maryamariyan added the needs-author-action An issue or pull request that requires more info or actions from the author. label Mar 14, 2022
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Mar 14, 2022
maryamariyan
maryamariyan approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@maryamariyan maryamariyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but there's some nit changes to be addressed. I think your branch is not in sync with what's present in the PR diff

src/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs Outdated Show resolved Hide resolved
...aries/Microsoft.Extensions.Configuration.Binder/tests/ConfigurationCollectionBindingTests.cs Outdated Show resolved Hide resolved
...aries/Microsoft.Extensions.Configuration.Binder/tests/ConfigurationCollectionBindingTests.cs Outdated Show resolved Hide resolved
@SteveDunn
Copy link
Contributor Author

Overall LGTM, but there's some nit changes to be addressed. I think your branch is not in sync with what's present in the PR diff

@maryamariyan - should all be OK now.

@halter73
Copy link
Member

Thanks @SteveDunn!

@runfoapp runfoapp bot mentioned this pull request Mar 15, 2022
Closed
@maryamariyan maryamariyan merged commit 048da75 into dotnet:main Mar 17, 2022
@maryamariyan
Copy link
Member

merged now. @SteveDunn this should be available in preview 3. thanks for your contribution!

@runfoapp runfoapp bot mentioned this pull request Mar 18, 2022
Closed
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
@SteveDunn @radekdoulik
Fixes Binding to non-null IEnumerable doesn't work dotnet#36390 (dotn…
f6dd22a 
…et#66131)
@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2022
@SteveDunn SteveDunn deleted the bind-non-null-ienumerable branch May 3, 2022 19:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tarekgh tarekgh tarekgh approved these changes

@maryamariyan maryamariyan maryamariyan approved these changes

@halter73 halter73 halter73 approved these changes

Assignees
No one assigned
Labels
area-Extensions-Configuration community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SteveDunn @maryamariyan @halter73 @tarekgh