Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect exception comment from AsSpan #66051

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Remove incorrect exception comment from AsSpan #66051

merged 1 commit into from
Mar 2, 2022

Conversation

333fred
Copy link
Member

@333fred 333fred commented Mar 2, 2022

Description

This method never throws an ArgumentNullException for a null text input, and is even annotated as accepting string?.

Customer Impact

Docs are wrong.

Regression

No.

Testing

None. Doc fix.

Risk

None. Doc fix.

This method never throws an `ArgumentNullException` for a null `text` input, and is even annotated as accepting `string?`.
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Mar 2, 2022

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

This method never throws an ArgumentNullException for a null text input, and is even annotated as accepting string?.

Customer Impact

Docs are wrong.

Regression

No.

Testing

None. Doc fix.

Risk

None. Doc fix.

Author: 333fred
Assignees: 333fred
Labels:

area-System.Memory

Milestone: -

@stephentoub
Copy link
Member

Thanks. I've submitted a PR for docs.microsoft.com at dotnet/dotnet-api-docs#7782.

@stephentoub stephentoub merged commit 1ad0540 into main Mar 2, 2022
@stephentoub stephentoub deleted the fix-docs branch March 2, 2022 03:05
@ghost ghost locked as resolved and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants