retire DummyTcpServer from SslStream tests #65876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfurt
added
area-System.Net.Security
test-enhancement
|
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue Detailscontributes to #52362. When Disposing the server only stops the listener. So we can still have tests running after the test is finished. Related to that (and even more problematic) is fact that we don't have visibility to server failures. So when something fails we get that is really hard to troubleshoot for random CI failures.
|
rzikm
reviewed
Feb 25, 2022
src/libraries/System.Net.Security/tests/FunctionalTests/ClientAsyncAuthenticateTest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Security/tests/FunctionalTests/ClientDefaultEncryptionTest.cs
Outdated
Show resolved
Hide resolved
rzikm
approved these changes
Mar 3, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributes to #52362.
Aside from DummyTcpServer using APM & IAsyncResult that are pain to debug there some other issue:
When Disposing the server only stops the listener. So we can still have tests running after the test is finished. Related to that (and even more problematic) is fact that we don't have visibility to server failures. So when something fails we get
that is really hard to troubleshoot for random CI failures.
Since we already have helper function to get connected stream I switched to that and we await for the server parts as well to have better visibility to failures.