Do not set GLOB_REF for invariant indirections
#65709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
added
the
community-contribution
The GTF_GLOB_REF flag in the compiler has the meaning that the node marked with it produces a value that could be modified by a call or an indirect store. It is used for optimizations that need to know whether it is safe to reorder two trees. Invariant indirections, by definition, always produce the same value, and as such do not need to be marked with GLOB_REF. Some nice diffs from args sorting: string literals can now be put in the "late args" list directly (without a temp).
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThe Invariant indirections, by definition, always produce the same value, and as such do not need to be marked with Some nice diffs from args sorting: string literals can now be put in the "late args" list directly (without a temp).
|
SingleAccretion
force-pushed
the
No-Glob-Ref-For-Invariant-Indirs
branch
from
ba49991 to
564c640
Compare
|
@dotnet/jit-contrib Another preparatory change for |
|
That was fast 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GTF_GLOB_REFflag in the compiler has the meaning that the node marked with it produces a value that could be modified by a call or an indirect store. It is used for optimizations that need to know whether it is safe to reorder two trees.Invariant indirections, by definition, always produce the same value, and as such do not need to be marked with
GLOB_REF.Some nice diffs from args sorting: string literals can now be put in the "late args" list directly (without a temp).