-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic fake NTLM server to test NTAuthentication round-trip scenarios #65611
Conversation
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsIgnore, just want to see CI results across all the system configurations.
|
src/libraries/System.Net.Security/tests/UnitTests/NTAuthenticationTests.cs
Show resolved
Hide resolved
src/libraries/System.Net.Security/tests/UnitTests/NTAuthenticationTests.cs
Show resolved
Hide resolved
I'm not sure if we really should go to the weeds of understanding NTLM internal in the tests. cc: @rzikm @pavelsavara |
I tried to avoid it for as long as I could but I snapped in the end. There were too many issues not covered by the tests and that could not even easily be covered by the tests.
If you are willing to host a test infrastructure I think that may provide a solid middle ground. However, the issue is not just HTTP. The SMTP GSSAPI authentication is currently broken on anything but Windows and there's no test coverage at all. We, at @emclient, have been hosting our own testing infrastructure for quite a while now and it's not easy. The Exchange servers bit rot constantly, the Windows Server 2019 machine on Azure needs to be restarted daily (seems to be a VM size issue and resource depletion). I would be fine writing a simple echo SMTP server to cover the scenario above but I would need a commitment on hosting it and supporting it to be hammered by the .NET test infrastructure. Is that even something reasonable to ask? |
probably. It would finally close #19436 after 5+ years of waiting ;( |
Definitely up for it. You know how to reach me. |
Would love to know the conclusion of these discussions and whether MailKit would be able to take advantage of this. |
Sorry for the delay @filipnava. Is this something you still want to push forward? It seems like RC4 was part of #66879 so if we need it we should take it from there. |
Yes. I will rebase it and update the RC4 reference. |
…rt for OEM encoding
… Linux due to a bug in gss-ntlmssp
Done. The remaining test failure is unrelated (#13757). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks @filipnavara
Add basic low-level NTLM exchange test. This is prerequisite for #29270, #62264 and test for the fixed scenario in #54101. It can also serve as basis for future tests for specific issues.