Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARM64 - Allow double constants to CSE more often #65176

Closed
wants to merge 17 commits into from
Closed

ARM64 - Allow double constants to CSE more often #65176

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
2a37283
Initial heuristic change for double constant adjustment
TIHan Feb 11, 2022
4670992
Fixed heuristic logic
TIHan Feb 12, 2022
ce52e2c
Fixed build
TIHan Feb 12, 2022
19ea7ab
Merge remote-tracking branch 'upstream/main' into double-const-adjust
TIHan Feb 18, 2022
96c46a8
Do not CSE constant operands for GT_SIMD
TIHan Jun 22, 2022
959cce9
Re-arrange logic
TIHan Jun 22, 2022
3d450df
Merging
TIHan Jun 23, 2022
415e964
Feedback
TIHan Jun 23, 2022
12653fd
Fixing build
TIHan Jun 23, 2022
5279dd9
Feedback
TIHan Jun 23, 2022
1c04881
Feedback
TIHan Jun 23, 2022
9d1857a
Feedback
TIHan Jun 23, 2022
0539c26
Feedback
TIHan Jun 23, 2022
780ef32
Feedback
TIHan Jun 23, 2022
146f6b9
Merge branch 'simd-dont-cse-const' into double-const-adjust
TIHan Jun 23, 2022
97a19f3
Added heuristic for 'fmov' to be cheaper than 'ldr'
TIHan Jun 23, 2022
0932f6a
Merge remote-tracking branch 'upstream/main' into double-const-adjust
TIHan Jun 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/coreclr/jit/gentree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3486,6 +3486,7 @@ unsigned Compiler::gtSetEvalOrder(GenTree* tree)
}
#elif defined(TARGET_ARM64)
if ((*((__int64*)&(tree->AsDblCon()->gtDconVal)) == 0) ||
TIHan marked this conversation as resolved.
Show resolved Hide resolved
(compCurBB->bbWeight > BB_UNITY_WEIGHT) ||
TIHan marked this conversation as resolved.
Show resolved Hide resolved
TIHan marked this conversation as resolved.
Show resolved Hide resolved
emitter::emitIns_valid_imm_for_fmov(tree->AsDblCon()->gtDconVal))
{
costEx = 1;
Expand Down