Update the ConvertToGeneratedDllImport code-fix to support stripping out PreserveSig and transforming the signature when PreserveSig was set to true #65169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the code-fix to add the existing return type as an
out
parameter at the end of the signature and update callers in the same document to use the new signature (and throw an exception with a corresponding failingHRESULT
).The design follows the "Extract Local Function" and "Make `DynamicInterfaceCastable method static" code fixers in dotnet/roslyn-analyzers
Open questions:
PreserveSig = false
by throwing before unmarshalling. Is it more desirable to replicate that behavior, or is throwing after unmarshalling okay?