Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/arcade dotnet/xharness dotnet/roslyn-analyzers #65068

Merged
merged 7 commits into from
Feb 11, 2022
Merged

[main] Update dependencies from dotnet/arcade dotnet/xharness dotnet/roslyn-analyzers #65068

merged 7 commits into from
Feb 11, 2022

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Feb 9, 2022 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20220210.7
  • Date Produced: February 11, 2022 12:51:41 AM UTC
  • Commit: 78eaf78761027d225030be2b28aaf4e8bf392929
  • Branch: refs/heads/main

From https://github.com/dotnet/roslyn-analyzers

  • Subscription: 5465c78f-1281-49a8-f9b0-08d9301a7704
  • Build: 20220209.1
  • Date Produced: February 9, 2022 4:20:12 PM UTC
  • Commit: 54b65374e301686f9475dc02045b370dda116db1
  • Branch: refs/heads/main

From https://github.com/dotnet/xharness

  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20220210.1
  • Date Produced: February 10, 2022 3:10:48 PM UTC
  • Commit: 1d34249
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
939a5a5 
…208.1

Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.GenAPI , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.GenFacades , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk
 From Version 2.5.1-beta.22103.1 -> To Version 2.5.1-beta.22108.1
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Feb 9, 2022
@premun
Copy link
Member

premun commented Feb 9, 2022

@MaximLipnin FYI

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
3d96b0e 
…uild 20220208.1

Microsoft.CodeAnalysis.NetAnalyzers
 From Version 7.0.0-preview1.22107.2 -> To Version 7.0.0-preview1.22108.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/arcade [main] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers Feb 9, 2022
@runfoapp runfoapp bot mentioned this pull request Feb 9, 2022
Closed
@MaximLipnin MaximLipnin mentioned this pull request Feb 10, 2022
Merged
@premun
Copy link
Member

premun commented Feb 10, 2022 •
edited
Loading

@MattGal seems like your thing worked but I am not sure it had the intended effect?

##[error]SENDHELIXJOB(0,0): error : Helix queue Windows.10.Amd64.Server19H1.ES.Open is slated for removal on 2022-02-28. Please discontinue usage.  Contact dnceng for questions / concerns

https://dev.azure.com/dnceng/public/_build/results?buildId=1602380&view=logs&j=f30da5b4-0d0d-502a-ba45-e575885ba318&t=456725c9-9234-575b-34cc-2844ffe3f24e&l=91

So basically we went from "builds start failing when we remove the queue" to "builds start failing 3 weeks when the EOL warning start (so without any notice)"?

@premun premun mentioned this pull request Feb 10, 2022
Merged
@premun
Copy link
Member

premun commented Feb 10, 2022

@MattGal there is no successor for 19H1 ES (https://github.com/dotnet/core-eng/issues/15341) so we are blocked here. I will revert your Arcade change to unblock this: dotnet/arcade#8452

I think we should maybe add one more feature - when setting EOL for a queue, we could recommend successor which would be nice for end users because they will get an actionable warning in their builds. And for us, we can have an alert 6 weeks prior for queues that don't have a successor set. We would then prevent situation like this where we don't have an alternative for an EOL'd queues

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
5d93366 
…209.1

Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.GenAPI , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.GenFacades , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk
 From Version 2.5.1-beta.22103.1 -> To Version 2.5.1-beta.22109.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers [main] Update dependencies from dotnet/roslyn-analyzers dotnet/arcade Feb 10, 2022
@dotnet-maestro
Update dependencies from https://github.com/dotnet/xharness build 202…
e73da92 
…20209.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.22108.1 -> To Version 1.0.0-prerelease.22109.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/roslyn-analyzers dotnet/arcade [main] Update dependencies from dotnet/roslyn-analyzers dotnet/arcade dotnet/xharness Feb 10, 2022
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
ab2dd58 
…uild 20220209.1

Microsoft.CodeAnalysis.NetAnalyzers
 From Version 7.0.0-preview1.22107.2 -> To Version 7.0.0-preview1.22109.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/roslyn-analyzers dotnet/arcade dotnet/xharness [main] Update dependencies from dotnet/arcade dotnet/xharness dotnet/roslyn-analyzers Feb 10, 2022
@MattGal
Copy link
Member

MattGal commented Feb 10, 2022

@MattGal there is no successor for 19H1 ES (dotnet/core-eng#15341) so we are blocked here. I will revert your Arcade change to unblock this: dotnet/arcade#8452

I think we should maybe add one more feature - when setting EOL for a queue, we could recommend successor which would be nice for end users because they will get an actionable warning in their builds. And for us, we can have an alert 6 weeks prior for queues that don't have a successor set. We would then prevent situation like this where we don't have an alternative for an EOL'd queues

I mean, that's an interesting feature creep that requires a lot of human labor. An alternative here would be to simply run the SendToHelix task in an msbuild environment where warnings are not set as errors, which is why this warning was promoted to being an error. We've already tried just logging a message that used logging commands to be a warning in the build, this was ignored.

@premun
Copy link
Member

premun commented Feb 11, 2022

I mean, that's an interesting feature creep that requires a lot of human labor. An alternative here would be to simply run the SendToHelix task in an msbuild environment where warnings are not set as errors, which is why this warning was promoted to being an error. We've already tried just logging a message that used logging commands to be a warning in the build, this was ignored.

But this doesn't solve the problem that we start showing EOL to clients with no alternative to migrate to. I don't think that's a good experience for the client teams? It's not a lot of work too - we are already doing extra work when EOL warning starts for a queue, I think adding one more record to the YAML is not too crazy a requirement?

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
b32b4a6 
…210.7

Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.GenAPI , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.GenFacades , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk
 From Version 2.5.1-beta.22103.1 -> To Version 2.5.1-beta.22110.7
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/arcade dotnet/xharness dotnet/roslyn-analyzers [main] Update dependencies from dotnet/xharness dotnet/roslyn-analyzers dotnet/arcade Feb 11, 2022
@dotnet-maestro
Update dependencies from https://github.com/dotnet/xharness build 202…
f13feff 
…20210.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.22108.1 -> To Version 1.0.0-prerelease.22110.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/xharness dotnet/roslyn-analyzers dotnet/arcade [main] Update dependencies from dotnet/roslyn-analyzers dotnet/arcade dotnet/xharness Feb 11, 2022
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/roslyn-analyzers dotnet/arcade dotnet/xharness [main] Update dependencies from dotnet/arcade dotnet/xharness dotnet/roslyn-analyzers Feb 11, 2022
@dotnet-maestro dotnet-maestro bot merged commit 6d8cc6f into main Feb 11, 2022
@dotnet-maestro dotnet-maestro bot deleted the darc-main-2a531aee-e1fb-4e22-9008-edadf3391053 branch February 11, 2022 22:19
@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@premun premun premun approved these changes

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@premun @MattGal