Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid threading of nodes in rationalization #64012

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Fix invalid threading of nodes in rationalization #64012

merged 1 commit into from
Jan 20, 2022

Commits on Jan 19, 2022

  1. Fix invalid threading of nodes in rationalization 

    The code in question assumes that the ASG will be
reversed and thus threads "simdTree" before "location"
in the linear order. That dependency, while valid,
because "gtSetEvalOrder" will always reverse ASGs
with locals on the LHS, is unnecessary and incorrect
from the IR validity point of view.

Fix this by using "InsertAfter" instead of manual
node threading.
    @SingleAccretion
    SingleAccretion committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    b5bc70e View commit details
    Browse the repository at this point in the history