Revert "Remove extra call to PropertyInfo.GetValue(object) (#60415)" #63586
Conversation
)" This reverts commit 97ef512. # Conflicts: # src/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration |
|
Is it also possible to add a unit test for the regressed scenario? That way we ensure it doesn't regress again in the future. |
| @@ -248,17 +248,19 @@ private static void BindProperty(PropertyInfo property, object instance, IConfig | |||
| return; | |||
| } | |||
|
|
|||
| object? propertyValue = property.GetValue(instance); | |||
There was a problem hiding this comment.
what will happen if we just call GetPropertyValue(property, instance, config, options); here instead?
There was a problem hiding this comment.
I think more work needs to be done to investigate the correct fix that addresses #52905.
At the moment I'm just doing a clean git revert. I made a note in the issue that caused this regression that we need to add a test for the regressed scenario. |
ghost
locked as resolved and limited conversation to collaborators
Fixes #63479
This reverts commit 97ef512 which was trying to fix #52905