Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Event Log Message Format on Unmanaged FailFast #63517

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

Silvenga
Copy link
Contributor

@Silvenga Silvenga commented Jan 7, 2022

We observed the following event log messages:

CoreCLR Version: 6.0.21.52210
.NET Version: 6.0.0
Description: The process was terminated due to an internal error in the .NET Runtime.at IP 01090791 (00F40000) with exit code 80131506.

We are still investigating the crashes, but in the meantime we noticed the message was a little off, this PR just fixes the fallback messages to match the newer versions in resources (assumed) to make the message read a bit nicer. 😸

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jan 7, 2022
@danmoseley
Copy link
Member

Being picky, it seems to me that IP 01090791 (00F40000) with exit code 80131506. ought to be IP 0x01090791 (0x00F40000) with exit code 0x80131506. so it's clear they're all hex.

This formats with %p, %p and %x respectively. A gotcha is %p prefixes 0x when I try with clang, and not when I try with cl. %x is never prefixed.

@danmoseley
Copy link
Member

Test failure fix is in #63529

@Silvenga
Copy link
Contributor Author

@danmoseley - I updated the formats with 0x%x to match other places that hex is being formatted, that seems to be the most portable approach.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Silvenga
Copy link
Contributor Author

Unrelated, the crashes were caused by us 😭 - slight incompatibility with changes in the span implementation in .NET 6 😆.

@jkotas jkotas merged commit 9529c35 into dotnet:main Jan 10, 2022
@Silvenga Silvenga deleted the nit-picking-error-messages branch January 11, 2022 14:13
@ghost ghost locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants