[LoongArch64] coreclr/debug and part of inc directory. #62886

shushanhf · 2021-12-16T04:50:55Z

[LoongArch64] coreclr-inc,gc, ToolBox directory.

update from runtime.

dotnet-issue-labeler · 2021-12-16T04:51:03Z

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

src/coreclr/inc/corinfo.h

Co-authored-by: Loongson's .NET-teams

…nal.

shushanhf

What ohter files are dependent on the windows for this PR ?

src/coreclr/binder/assemblybindercommon.cpp

src/coreclr/binder/inc/bindertypes.hpp

…ONGARCH64 on windows.

…URE_LOONGARCH64 on windows.

jkotas · 2021-12-21T14:10:53Z

src/coreclr/ToolBox/superpmi/superpmi/jitinstance.cpp

@@ -346,6 +346,12 @@ JitInstance::Result JitInstance::CompileMethod(MethodContext* MethodToCompile, i
                    matchesTargetArch = (targetArch == SPMI_TARGET_ARCHITECTURE_ARM64);
                    break;

+#ifdef TARGET_UNIX


Instead of adding this ifdef, it would be better to define IMAGE_FILE_MACHINE_LOONGARCH64 on Windows.

I'm sorry, where is the defination on windows?

I meant that you can define IMAGE_FILE_MACHINE_LOONGARCH64 in a place that shared between Windows and non-Windows so that these ifdefs are not necessary.

src/coreclr/inc/clrnt.h may be a good place to add IMAGE_FILE_MACHINE_LOONGARCH64 definition that is shared between Windows and non-Windows.

Try adding this:

#ifndef IMAGE_FILE_MACHINE_LOONGARCH64 #define IMAGE_FILE_MACHINE_LOONGARCH64 0x6264 #endif

at https://github.com/dotnet/runtime/blob/main/src/coreclr/inc/clrnt.h#L1032

#ifndef IMAGE_FILE_MACHINE_LOONGARCH64
#define IMAGE_FILE_MACHINE_LOONGARCH64 0x6264
#endif

Thanks～

#62886 (comment)

But the compiling error is still exist.

I meant that you can define IMAGE_FILE_MACHINE_LOONGARCH64 in a place that shared between Windows and non-Windows so that these ifdefs are not necessary.

src/coreclr/inc/clrnt.h may be a good place to add IMAGE_FILE_MACHINE_LOONGARCH64 definition that is shared between Windows and non-Windows.

Try adding this:

#ifndef IMAGE_FILE_MACHINE_LOONGARCH64 #define IMAGE_FILE_MACHINE_LOONGARCH64 0x6264 #endif

at https://github.com/dotnet/runtime/blob/main/src/coreclr/inc/clrnt.h#L1032

It seems that it doesn't work.

jkotas · 2021-12-21T14:35:35Z

src/coreclr/inc/cor.h

@@ -2233,7 +2233,11 @@ inline ULONG CorSigCompressPointer( // return number of bytes of that compressed
    void * pvPointer,               // [IN] given uncompressed data
    void * pData)                   // [OUT] buffer where iLen will be compressed and stored.
 {
+#ifdef TARGET_LOONGARCH64


Changes like this should not be under. This change should be done for all architectures.

Yes, you are right.
Especially for CPU processors supporting unaligned memory accessing.
I will update it later with breaking up this PR into serval PRs.

jkotas · 2021-12-21T14:36:31Z

src/coreclr/inc/corcompile.h

+        // jirl     $r0,$r21,0       ; Jump to the target
+        DWORD m_rgCode[3];
+
+        DWORD m_padding; //aligning stack to 16 bytes


This structure has nothing to do with stack. Is the comment wrong?

This structure has nothing to do with stack. Is the comment wrong?

Yes.
I should add a macro at here, prestup.cpp-Line:2363 #elif defined(TARGET_ARM) || defined(TARGET_ARM64) || defined(TARGET_LOONGARCH64)

But I also have a question.
Previous within the .NET6-runtime, the initialing code is in the file src/coreclr/zap/zapimport.cpp:489.
But now the zapimport.cpp had been deleted.
Not only the LoongArch64, the others architecturs also do nothing for initialing the m_rgCode.

Yes, CORCOMPILE_EXTERNAL_METHOD_THUNK is no longer used. It would be best to delete it instead of trying to fix it up for LoongArch64.

OK, I will delete it for LoongArch64.

Yes, CORCOMPILE_EXTERNAL_METHOD_THUNK is no longer used. It would be best to delete it instead of trying to fix it up for LoongArch64.

Maybe I have to keep a define for LoongArch64 as the same with other architecture rather than compiling error for undefined value.

I am deleting it in #65869

I am deleting it in #65869

OK, I will update it after you merge that.
Thanks

shushanhf · 2022-02-24T03:17:11Z

Liking the compiling error #62843 (comment)

D:\a\_work\1\s\src\coreclr\debug\shim\debugshim.cpp(678): error C2065: 'IMAGE_FILE_MACHINE_LOONGARCH64': undeclared identifier

This PR's error on windows is also for undefined IMAGE_FILE_MACHINE_LOONGARCH64 which is defined within the file src/coreclr/pal/inc/rt/ntimage.h .

jkotas · 2022-02-24T06:12:12Z

I think you may need to add #define IMAGE_FILE_MACHINE_LOONGARCH64 ... to src/coreclr/inc/clrnt.h to fix the build on Windows.

shushanhf · 2022-02-24T06:19:08Z

I think you may need to add #define IMAGE_FILE_MACHINE_LOONGARCH64 ... to src/coreclr/inc/clrnt.h to fix the build on Windows.

OK, Thanks.
I will submit it later.

shushanhf · 2022-02-24T12:41:54Z

I think you may need to add #define IMAGE_FILE_MACHINE_LOONGARCH64 ... to src/coreclr/inc/clrnt.h to fix the build on Windows.

OK, Thanks. I will submit it later.

I had added #define IMAGE_FILE_MACHINE_LOONGARCH64 ... to src/coreclr/inc/clrnt.h,
but there is still error on windows.

I guess windows and linux included different files for different macro-define, for example, the file src/coreclr/pal/inc/rt/palrt.h with defined RC_INVOKED will not include ntimage.h.
While windows has some default files including the defination IMAGE_FILE_MACHINE_ARM64 which not supporting IMAGE_FILE_MACHINE_LOONGARCH64 .

I will submit a temp patch for testing.

jkotas · 2022-02-24T14:36:52Z

I had added #define IMAGE_FILE_MACHINE_LOONGARCH64 ... to src/coreclr/inc/clrnt.h,

Adding this to palclr.h instead is fine - assuming that it is going to fix all build breaks on Windows.

shushanhf · 2022-02-25T02:53:56Z

Hi, @jkotas

Now the CI's errors are about the libunwind which is only on cross-arm64-windows, liking

D:\a\_work\1\s\src\coreclr\pal\src\libunwind\include\libunwind-aarch64.h(198): error C2061: syntax error: identifier 'alignas'
D:\a\_work\1\s\src\coreclr\pal\src\libunwind\include\libunwind-aarch64.h(199): error C2059: syntax error: '}'
D:\a\_work\1\s\src\coreclr\pal\src\libunwind\include\libunwind-aarch64.h(215): error C2079: 'uc_mcontext' uses undefined struct 'unw_sigcontext'
[6/441] Building C object pal\src\libunwind\src\CMakeFiles\libunwind_xdac.dir\aarch64\Gget_save_loc.c.ob

How should I resolv this error ?

jkotas · 2022-02-25T03:20:50Z

Now the CI's errors are about the libunwind which is only on cross-arm64-windows

This is CI infrastructure issue affecting all PRs: #65818. Do not worry about it.

@jkotas

* Part6-2: -add the coreclr-vm directory for LoongArch64. (#59561) Co-authored-by: Loongson's .NET-teams * [LoongArch64] revert the syncblk.cpp. * [LoongArch64] delete some unused codes. * [LoongArch64] add vm/CMakeLists.txt from #62889. * [LoongArch64] add related files from #62886 and #62893. * [LoongArch64] moved vm/jitinterface.cpp from #62893. moved inc/corinfo.h from #6288. * [LoongArch64] run the file `src/coreclr/tools/Common/JitInterface/ThunkGenerator/gen.sh` and merge the patch from #62893. * [LoongArch64] revert vm/ceeload.h. amend the `ToolBox/superpmi/superpmi-shared/agnostic.h` * [LoongArch64] add empty interfaces within `CorInfoImpl.cs`. * [LoongArch64] Fix the compiling error on Windows. * [LoongArch64] Fix the compiling error for memory unaligned m_currentByteStackIndex. * [LoongArch64] Delete the !TARGET_LOONGARCH64 for m_currentByteStackIndex. * [LoongArch64] move ToolBox from #62886. * [LoongArch64] amend the args when needs unsigned extending within CallTargetWorker. * [LoongArch64] add bool type for args' unsigned extention. * [LoongArch64] adding char type for args' unsigned extention. Also rename `TARGET_LOONGARCH64` to `UNIX_LOONGARCH64_ABI` within ABI. * [LoongArch64] amend renaming `TARGET_LOONGARCH64` to `UNIX_LOONGARCH64_ABI` within ABI. * [LoongArch64] remove the JIT/EE interface to #62893. * [LoongArch64] revert the rename `TARGET_LOONGARCH64` to `UNIX_LOONGARCH64_ABI`. Also add unsigned extend for CHAR type. * [LoongArch64] refactor the `ArgDestination and ArgLocDesc`. * [LoongArch64] rename the `m_flag` and `getFieldTypeByHnd`. * [LoongArch64] add `NATIVE_SYMBOL_READER_DLL` for compiling error. * [LoongArch64] update the version of the `LICENSE description`. * [LoongArch64] keep same with the comment in `jit/targetloongarch64.h` * [LoongArch64] amend the code for reviewing. * [LoongArch64] refactor LoongArch64-ABI within `vm`, and also amend some code for review. * [LoongArch64] delete unused codes. * [LoongArch64] merge main for #65869. * [LoongArch64] amend the format for reviewing. * [LoongArch64] delete some unused code for reviewing. * [LoongArch64] amend code for CR feedback @jkotas @janvorli * [LoongArch64] add class type for LoongArch64-ABI. * [LoongArch64] Amend the LoongArch64's ABI after merged `MethodTable::GetLoongArch64PassStructInRegisterFlags()` and `CEEInfo::getLoongArch64PassStructInRegisterFlags()` * [LoongArch64] Fix the assert error when running hello-world within debug-mode after refacting. Co-authored-by: qiaopengcheng <qiaopengcheng-hf@loongson.cn>

shushanhf · 2022-04-22T04:14:49Z

@mikem8361 @hoyosjs
Could you please review this PR ?

shushanhf · 2022-04-22T06:24:06Z

Hi, @tommcdon
Could you please review this PR ?

mikem8361

It looks like you have a lot to implement. Am I looking at this too soon?

src/coreclr/debug/createdump/threadinfounix.cpp

tonyqus · 2022-04-22T21:25:48Z

@shushanhf I'm a bit curious. Are you working on LoognArch .NET runtime project alone? I've been tracking the PR for a few months. Looks you are the only person committing code. I do suggest you involve a team instead of yourself because this is a huge task.

BruceForstall · 2022-04-25T16:30:57Z

It looks like you have a lot to implement. Am I looking at this too soon?

@mikem8361 Does you think more needs to be implemented before this change can be merged? I.e., is this wrong as-is, or just incomplete from a "full implementation" perspective? I presume that there will be additional work to make LoongArch64 a complete implementation.

mikem8361

It looks like everything is implemented now. Thanks.

shushanhf added 8 commits April 27, 2021 16:32

Merge pull request #1 from dotnet/main

47d106f

update from runtime.

Merge branch 'dotnet:main' into master

411b59e

Merge branch 'dotnet:main' into master

7eed4eb

Merge branch 'dotnet:main' into master

0d7c9e4

Merge branch 'dotnet:main' into master

2c534c5

Merge branch 'dotnet:main' into master

6e14d76

Merge branch 'dotnet:main' into master

359875d

Merge branch 'dotnet:main' into main

192b095

ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 16, 2021

jkotas reviewed Dec 16, 2021

View reviewed changes

src/coreclr/inc/corinfo.h Outdated Show resolved Hide resolved

jkotas reviewed Dec 16, 2021

View reviewed changes

src/coreclr/inc/corinfo.h Outdated Show resolved Hide resolved

[LoongArch64] add coreclr-inc,gc, ToolBox directory. (#59561)

46ebed3

Co-authored-by: Loongson's .NET-teams

kant2002 mentioned this pull request Dec 17, 2021

[LoongArch64] add all the coreclr-build-config files #62889

Merged

qiaopengcheng added 3 commits December 18, 2021 08:42

[LoongArch64] move inc/switches.h to #62889.

e6bada0

[LoongArch64] move some configure files from #62889.

50bc181

[LoongArch64] revert the modify when moved from #62889.

49104b3

kant2002 mentioned this pull request Dec 18, 2021

[LoongArch64] coreclr-vm directory #62885

Merged

qiaopengcheng and others added 4 commits December 20, 2021 09:33

[LoongArch64] moved the inc/stdmacros.h to #62885.

d3e0468

[LoongArch64] moved inc/corinfo.h to #62885.

e1d82f9

[LoongArch64] modify the related files for compiling error.

9c211b9

[LoongArch64] revert the src/coreclr/gcinfo/CMakeLists.txt to origi…

7fc185f

…nal.

shushanhf commented Dec 21, 2021

View reviewed changes

src/coreclr/binder/assemblybindercommon.cpp Outdated Show resolved Hide resolved

src/coreclr/binder/inc/bindertypes.hpp Outdated Show resolved Hide resolved

shushanhf and others added 4 commits December 21, 2021 11:26

[LoongArch64] delete unused files on windows.

b859a4f

[LoongArch64] add define IMAGE_FILE_MACHINE_LOONGARCH64.

3e89670

[LoongArch64] workround the compiling error for IMAGE_FILE_MACHINE_LO…

f0618ea

…ONGARCH64 on windows.

[LoongArch64] workround the compiling error for SPMI_TARGET_ARCHITECT…

054033f

…URE_LOONGARCH64 on windows.

jkotas reviewed Dec 21, 2021

View reviewed changes

Merge branch 'main' into main_loongarch64_3

650ab6a

[LoongArch64] amend the code about debug.

2136701

[LoongArch64] temp submit for fixing the windows compiling error.

e058faa

shushanhf added 2 commits February 25, 2022 14:54

Merge branch 'main' into main_loongarch64_3

27e1419

Merge branch 'main' into main_loongarch64_3

7c0fe05

shushanhf requested a review from jkotas April 12, 2022 04:41

Merge branch 'main' into main_loongarch64_3

c2694ff

mikem8361 requested changes Apr 22, 2022

View reviewed changes

src/coreclr/debug/createdump/threadinfounix.cpp Outdated Show resolved Hide resolved

ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Apr 22, 2022

ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Apr 24, 2022

shushanhf requested a review from mikem8361 April 24, 2022 14:07

[LoongArch64] amend some LA's implements for CR.

c8fb52a

mikem8361 approved these changes Apr 25, 2022

View reviewed changes

BruceForstall merged commit fc2f06e into dotnet:main Apr 25, 2022

shushanhf deleted the main_loongarch64_3 branch May 11, 2022 01:12

ghost locked as resolved and limited conversation to collaborators Jun 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[LoongArch64] coreclr/debug and part of inc directory. #62886

[LoongArch64] coreclr/debug and part of inc directory. #62886

shushanhf commented Dec 16, 2021

dotnet-issue-labeler bot commented Dec 16, 2021

shushanhf left a comment

jkotas Dec 21, 2021

shushanhf Dec 22, 2021

jkotas Dec 22, 2021 •

edited

Loading

shushanhf Dec 22, 2021

shushanhf Dec 22, 2021

shushanhf Dec 22, 2021 •

edited

Loading

jkotas Dec 21, 2021

shushanhf Dec 22, 2021

jkotas Dec 21, 2021

shushanhf Dec 22, 2021 •

edited

Loading

jkotas Dec 22, 2021

shushanhf Dec 22, 2021

shushanhf Dec 22, 2021

jkotas Feb 24, 2022

shushanhf Feb 25, 2022

shushanhf commented Feb 24, 2022

jkotas commented Feb 24, 2022

shushanhf commented Feb 24, 2022

shushanhf commented Feb 24, 2022

jkotas commented Feb 24, 2022

shushanhf commented Feb 25, 2022 •

edited

Loading

jkotas commented Feb 25, 2022

shushanhf commented Apr 22, 2022

shushanhf commented Apr 22, 2022

mikem8361 left a comment

tonyqus commented Apr 22, 2022

BruceForstall commented Apr 25, 2022

mikem8361 left a comment

[LoongArch64] coreclr/debug and part of inc directory. #62886

[LoongArch64] coreclr/debug and part of inc directory. #62886

Conversation

shushanhf commented Dec 16, 2021

dotnet-issue-labeler bot commented Dec 16, 2021

shushanhf left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jkotas Dec 22, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shushanhf Dec 22, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shushanhf Dec 22, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shushanhf commented Feb 24, 2022

jkotas commented Feb 24, 2022

shushanhf commented Feb 24, 2022

shushanhf commented Feb 24, 2022

jkotas commented Feb 24, 2022

shushanhf commented Feb 25, 2022 • edited Loading

jkotas commented Feb 25, 2022

shushanhf commented Apr 22, 2022

shushanhf commented Apr 22, 2022

mikem8361 left a comment

Choose a reason for hiding this comment

tonyqus commented Apr 22, 2022

BruceForstall commented Apr 25, 2022

mikem8361 left a comment

Choose a reason for hiding this comment

jkotas Dec 22, 2021 •

edited

Loading

shushanhf Dec 22, 2021 •

edited

Loading

shushanhf Dec 22, 2021 •

edited

Loading

shushanhf commented Feb 25, 2022 •

edited

Loading