-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LoongArch64] coreclr-vm directory #62885
Merged
Merged
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
47d106f
Merge pull request #1 from dotnet/main
shushanhf 411b59e
Merge branch 'dotnet:main' into master
shushanhf 7eed4eb
Merge branch 'dotnet:main' into master
shushanhf 0d7c9e4
Merge branch 'dotnet:main' into master
shushanhf 2c534c5
Merge branch 'dotnet:main' into master
shushanhf 6e14d76
Merge branch 'dotnet:main' into master
shushanhf 359875d
Merge branch 'dotnet:main' into master
shushanhf 192b095
Merge branch 'dotnet:main' into main
shushanhf 8a9d654
Part6-2: -add the coreclr-vm directory for LoongArch64. (#59561)
shushanhf 4606899
[LoongArch64] revert the syncblk.cpp.
e62a6cd
[LoongArch64] delete some unused codes.
cdb7606
[LoongArch64] add vm/CMakeLists.txt from #62889.
ad3b666
[LoongArch64] add related files from #62886 and #62893.
7d03307
[LoongArch64] moved vm/jitinterface.cpp from #62893.
f6ec562
[LoongArch64] run the file `src/coreclr/tools/Common/JitInterface/Thu…
shushanhf 277de6f
[LoongArch64] revert vm/ceeload.h.
shushanhf d6dabd7
[LoongArch64] add empty interfaces within `CorInfoImpl.cs`.
63073dc
[LoongArch64] Fix the compiling error on Windows.
6aa5e1a
[LoongArch64] Fix the compiling error for memory unaligned m_currentB…
3e3c3b3
[LoongArch64] Delete the !TARGET_LOONGARCH64 for m_currentByteStackIn…
55eeb95
[LoongArch64] move ToolBox from #62886.
21040b8
[LoongArch64] amend the args when needs unsigned extending within Cal…
19e4357
[LoongArch64] add bool type for args' unsigned extention.
743c518
[LoongArch64] adding char type for args' unsigned extention.
cb91556
[LoongArch64] amend renaming `TARGET_LOONGARCH64` to `UNIX_LOONGARCH6…
1f790f4
[LoongArch64] remove the JIT/EE interface to #62893.
42fd640
[LoongArch64] revert the rename `TARGET_LOONGARCH64` to `UNIX_LOONGAR…
shushanhf 7757e09
[LoongArch64] refactor the `ArgDestination and ArgLocDesc`.
ba9fba0
Merge branch 'main' into main_loongarch64_2
shushanhf 86d4546
[LoongArch64] rename the `m_flag` and `getFieldTypeByHnd`.
shushanhf 56b0a79
[LoongArch64] add `NATIVE_SYMBOL_READER_DLL` for compiling error.
shushanhf 5798329
[LoongArch64] update the version of the `LICENSE description`.
c747f93
Merge branch 'main' into main_loongarch64_2
48b4734
[LoongArch64] keep same with the comment in `jit/targetloongarch64.h`
a96f159
Merge branch 'main' into main_loongarch64_2
aa96fba
[LoongArch64] amend the code for reviewing.
shushanhf cc96589
[LoongArch64] refactor LoongArch64-ABI within `vm`,
d3e6ca7
Merge branch 'main' into main_loongarch64_2
shushanhf 4b32677
[LoongArch64] delete unused codes.
shushanhf 9bb6899
Merge branch 'main' into main_loongarch64_2
c01407f
[LoongArch64] merge main for #65869.
14669dc
Merge branch 'main' into main_loongarch64_2
shushanhf 7b8b887
[LoongArch64] amend the format for reviewing.
shushanhf ceee54a
[LoongArch64] delete some unused code for reviewing.
shushanhf 00fdee0
[LoongArch64] amend code for CR feedback @jkotas @janvorli
shushanhf a623961
[LoongArch64] add class type for LoongArch64-ABI.
6566991
[LoongArch64] Amend the LoongArch64's ABI
shushanhf 9f39e13
Merge branch 'main' into main_loongarch64_2
shushanhf d6c7080
[LoongArch64] Fix the assert error
shushanhf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to handle simple wrappers of primitive types (structs with just one field)?
They should be sign or zero extended based on the underlying type according to this comment:
loongson/LoongArch-Documentation#32 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is no need.
Becasue the field of struct will be pared again while using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are saying that the comment loongson/LoongArch-Documentation#32 (comment) is not valid.
The calling convention details like this have to be very well understood and described. Could you please work on clarifying the ABI for simple wrappers of primitive types with your colleagues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sorry for descriped unclear.
At the comment, using a register passing the
struct {int a;}
is signed extend.Becasue it will use a instruction liking
lw $register, $base, offset
which will sign extent the upper bits within the register.This PR is args passing by stack, the struct {...} which sizeof(struct) is less than or equal 4-byte, the upper bits are undefined.
But we signed extend the upper bits except the unsigned types, it will be ok and simply the cases.