Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] [wasm] Allow enums in unmanaged callbacks. #61393

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 10, 2021

Backport of #61377 to release/6.0

/cc @lewing @vargaz

Customer Impact

Fixes

Fixes a restriction where enums were incorrectly excluded in dllimports

Testing

Manual (automated tests are in progress)

Risk

Low

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@lewing lewing added this to the 6.0.x milestone Nov 10, 2021
@lewing lewing added Servicing-consider Issue for next servicing release review arch-wasm WebAssembly architecture labels Nov 10, 2021
@ghost
Copy link

ghost commented Nov 10, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #61377 to release/6.0

/cc @lewing @vargaz

Customer Impact

Fixes

Fixes a restriction where enums were incorrectly excluded in dllimports

Testing

Manual (automated tests are in progress)

Risk

Low

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-consider, arch-wasm

Milestone: 6.0.x

@danmoseley
Copy link
Member

What area label should this have? area-build-mono?

@lewing lewing added area-Build-mono Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 11, 2021
@Anipik Anipik merged commit 8881fcf into release/6.0 Nov 12, 2021
@jkotas jkotas deleted the backport/pr-61377-to-release/6.0 branch November 13, 2021 22:58
@ghost ghost locked as resolved and limited conversation to collaborators Dec 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants