Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide 'align' instruction behind jmp #60787

Merged
merged 24 commits into from
Nov 18, 2021
Merged

Hide 'align' instruction behind jmp #60787

merged 24 commits into from
Nov 18, 2021

Commits on Nov 16, 2021

  1. Hide align behind a jmp 

    fix the alignBytesRemoved

Some fixes and working model

Some fixes and redesign

Some more fixes

more fixes

fix

Add the check  for fgFirstBB

misc changes

code cleanup + JitHideAlignBehindJmp switch

validatePadding only if align are before the loop IG

More cleanup, remove commented code

jit format
    @kunalspathak
    kunalspathak committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    3244072 View commit details
    Browse the repository at this point in the history

  2. Fix a problem where curIG==0 and loop might be emitted in curIG, adju… 

    …st the targetIG to prevIG

Add IGF_REMOVED_ALIGN flag for special scenarios
    @kunalspathak
    kunalspathak committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    e7c0710 View commit details
    Browse the repository at this point in the history

  3. Add stress mode to emit int3 for xarch

    @kunalspathak
    kunalspathak committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    bd922aa View commit details
    Browse the repository at this point in the history

  4. Add stress mode to emit bkpt for arm64

    @kunalspathak
    kunalspathak committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    4d0f912 View commit details
    Browse the repository at this point in the history

  5. Add a loop align instruction placement phase

    @kunalspathak
    kunalspathak committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    8d64351 View commit details
    Browse the repository at this point in the history

  6. review comments

    @kunalspathak
    kunalspathak committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    9b9b616 View commit details
    Browse the repository at this point in the history

  7. Change from unsigned short to unsigned

    @kunalspathak
    kunalspathak committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    6302975 View commit details
    Browse the repository at this point in the history

  8. review comments around cleanup

    @kunalspathak
    kunalspathak committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    d20da6d View commit details
    Browse the repository at this point in the history

  9. emitForceNewIG

    @kunalspathak
    kunalspathak committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    c6a2d70 View commit details
    Browse the repository at this point in the history

  10. Remove emitPrevIG

    @kunalspathak
    kunalspathak committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    e9c5eec View commit details
    Browse the repository at this point in the history

  11. Revert change to forceNewIG for align instruction

    @kunalspathak
    kunalspathak committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    c1c5db3 View commit details
    Browse the repository at this point in the history

  12. Use loopAlignCandidates

    @kunalspathak
    kunalspathak committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    b8a9742 View commit details
    Browse the repository at this point in the history

  13. Use loopHeadIG reference

    @kunalspathak
    kunalspathak committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    db98ec2 View commit details
    Browse the repository at this point in the history

  14. jit format

    @kunalspathak
    kunalspathak committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    5ab9edc View commit details
    Browse the repository at this point in the history

  15. Remove unneeded method

    @kunalspathak
    kunalspathak committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    c8a9e01 View commit details
    Browse the repository at this point in the history

  16. Misc changes

    @kunalspathak
    kunalspathak committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    5bb1563 View commit details
    Browse the repository at this point in the history

  17. Review feedback

    @kunalspathak
    kunalspathak committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    2c6e81d View commit details
    Browse the repository at this point in the history

  18. Do not include align behind Jmp in PerfScore calculation

    @kunalspathak
    kunalspathak committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    bbc2ac5 View commit details
    Browse the repository at this point in the history

  19. jit format and fix a bug

    @kunalspathak
    kunalspathak committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    64bba41 View commit details
    Browse the repository at this point in the history

  20. fix the loopCandidates == 0 scenario

    @kunalspathak
    kunalspathak committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    1e24fcb View commit details
    Browse the repository at this point in the history

  21. Add unmarkLoopAlign(), add check for fgFirstBB

    @kunalspathak
    kunalspathak committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    b301fa5 View commit details
    Browse the repository at this point in the history

  22. merge conflict fix

    @kunalspathak
    kunalspathak committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    57759d0 View commit details
    Browse the repository at this point in the history

  23. Add missing }

    @kunalspathak
    kunalspathak committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    ef0e859 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Grammar nit 

    Co-authored-by: Bruce Forstall <brucefo@microsoft.com>
    @kunalspathak @BruceForstall
    kunalspathak and BruceForstall committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    976b253 View commit details
    Browse the repository at this point in the history