[metadata] Cleanup some uses of m_class_get_this_arg #60557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s byrefs In cases where it's evident the intent is to create a byref type around a known type, use mono_class_get_byref_type instead of the this_arg getter. No functional change, but sets the stage.
type_check_context_used for this_arg will be the same as for byval_arg
lambdageek
requested review from
imhameed,
SamMonoRT,
thaystg and
vargaz
as code owners
lambdageek
commented
Oct 18, 2021
| @@ -153,7 +153,6 @@ mono_class_check_context_used (MonoClass *klass) | |||
| { | |||
| int context_used = 0; | |||
|
|
|||
| context_used |= type_check_context_used (m_class_get_this_arg (klass), FALSE); | |||
There was a problem hiding this comment.
@vargaz I think this is ok to remove. type_check_context_used ignores MonoType:byref so it always returns the same result for this_arg and byref_arg, as far as I can tell.
vargaz
approved these changes
Oct 18, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two cleanups:
m_class_get_this_argis just used to create a byrefMonoType- not to get aMonoTypethat will be used as athisargument, usemono_class_get_byref_typeto indicate intent. No functional change.type_check_context_used (m_class_get_this_arg (klass), FALSE);in generic sharing - sincem_class_get_this_argandm_class_get_byval_argjust differ by thebyrefbit andtype_check_context_usedwill return the same result both times.