Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply custom Message and Url to all [RequiresPreviewFeatures] attributes #60379

Merged
merged 2 commits into from
Oct 15, 2021

Conversation

buyaa-n
Copy link
Member

@buyaa-n buyaa-n commented Oct 14, 2021

With #56498 we have added Message and Url properties to the RequiresPreviewFeatures, now with dotnet/roslyn-analyzers#5502 the analyzer would include those Message and Url in the error message. So now its time to apply custom message and url to all generic math APIs having [RequiresPreviewFeatures] attributes

Literally updated all APIs [RequiresPreviewFeatures] attributes, seems all related to generic math, but not that sure

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@danmoseley
Copy link
Member

@lewing do you know why this might have happened? It got killed. This was after ~25 mins so I don't think it was timed out.

2021-10-14T01:18:05.5542130Z    "/usr/local/emscripten/emsdk/upstream/bin/wasm-opt" --strip-dwarf --post-emscripten --no-exit-runtime -Oz --low-memory-unused --zero-filled-memory --strip-debug --strip-producers /__w/1/s/artifacts/obj/mono/Wasm.Browser.Bench.Sample/wasm/Release/browser-wasm/wasm/for-publish/dotnet.wasm -o /__w/1/s/artifacts/obj/mono/Wasm.Browser.Bench.Sample/wasm/Release/browser-wasm/wasm/for-publish/dotnet.wasm -g --mvp-features --enable-mutable-globals
2021-10-14T01:19:18.9456404Z ##[error]Exit code 137 returned from process: file name '/usr/bin/docker', arguments 'exec -i -u 1000  -w /home/cloudtest_azpcontainer eb410a6ee1fc36379240dd190ed60955deb9d1d81560a5c8b6d737d5948368f6 /__a/externals/node/bin/node /__w/_temp/containerHandlerInvoker.js'.
2021-10-14T01:19:18.9496336Z ##[section]Finishing: Build product

@jeffhandley jeffhandley added Servicing-consider Issue for next servicing release review and removed new-api-needs-documentation labels Oct 15, 2021
@jeffhandley
Copy link
Member

/backport to release/6.0

I'm invoking this early so that we can go ahead and send this for tactics consideration into 6.0 GA.

@jeffhandley jeffhandley removed the Servicing-consider Issue for next servicing release review label Oct 15, 2021
@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1344506847

@ghost
Copy link

ghost commented Oct 15, 2021

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

With #56498 we have added Message and Url properties to the RequiresPreviewFeatures, now with dotnet/roslyn-analyzers#5502 the analyzer would include those Message and Url in the error message. So now its time to apply custom message and url to all generic math APIs having [RequiresPreviewFeatures] attributes

Literally updated all APIs [RequiresPreviewFeatures] attributes, seems all related to generic math, but not that sure

Author: buyaa-n
Assignees: -
Labels:

area-System.Runtime

Milestone: -

@github-actions
Copy link
Contributor

@jeffhandley backporting to release/6.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Apply custom messages and urls to all generic math [RequiresPreviewFeatures] attributes
Using index info to reconstruct a base tree...
M	eng/Versions.props
M	src/libraries/System.Private.CoreLib/src/System/Byte.cs
M	src/libraries/System.Private.CoreLib/src/System/Char.cs
M	src/libraries/System.Private.CoreLib/src/System/DateOnly.cs
M	src/libraries/System.Private.CoreLib/src/System/DateTime.cs
M	src/libraries/System.Private.CoreLib/src/System/DateTimeOffset.cs
M	src/libraries/System.Private.CoreLib/src/System/Decimal.cs
M	src/libraries/System.Private.CoreLib/src/System/Double.cs
M	src/libraries/System.Private.CoreLib/src/System/Guid.cs
M	src/libraries/System.Private.CoreLib/src/System/Half.cs
M	src/libraries/System.Private.CoreLib/src/System/Int16.cs
M	src/libraries/System.Private.CoreLib/src/System/Int32.cs
M	src/libraries/System.Private.CoreLib/src/System/Int64.cs
M	src/libraries/System.Private.CoreLib/src/System/IntPtr.cs
M	src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeFeature.cs
M	src/libraries/System.Private.CoreLib/src/System/SByte.cs
M	src/libraries/System.Private.CoreLib/src/System/Single.cs
M	src/libraries/System.Private.CoreLib/src/System/TimeOnly.cs
M	src/libraries/System.Private.CoreLib/src/System/TimeSpan.cs
M	src/libraries/System.Private.CoreLib/src/System/UInt16.cs
M	src/libraries/System.Private.CoreLib/src/System/UInt32.cs
M	src/libraries/System.Private.CoreLib/src/System/UInt64.cs
M	src/libraries/System.Private.CoreLib/src/System/UIntPtr.cs
M	src/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
M	src/libraries/System.Runtime/ref/System.Runtime.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.Runtime/ref/System.Runtime.cs
Auto-merging src/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/UIntPtr.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/UInt64.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/UInt32.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/UInt16.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/TimeSpan.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/TimeOnly.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/Single.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/SByte.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeFeature.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/IntPtr.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/Int64.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/Int32.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/Int16.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/Half.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/Guid.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/Double.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/Decimal.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/DateTimeOffset.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/DateTime.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/DateOnly.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/Char.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/Byte.cs
Auto-merging eng/Versions.props
CONFLICT (content): Merge conflict in eng/Versions.props
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Apply custom messages and urls to all generic math [RequiresPreviewFeatures] attributes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@jeffhandley jeffhandley changed the title Apply custom Message and Url to all generic math [RequiresPreviewFeatures] attributes Apply custom Message and Url to all [RequiresPreviewFeatures] attributes Oct 15, 2021
@buyaa-n
Copy link
Member Author

buyaa-n commented Oct 15, 2021

The build failure is unrelated and looks like CI issue:
Artifact BuildLogs_Mono__Linux_arm64_release already exists for build 1421094.

The other issue: [error]Exit code 137 returned from process: file name '/usr/bin/docker' is already reported #59736

So merging

@buyaa-n buyaa-n merged commit af4efb1 into dotnet:main Oct 15, 2021
@buyaa-n buyaa-n deleted the preview_message branch October 15, 2021 17:05
@ghost ghost locked as resolved and limited conversation to collaborators Nov 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants