Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: fix interaction of GDV and boxing #60355

Merged
merged 2 commits into from
Oct 19, 2021
Merged

JIT: fix interaction of GDV and boxing #60355

merged 2 commits into from
Oct 19, 2021

Conversation

AndyAyersMS
Copy link
Member

In #56126 we disabled GDV if the object being boxed came from a call with a
hidden return buffer pointer.

Fix this and enable GDV for these cases by inserting the box allocation before
the call.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 13, 2021
@ghost
Copy link

ghost commented Oct 13, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

In #56126 we disabled GDV if the object being boxed came from a call with a
hidden return buffer pointer.

Fix this and enable GDV for these cases by inserting the box allocation before
the call.

Author: AndyAyersMS
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@AndyAyersMS
Copy link
Member Author

@EgorBo PTAL
cc @dotnet/jit-contrib

Quite a few diffs as we're changing the placement of a newobj call. Sometimes doing it earlier is better, sometimes it is not. Overall something of a wash.

aspnet.run.windows.x64.checked.mch:


Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 11960181 (overridden on cmd)
Total bytes of diff: 11960141 (overridden on cmd)
Total bytes of delta: -40 (-0.00 % of base)
    diff is an improvement.
    relative diff is an improvement.
Detail diffs 


Top file improvements (bytes):
         -20 : 26259.dasm (-0.74% of base)
         -20 : 36504.dasm (-0.75% of base)

2 total files with Code Size differences (2 improved, 0 regressed), 0 unchanged.

Top method improvements (bytes):
         -20 (-0.74% of base) : 26259.dasm - <>c__DisplayClass4_0:<GetOrAdd>g__BuildServiceProvider|3():ValueTuple`2:this
         -20 (-0.75% of base) : 36504.dasm - <>c__DisplayClass4_0:<GetOrAdd>g__BuildServiceProvider|3():ValueTuple`2:this

Top method improvements (percentages):
         -20 (-0.75% of base) : 36504.dasm - <>c__DisplayClass4_0:<GetOrAdd>g__BuildServiceProvider|3():ValueTuple`2:this
         -20 (-0.74% of base) : 26259.dasm - <>c__DisplayClass4_0:<GetOrAdd>g__BuildServiceProvider|3():ValueTuple`2:this

2 total methods with Code Size differences (2 improved, 0 regressed), 0 unchanged.

benchmarks.run.windows.x64.checked.mch:


Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 7218883 (overridden on cmd)
Total bytes of diff: 7218927 (overridden on cmd)
Total bytes of delta: 44 (0.00 % of base)
    diff is a regression.
    relative diff is an improvement.
Detail diffs 


Top file regressions (bytes):
          21 : 18570.dasm (2.88% of base)
          16 : 11445.dasm (1.15% of base)
          10 : 1993.dasm (0.29% of base)
           7 : 5983.dasm (2.71% of base)
           3 : 4607.dasm (2.75% of base)
           3 : 23035.dasm (3.03% of base)

Top file improvements (bytes):
          -4 : 13827.dasm (-1.01% of base)
          -3 : 17862.dasm (-4.84% of base)
          -3 : 13656.dasm (-2.03% of base)
          -2 : 14670.dasm (-2.78% of base)
          -2 : 5726.dasm (-2.78% of base)
          -2 : 14676.dasm (-2.78% of base)

12 total files with Code Size differences (6 improved, 6 regressed), 4 unchanged.

Top method regressions (bytes):
          21 ( 2.88% of base) : 18570.dasm - Microsoft.CodeAnalysis.CSharp.Binder:FoldDecimalBinaryOperators(int,Microsoft.CodeAnalysis.ConstantValue,Microsoft.CodeAnalysis.ConstantValue):System.Object
          16 ( 1.15% of base) : 11445.dasm - System.Runtime.Serialization.Formatters.Binary.BinaryParser:ReadValue(int):System.Object:this
          10 ( 0.29% of base) : 1993.dasm - Newtonsoft.Json.JsonTextReader:ParseReadNumber(int,ushort,int):this
           7 ( 2.71% of base) : 5983.dasm - System.Collections.Immutable.ImmutableDictionary`2[__Canon,__Canon][System.__Canon,System.__Canon]:System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<TKey,TValue>>.GetEnumerator():System.Collections.Generic.IEnumerator`1[KeyValuePair`2]:this
           3 ( 2.75% of base) : 4607.dasm - System.Diagnostics.DiagLinkedList`1[ActivityEvent][System.Diagnostics.ActivityEvent]:System.Collections.Generic.IEnumerable<T>.GetEnumerator():System.Collections.Generic.IEnumerator`1[ActivityEvent]:this
           3 ( 3.03% of base) : 23035.dasm - TagsLinkedList:System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<System.String,System.Object>>.GetEnumerator():System.Collections.Generic.IEnumerator`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Object, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]]:this

Top method improvements (bytes):
          -4 (-1.01% of base) : 13827.dasm - MicroBenchmarks.Serializers.MyEventsListerItemTask:get_FormattedDate():System.String:this
          -3 (-4.84% of base) : 17862.dasm - Microsoft.CodeAnalysis.PooledObjects.ArrayBuilder`1[__Canon][System.__Canon]:System.Collections.Generic.IEnumerable<T>.GetEnumerator():System.Collections.Generic.IEnumerator`1[__Canon]:this
          -3 (-2.03% of base) : 13656.dasm - System.Text.Json.Serialization.Converters.ObjectConverter:Read(byref,System.Type,System.Text.Json.JsonSerializerOptions):System.Object:this
          -2 (-2.78% of base) : 14676.dasm - System.Net.NetworkInformation.InternalIPAddressCollection:GetEnumerator():System.Collections.Generic.IEnumerator`1[[System.Net.IPAddress, System.Net.Primitives, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]]:this
          -2 (-2.78% of base) : 14670.dasm - System.Net.NetworkInformation.IPAddressInformationCollection:GetEnumerator():System.Collections.Generic.IEnumerator`1[[System.Net.NetworkInformation.IPAddressInformation, System.Net.NetworkInformation, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]]:this
          -2 (-2.78% of base) : 5726.dasm - System.Text.Json.Serialization.ConverterList:GetEnumerator():System.Collections.Generic.IEnumerator`1[[System.Text.Json.Serialization.JsonConverter, System.Text.Json, Version=7.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]]:this

Top method regressions (percentages):
           3 ( 3.03% of base) : 23035.dasm - TagsLinkedList:System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<System.String,System.Object>>.GetEnumerator():System.Collections.Generic.IEnumerator`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Object, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]]:this
          21 ( 2.88% of base) : 18570.dasm - Microsoft.CodeAnalysis.CSharp.Binder:FoldDecimalBinaryOperators(int,Microsoft.CodeAnalysis.ConstantValue,Microsoft.CodeAnalysis.ConstantValue):System.Object
           3 ( 2.75% of base) : 4607.dasm - System.Diagnostics.DiagLinkedList`1[ActivityEvent][System.Diagnostics.ActivityEvent]:System.Collections.Generic.IEnumerable<T>.GetEnumerator():System.Collections.Generic.IEnumerator`1[ActivityEvent]:this
           7 ( 2.71% of base) : 5983.dasm - System.Collections.Immutable.ImmutableDictionary`2[__Canon,__Canon][System.__Canon,System.__Canon]:System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<TKey,TValue>>.GetEnumerator():System.Collections.Generic.IEnumerator`1[KeyValuePair`2]:this
          16 ( 1.15% of base) : 11445.dasm - System.Runtime.Serialization.Formatters.Binary.BinaryParser:ReadValue(int):System.Object:this
          10 ( 0.29% of base) : 1993.dasm - Newtonsoft.Json.JsonTextReader:ParseReadNumber(int,ushort,int):this

Top method improvements (percentages):
          -3 (-4.84% of base) : 17862.dasm - Microsoft.CodeAnalysis.PooledObjects.ArrayBuilder`1[__Canon][System.__Canon]:System.Collections.Generic.IEnumerable<T>.GetEnumerator():System.Collections.Generic.IEnumerator`1[__Canon]:this
          -2 (-2.78% of base) : 14676.dasm - System.Net.NetworkInformation.InternalIPAddressCollection:GetEnumerator():System.Collections.Generic.IEnumerator`1[[System.Net.IPAddress, System.Net.Primitives, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]]:this
          -2 (-2.78% of base) : 14670.dasm - System.Net.NetworkInformation.IPAddressInformationCollection:GetEnumerator():System.Collections.Generic.IEnumerator`1[[System.Net.NetworkInformation.IPAddressInformation, System.Net.NetworkInformation, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]]:this
          -2 (-2.78% of base) : 5726.dasm - System.Text.Json.Serialization.ConverterList:GetEnumerator():System.Collections.Generic.IEnumerator`1[[System.Text.Json.Serialization.JsonConverter, System.Text.Json, Version=7.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]]:this
          -3 (-2.03% of base) : 13656.dasm - System.Text.Json.Serialization.Converters.ObjectConverter:Read(byref,System.Type,System.Text.Json.JsonSerializerOptions):System.Object:this
          -4 (-1.01% of base) : 13827.dasm - MicroBenchmarks.Serializers.MyEventsListerItemTask:get_FormattedDate():System.String:this

12 total methods with Code Size differences (6 improved, 6 regressed), 4 unchanged.

coreclr_tests.pmi.windows.x64.checked.mch:


Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 124781286 (overridden on cmd)
Total bytes of diff: 124780981 (overridden on cmd)
Total bytes of delta: -305 (-0.00 % of base)
    diff is an improvement.
    relative diff is an improvement.
Detail diffs 


Top file regressions (bytes):
           5 : 210834.dasm (0.38% of base)

Top file improvements (bytes):
         -36 : 247831.dasm (-7.64% of base)
         -36 : 247841.dasm (-7.64% of base)
         -24 : 247785.dasm (-6.30% of base)
         -24 : 248069.dasm (-6.78% of base)
         -24 : 248062.dasm (-6.78% of base)
         -24 : 248032.dasm (-6.78% of base)
         -24 : 248039.dasm (-6.78% of base)
         -24 : 247799.dasm (-6.40% of base)
         -18 : 247880.dasm (-5.25% of base)
         -18 : 247892.dasm (-5.25% of base)
         -18 : 247931.dasm (-5.26% of base)
         -18 : 247941.dasm (-5.26% of base)
         -17 : 210827.dasm (-2.51% of base)
          -5 : 212635.dasm (-4.31% of base)

15 total files with Code Size differences (14 improved, 1 regressed), 2 unchanged.

Top method regressions (bytes):
           5 ( 0.38% of base) : 210834.dasm - <Verify>d__9:MoveNext():bool:this

Top method improvements (bytes):
         -36 (-7.64% of base) : 247831.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -36 (-7.64% of base) : 247841.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -24 (-6.78% of base) : 248069.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single])
         -24 (-6.78% of base) : 248062.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single])
         -24 (-6.30% of base) : 247785.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -24 (-6.78% of base) : 248032.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -24 (-6.78% of base) : 248039.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -24 (-6.40% of base) : 247799.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -18 (-5.26% of base) : 247931.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single])
         -18 (-5.26% of base) : 247941.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single])
         -18 (-5.25% of base) : 247880.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -18 (-5.25% of base) : 247892.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -17 (-2.51% of base) : 210827.dasm - <Verify>d__8:MoveNext():bool:this
          -5 (-4.31% of base) : 212635.dasm - DispatchTesting:ExplicitGetEnumerator():System.Collections.IEnumerator:this

Top method regressions (percentages):
           5 ( 0.38% of base) : 210834.dasm - <Verify>d__9:MoveNext():bool:this

Top method improvements (percentages):
         -36 (-7.64% of base) : 247831.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -36 (-7.64% of base) : 247841.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -24 (-6.78% of base) : 248069.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single])
         -24 (-6.78% of base) : 248062.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single])
         -24 (-6.78% of base) : 248032.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -24 (-6.78% of base) : 248039.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -24 (-6.40% of base) : 247799.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -24 (-6.30% of base) : 247785.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -18 (-5.26% of base) : 247931.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single])
         -18 (-5.26% of base) : 247941.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single])
         -18 (-5.25% of base) : 247880.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -18 (-5.25% of base) : 247892.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
          -5 (-4.31% of base) : 212635.dasm - DispatchTesting:ExplicitGetEnumerator():System.Collections.IEnumerator:this
         -17 (-2.51% of base) : 210827.dasm - <Verify>d__8:MoveNext():bool:this

15 total methods with Code Size differences (14 improved, 1 regressed), 2 unchanged.

libraries.crossgen2.windows.x64.checked.mch:


Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 34846609 (overridden on cmd)
Total bytes of diff: 34848041 (overridden on cmd)
Total bytes of delta: 1432 (0.00 % of base)
    diff is a regression.
    relative diff is a regression.
Detail diffs 


Top file regressions (bytes):
          38 : 43432.dasm (15.26% of base)
          38 : 43351.dasm (15.26% of base)
          38 : 43381.dasm (15.97% of base)
          38 : 43450.dasm (15.97% of base)
          38 : 43422.dasm (14.62% of base)
          34 : 43390.dasm (12.93% of base)
          29 : 43334.dasm (13.06% of base)
          23 : 43441.dasm (11.33% of base)
          23 : 43363.dasm (10.75% of base)
          23 : 43459.dasm (11.33% of base)
          23 : 43372.dasm (10.75% of base)
          20 : 167083.dasm (9.26% of base)
          18 : 42323.dasm (8.04% of base)
          18 : 93329.dasm (25.35% of base)
          18 : 93337.dasm (25.35% of base)
          17 : 47238.dasm (10.37% of base)
          16 : 166904.dasm (8.29% of base)
          16 : 155753.dasm (6.37% of base)
          16 : 167505.dasm (6.32% of base)
          15 : 47450.dasm (7.54% of base)

Top file improvements (bytes):
         -28 : 102242.dasm (-1.98% of base)
         -10 : 114536.dasm (-1.73% of base)
          -6 : 155942.dasm (-8.82% of base)
          -6 : 156374.dasm (-8.82% of base)
          -6 : 155958.dasm (-8.82% of base)
          -6 : 156354.dasm (-8.82% of base)
          -6 : 155905.dasm (-8.82% of base)
          -6 : 156393.dasm (-8.82% of base)
          -6 : 155914.dasm (-8.82% of base)
          -6 : 156337.dasm (-8.82% of base)
          -6 : 155950.dasm (-8.82% of base)
          -6 : 156364.dasm (-8.82% of base)
          -6 : 156328.dasm (-8.82% of base)
          -6 : 155922.dasm (-8.82% of base)
          -6 : 155930.dasm (-8.82% of base)
          -6 : 156384.dasm (-8.82% of base)
          -6 : 156403.dasm (-8.82% of base)
          -5 : 205185.dasm (-7.58% of base)
          -3 : 98827.dasm (-1.36% of base)
          -3 : 151177.dasm (-0.07% of base)

513 total files with Code Size differences (98 improved, 415 regressed), 93 unchanged.

Top method regressions (bytes):
          38 (15.97% of base) : 43450.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata10TemplateHATraceData:PayloadValue(int):System.Object:this
          38 (15.26% of base) : 43351.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata13TemplateHATraceData:PayloadValue(int):System.Object:this
          38 (14.62% of base) : 43422.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata3TemplateHATraceData:PayloadValue(int):System.Object:this
          38 (15.26% of base) : 43432.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata4TemplateHATraceData:PayloadValue(int):System.Object:this
          38 (15.97% of base) : 43381.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata7TemplateHATraceData:PayloadValue(int):System.Object:this
          34 (12.93% of base) : 43390.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata5TemplateHATraceData:PayloadValue(int):System.Object:this
          29 (13.06% of base) : 43334.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata14TemplateHATraceData:PayloadValue(int):System.Object:this
          23 (10.75% of base) : 43372.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata11TemplateHATraceData:PayloadValue(int):System.Object:this
          23 (10.75% of base) : 43363.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata12TemplateHATraceData:PayloadValue(int):System.Object:this
          23 (11.33% of base) : 43441.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata8TemplateHATraceData:PayloadValue(int):System.Object:this
          23 (11.33% of base) : 43459.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata9TemplateHATraceData:PayloadValue(int):System.Object:this
          20 ( 9.26% of base) : 167083.dasm - HashBucket:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          18 (25.35% of base) : 93337.dasm - ArrayEnumerator:System.Collections.Generic.IEnumerable<System.Text.Json.JsonElement>.GetEnumerator():System.Collections.Generic.IEnumerator`1[System.Text.Json.JsonElement]:this
          18 ( 8.04% of base) : 42323.dasm - Microsoft.Diagnostics.Tracing.Parsers.MicrosoftAntimalwareEngine.BehaviorMonitoringBmDetectionArgsTraceData:PayloadValue(int):System.Object:this
          18 (25.35% of base) : 93329.dasm - ObjectEnumerator:System.Collections.Generic.IEnumerable<System.Text.Json.JsonProperty>.GetEnumerator():System.Collections.Generic.IEnumerator`1[System.Text.Json.JsonProperty]:this
          17 (10.37% of base) : 47238.dasm - Microsoft.Diagnostics.Tracing.Parsers.IIS_Trace.IISGeneralHandlerChanged:PayloadValue(int):System.Object:this
          16 ( 6.32% of base) : 167505.dasm - System.Collections.Immutable.ImmutableHashSet`1:System.Collections.Generic.IEnumerable<T>.GetEnumerator():System.Collections.Generic.IEnumerator`1[System.__Canon]:this
          16 ( 8.29% of base) : 166904.dasm - System.Collections.Immutable.ImmutableList`1:System.Collections.Generic.IEnumerable<T>.GetEnumerator():System.Collections.Generic.IEnumerator`1[System.__Canon]:this
          16 ( 6.37% of base) : 155753.dasm - System.Reflection.Metadata.SequencePointCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.SequencePoint>.GetEnumerator():System.Collections.Generic.IEnumerator`1[System.Reflection.Metadata.SequencePoint]:this
          15 ( 7.54% of base) : 47450.dasm - Microsoft.Diagnostics.Tracing.Parsers.IIS_Trace.W3GeneralEndpointInformation:PayloadValue(int):System.Object:this

Top method improvements (bytes):
         -28 (-1.98% of base) : 102242.dasm - System.Xml.Xsl.Runtime.XsltConvert:ConvertToType(System.Xml.Schema.XmlAtomicValue,System.Xml.Xsl.XmlQueryType):System.Xml.Schema.XmlAtomicValue
         -10 (-1.73% of base) : 114536.dasm - Microsoft.VisualBasic.Conversion:Int(System.Object):System.Object
          -6 (-8.82% of base) : 156403.dasm - System.Reflection.Metadata.CustomAttributeHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 155905.dasm - System.Reflection.Metadata.CustomDebugInformationHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 156393.dasm - System.Reflection.Metadata.DeclarativeSecurityAttributeHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 155958.dasm - System.Reflection.Metadata.DocumentHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 156354.dasm - System.Reflection.Metadata.EventDefinitionHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 156374.dasm - System.Reflection.Metadata.FieldDefinitionHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 155914.dasm - System.Reflection.Metadata.ImportScopeCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 156328.dasm - System.Reflection.Metadata.InterfaceImplementationHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 155922.dasm - System.Reflection.Metadata.LocalConstantHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 155942.dasm - System.Reflection.Metadata.LocalScopeHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 155930.dasm - System.Reflection.Metadata.LocalVariableHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 155950.dasm - System.Reflection.Metadata.MethodDebugInformationHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 156384.dasm - System.Reflection.Metadata.MethodDefinitionHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 156337.dasm - System.Reflection.Metadata.ParameterHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 156364.dasm - System.Reflection.Metadata.PropertyDefinitionHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -5 (-7.58% of base) : 205185.dasm - System.Diagnostics.DiagLinkedList`1:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -3 (-4.69% of base) : 36365.dasm - Microsoft.CodeAnalysis.ArrayBuilder`1:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -3 (-4.92% of base) : 34714.dasm - Roslyn.Utilities.ConsList`1:System.Collections.Generic.IEnumerable<T>.GetEnumerator():System.Collections.Generic.IEnumerator`1[System.__Canon]:this

Top method regressions (percentages):
          18 (25.35% of base) : 93337.dasm - ArrayEnumerator:System.Collections.Generic.IEnumerable<System.Text.Json.JsonElement>.GetEnumerator():System.Collections.Generic.IEnumerator`1[System.Text.Json.JsonElement]:this
          18 (25.35% of base) : 93329.dasm - ObjectEnumerator:System.Collections.Generic.IEnumerable<System.Text.Json.JsonProperty>.GetEnumerator():System.Collections.Generic.IEnumerator`1[System.Text.Json.JsonProperty]:this
          38 (15.97% of base) : 43450.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata10TemplateHATraceData:PayloadValue(int):System.Object:this
          38 (15.97% of base) : 43381.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata7TemplateHATraceData:PayloadValue(int):System.Object:this
          38 (15.26% of base) : 43351.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata13TemplateHATraceData:PayloadValue(int):System.Object:this
          38 (15.26% of base) : 43432.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata4TemplateHATraceData:PayloadValue(int):System.Object:this
          38 (14.62% of base) : 43422.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata3TemplateHATraceData:PayloadValue(int):System.Object:this
          29 (13.06% of base) : 43334.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata14TemplateHATraceData:PayloadValue(int):System.Object:this
          34 (12.93% of base) : 43390.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata5TemplateHATraceData:PayloadValue(int):System.Object:this
          23 (11.33% of base) : 43441.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata8TemplateHATraceData:PayloadValue(int):System.Object:this
          23 (11.33% of base) : 43459.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata9TemplateHATraceData:PayloadValue(int):System.Object:this
          23 (10.75% of base) : 43372.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata11TemplateHATraceData:PayloadValue(int):System.Object:this
          23 (10.75% of base) : 43363.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata12TemplateHATraceData:PayloadValue(int):System.Object:this
          17 (10.37% of base) : 47238.dasm - Microsoft.Diagnostics.Tracing.Parsers.IIS_Trace.IISGeneralHandlerChanged:PayloadValue(int):System.Object:this
          20 ( 9.26% of base) : 167083.dasm - HashBucket:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          14 ( 8.97% of base) : 43182.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata86TemplateHATraceData:PayloadValue(int):System.Object:this
          16 ( 8.29% of base) : 166904.dasm - System.Collections.Immutable.ImmutableList`1:System.Collections.Generic.IEnumerable<T>.GetEnumerator():System.Collections.Generic.IEnumerator`1[System.__Canon]:this
           6 ( 8.22% of base) : 42999.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata17TemplateATraceData:PayloadValue(int):System.Object:this
           6 ( 8.22% of base) : 47506.dasm - Microsoft.Diagnostics.Tracing.Parsers.IIS_Trace.IISGeneralConfigChangeNotification:PayloadValue(int):System.Object:this
           6 ( 8.22% of base) : 47497.dasm - Microsoft.Diagnostics.Tracing.Parsers.IIS_Trace.IISGeneralFileChangeNotification:PayloadValue(int):System.Object:this

Top method improvements (percentages):
          -6 (-8.82% of base) : 156403.dasm - System.Reflection.Metadata.CustomAttributeHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 155905.dasm - System.Reflection.Metadata.CustomDebugInformationHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 156393.dasm - System.Reflection.Metadata.DeclarativeSecurityAttributeHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 155958.dasm - System.Reflection.Metadata.DocumentHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 156354.dasm - System.Reflection.Metadata.EventDefinitionHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 156374.dasm - System.Reflection.Metadata.FieldDefinitionHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 155914.dasm - System.Reflection.Metadata.ImportScopeCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 156328.dasm - System.Reflection.Metadata.InterfaceImplementationHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 155922.dasm - System.Reflection.Metadata.LocalConstantHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 155942.dasm - System.Reflection.Metadata.LocalScopeHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 155930.dasm - System.Reflection.Metadata.LocalVariableHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 155950.dasm - System.Reflection.Metadata.MethodDebugInformationHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 156384.dasm - System.Reflection.Metadata.MethodDefinitionHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 156337.dasm - System.Reflection.Metadata.ParameterHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 156364.dasm - System.Reflection.Metadata.PropertyDefinitionHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -5 (-7.58% of base) : 205185.dasm - System.Diagnostics.DiagLinkedList`1:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -3 (-4.92% of base) : 34714.dasm - Roslyn.Utilities.ConsList`1:System.Collections.Generic.IEnumerable<T>.GetEnumerator():System.Collections.Generic.IEnumerator`1[System.__Canon]:this
          -3 (-4.69% of base) : 36365.dasm - Microsoft.CodeAnalysis.ArrayBuilder`1:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -3 (-4.55% of base) : 60578.dasm - System.Net.Http.Headers.ObjectCollection`1:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -2 (-3.45% of base) : 156283.dasm - System.Reflection.Metadata.AssemblyReferenceHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this

513 total methods with Code Size differences (98 improved, 415 regressed), 93 unchanged.

libraries.pmi.windows.x64.checked.mch:


Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 45508086 (overridden on cmd)
Total bytes of diff: 45509737 (overridden on cmd)
Total bytes of delta: 1651 (0.00 % of base)
    diff is a regression.
    relative diff is a regression.
Detail diffs 


Top file regressions (bytes):
          87 : 183155.dasm (4.32% of base)
          65 : 104409.dasm (19.40% of base)
          58 : 101215.dasm (24.07% of base)
          55 : 101206.dasm (23.50% of base)
          55 : 101277.dasm (23.50% of base)
          52 : 101189.dasm (22.91% of base)
          52 : 101253.dasm (22.91% of base)
          37 : 101245.dasm (14.18% of base)
          29 : 101285.dasm (13.81% of base)
          28 : 104410.dasm (8.89% of base)
          27 : 183915.dasm (2.79% of base)
          26 : 101095.dasm (18.44% of base)
          26 : 101102.dasm (18.44% of base)
          26 : 97487.dasm (18.44% of base)
          26 : 97506.dasm (18.44% of base)
          26 : 101087.dasm (18.44% of base)
          26 : 101412.dasm (18.44% of base)
          26 : 97470.dasm (18.44% of base)
          26 : 97478.dasm (18.44% of base)
          26 : 101123.dasm (18.44% of base)

Top file improvements (bytes):
         -65 : 187582.dasm (-2.73% of base)
         -33 : 164587.dasm (-1.55% of base)
         -26 : 187587.dasm (-2.36% of base)
         -26 : 187588.dasm (-2.36% of base)
         -26 : 164314.dasm (-1.40% of base)
         -26 : 187583.dasm (-2.36% of base)
         -26 : 187584.dasm (-2.36% of base)
         -26 : 187578.dasm (-2.38% of base)
         -26 : 187656.dasm (-2.63% of base)
         -23 : 164318.dasm (-1.89% of base)
         -23 : 109056.dasm (-1.89% of base)
         -21 : 188246.dasm (-2.01% of base)
         -20 : 187573.dasm (-2.00% of base)
         -17 : 146441.dasm (-2.00% of base)
         -17 : 215287.dasm (-1.19% of base)
         -17 : 109052.dasm (-0.72% of base)
         -16 : 187586.dasm (-1.41% of base)
         -16 : 187589.dasm (-1.41% of base)
         -16 : 187590.dasm (-1.42% of base)
         -16 : 187585.dasm (-1.41% of base)

445 total files with Code Size differences (106 improved, 339 regressed), 350 unchanged.

Top method regressions (bytes):
          87 ( 4.32% of base) : 183155.dasm - System.Data.Odbc.OdbcParameter:Bind(System.Data.Odbc.OdbcStatementHandle,System.Data.Odbc.OdbcCommand,short,System.Data.Odbc.CNativeBuffer,bool):this
          65 (19.40% of base) : 104409.dasm - Microsoft.VisualBasic.CompilerServices.Operators:MultiplyInt64(long,long):System.Object
          58 (24.07% of base) : 101215.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata3TemplateHATraceData:PayloadValue(int):System.Object:this
          55 (23.50% of base) : 101277.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata13TemplateHATraceData:PayloadValue(int):System.Object:this
          55 (23.50% of base) : 101206.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata4TemplateHATraceData:PayloadValue(int):System.Object:this
          52 (22.91% of base) : 101189.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata10TemplateHATraceData:PayloadValue(int):System.Object:this
          52 (22.91% of base) : 101253.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata7TemplateHATraceData:PayloadValue(int):System.Object:this
          37 (14.18% of base) : 101245.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata5TemplateHATraceData:PayloadValue(int):System.Object:this
          29 (13.81% of base) : 101285.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata14TemplateHATraceData:PayloadValue(int):System.Object:this
          28 ( 8.89% of base) : 104410.dasm - Microsoft.VisualBasic.CompilerServices.Operators:MultiplyUInt64(long,long):System.Object
          27 ( 2.79% of base) : 183915.dasm - System.Data.OleDb.OleDbParameter:CoerceValue(System.Object,System.Data.OleDb.NativeDBType):System.Object
          26 (12.81% of base) : 101261.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata11TemplateHATraceData:PayloadValue(int):System.Object:this
          26 (12.81% of base) : 101269.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata12TemplateHATraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101412.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata32TemplateHATraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101102.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagCriticalEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101109.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagErrorEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101123.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagInfoEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101160.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagResumeEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101138.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagStartEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101146.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagStopEventTraceData:PayloadValue(int):System.Object:this

Top method improvements (bytes):
         -65 (-2.73% of base) : 187582.dasm - System.Diagnostics.TraceInternal:TraceEvent(int,int,System.String,System.Object[])
         -33 (-1.55% of base) : 164587.dasm - <WriteArrayAsync>d__5:MoveNext():this
         -26 (-1.40% of base) : 164314.dasm - Newtonsoft.Json.Bson.BsonBinaryWriter:WriteTokenInternal(Newtonsoft.Json.Bson.BsonToken):this
         -26 (-2.38% of base) : 187578.dasm - System.Diagnostics.TraceInternal:Fail(System.String)
         -26 (-2.36% of base) : 187584.dasm - System.Diagnostics.TraceInternal:Write(System.Object)
         -26 (-2.36% of base) : 187583.dasm - System.Diagnostics.TraceInternal:Write(System.String)
         -26 (-2.36% of base) : 187588.dasm - System.Diagnostics.TraceInternal:WriteLine(System.Object)
         -26 (-2.36% of base) : 187587.dasm - System.Diagnostics.TraceInternal:WriteLine(System.String)
         -26 (-2.63% of base) : 187656.dasm - System.Diagnostics.TraceSource:Flush():this
         -23 (-1.89% of base) : 164318.dasm - Newtonsoft.Json.Bson.BsonBinaryWriter:CalculateSize(Newtonsoft.Json.Bson.BsonToken):int:this
         -23 (-1.89% of base) : 109056.dasm - Newtonsoft.Json.Bson.BsonBinaryWriter:CalculateSize(Newtonsoft.Json.Bson.BsonToken):int:this
         -21 (-2.01% of base) : 188246.dasm - System.DirectoryServices.AccountManagement.PrincipalCollectionEnumerator:MoveNext():bool:this
         -20 (-2.00% of base) : 187573.dasm - System.Diagnostics.TraceInternal:Flush()
         -17 (-0.72% of base) : 109052.dasm - Newtonsoft.Json.Bson.BsonBinaryWriter:WriteTokenInternal(Newtonsoft.Json.Bson.BsonToken):this
         -17 (-1.19% of base) : 215287.dasm - System.Runtime.Serialization.Formatters.Binary.BinaryParser:ReadValue(int):System.Object:this
         -17 (-2.00% of base) : 146441.dasm - System.Xml.Serialization.XmlSerializationPrimitiveReader:Read_decimal():System.Object:this
         -16 (-1.41% of base) : 187586.dasm - System.Diagnostics.TraceInternal:Write(System.Object,System.String)
         -16 (-1.41% of base) : 187585.dasm - System.Diagnostics.TraceInternal:Write(System.String,System.String)
         -16 (-1.42% of base) : 187590.dasm - System.Diagnostics.TraceInternal:WriteLine(System.Object,System.String)
         -16 (-1.41% of base) : 187589.dasm - System.Diagnostics.TraceInternal:WriteLine(System.String,System.String)

Top method regressions (percentages):
          58 (24.07% of base) : 101215.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata3TemplateHATraceData:PayloadValue(int):System.Object:this
          20 (23.81% of base) : 152939.dasm - ArrayEnumerator:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          20 (23.81% of base) : 152947.dasm - ObjectEnumerator:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          55 (23.50% of base) : 101277.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata13TemplateHATraceData:PayloadValue(int):System.Object:this
          55 (23.50% of base) : 101206.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata4TemplateHATraceData:PayloadValue(int):System.Object:this
          52 (22.91% of base) : 101189.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata10TemplateHATraceData:PayloadValue(int):System.Object:this
          52 (22.91% of base) : 101253.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata7TemplateHATraceData:PayloadValue(int):System.Object:this
          65 (19.40% of base) : 104409.dasm - Microsoft.VisualBasic.CompilerServices.Operators:MultiplyInt64(long,long):System.Object
          26 (18.44% of base) : 101412.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata32TemplateHATraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101102.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagCriticalEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101109.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagErrorEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101123.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagInfoEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101160.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagResumeEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101138.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagStartEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101146.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagStopEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101153.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagSuspendEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101167.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagTransferEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101131.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagVerboseEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101116.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagWarningEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101087.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetPageTraceWarnEventTraceData:PayloadValue(int):System.Object:this

Top method improvements (percentages):
          -6 (-7.89% of base) : 147845.dasm - System.Reflection.Metadata.CustomAttributeHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.CustomAttributeHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[CustomAttributeHandle]:this
          -6 (-7.89% of base) : 148354.dasm - System.Reflection.Metadata.CustomDebugInformationHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.CustomDebugInformationHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[CustomDebugInformationHandle]:this
          -6 (-7.89% of base) : 147855.dasm - System.Reflection.Metadata.DeclarativeSecurityAttributeHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.DeclarativeSecurityAttributeHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[DeclarativeSecurityAttributeHandle]:this
          -6 (-7.89% of base) : 148302.dasm - System.Reflection.Metadata.DocumentHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.DocumentHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[DocumentHandle]:this
          -6 (-7.89% of base) : 147894.dasm - System.Reflection.Metadata.EventDefinitionHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.EventDefinitionHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[EventDefinitionHandle]:this
          -6 (-7.89% of base) : 147874.dasm - System.Reflection.Metadata.FieldDefinitionHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.FieldDefinitionHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[FieldDefinitionHandle]:this
          -6 (-7.89% of base) : 148346.dasm - System.Reflection.Metadata.ImportScopeCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.ImportScopeHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[ImportScopeHandle]:this
          -6 (-7.89% of base) : 147921.dasm - System.Reflection.Metadata.InterfaceImplementationHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.InterfaceImplementationHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[InterfaceImplementationHandle]:this
          -6 (-7.89% of base) : 148338.dasm - System.Reflection.Metadata.LocalConstantHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.LocalConstantHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[LocalConstantHandle]:this
          -6 (-7.89% of base) : 148318.dasm - System.Reflection.Metadata.LocalScopeHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.LocalScopeHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[LocalScopeHandle]:this
          -6 (-7.89% of base) : 148330.dasm - System.Reflection.Metadata.LocalVariableHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.LocalVariableHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[LocalVariableHandle]:this
          -6 (-7.89% of base) : 148310.dasm - System.Reflection.Metadata.MethodDebugInformationHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.MethodDebugInformationHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[MethodDebugInformationHandle]:this
          -6 (-7.89% of base) : 147864.dasm - System.Reflection.Metadata.MethodDefinitionHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.MethodDefinitionHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[MethodDefinitionHandle]:this
          -6 (-7.89% of base) : 147912.dasm - System.Reflection.Metadata.ParameterHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.ParameterHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[ParameterHandle]:this
          -6 (-7.89% of base) : 147884.dasm - System.Reflection.Metadata.PropertyDefinitionHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.PropertyDefinitionHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[PropertyDefinitionHandle]:this
          -5 (-7.81% of base) : 185373.dasm - System.Diagnostics.DiagLinkedList`1[__Canon][System.__Canon]:System.Collections.Generic.IEnumerable<T>.GetEnumerator():System.Collections.Generic.IEnumerator`1[__Canon]:this
         -12 (-7.79% of base) : 171323.dasm - Builder[Byte][System.Byte]:System.Collections.Generic.IEnumerable<T>.GetEnumerator():System.Collections.Generic.IEnumerator`1[Byte]:this
          -8 (-7.02% of base) : 114666.dasm - System.Data.Common.BigIntegerStorage:ConvertXmlToObject(System.String):System.Object:this
          -8 (-6.15% of base) : 85543.dasm - Microsoft.Diagnostics.Tracing.Etlx.TraceEventStats:System.Collections.Generic.IEnumerable<Microsoft.Diagnostics.Tracing.Etlx.TraceEventCounts>.GetEnumerator():System.Collections.Generic.IEnumerator`1[[Microsoft.Diagnostics.Tracing.Etlx.TraceEventCounts, Microsoft.Diagnostics.Tracing.TraceEvent, Version=2.0.65.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]]:this
          -5 (-6.02% of base) : 161915.dasm - Microsoft.Extensions.FileProviders.Composite.CompositeDirectoryContents:GetEnumerator():System.Collections.Generic.IEnumerator`1[[Microsoft.Extensions.FileProviders.IFileInfo, Microsoft.Extensions.FileProviders.Abstractions, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60]]:this

445 total methods with Code Size differences (106 improved, 339 regressed), 350 unchanged.

libraries_tests.pmi.windows.x64.checked.mch:


Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 113592379 (overridden on cmd)
Total bytes of diff: 113592232 (overridden on cmd)
Total bytes of delta: -147 (-0.00 % of base)
    diff is an improvement.
    relative diff is an improvement.
Detail diffs 


Top file regressions (bytes):
          57 : 191024.dasm (7.47% of base)
          48 : 339792.dasm (0.47% of base)
          45 : 95652.dasm (0.40% of base)
          39 : 95887.dasm (2.97% of base)
          38 : 323597.dasm (3.12% of base)
          37 : 283062.dasm (6.13% of base)
          30 : 160945.dasm (1.18% of base)
          30 : 160963.dasm (1.58% of base)
          29 : 314248.dasm (1.01% of base)
          29 : 314250.dasm (0.93% of base)
          27 : 78123.dasm (0.43% of base)
          25 : 283060.dasm (3.65% of base)
          24 : 322076.dasm (0.18% of base)
          23 : 77670.dasm (4.78% of base)
          21 : 222454.dasm (0.39% of base)
          21 : 218123.dasm (0.39% of base)
          20 : 100966.dasm (6.04% of base)
          18 : 314249.dasm (0.61% of base)
          17 : 91222.dasm (0.53% of base)
          17 : 104375.dasm (0.53% of base)

Top file improvements (bytes):
         -85 : 1487.dasm (-17.14% of base)
         -50 : 323364.dasm (-0.30% of base)
         -30 : 347151.dasm (-0.39% of base)
         -30 : 155906.dasm (-17.05% of base)
         -27 : 226135.dasm (-2.65% of base)
         -26 : 155905.dasm (-16.88% of base)
         -24 : 155904.dasm (-18.46% of base)
         -23 : 346620.dasm (-0.32% of base)
         -23 : 169125.dasm (-2.31% of base)
         -22 : 323354.dasm (-1.33% of base)
         -21 : 170170.dasm (-1.64% of base)
         -21 : 189242.dasm (-3.68% of base)
         -19 : 221631.dasm (-1.25% of base)
         -19 : 169272.dasm (-1.90% of base)
         -19 : 217297.dasm (-1.25% of base)
         -18 : 115188.dasm (-3.64% of base)
         -18 : 116322.dasm (-0.31% of base)
         -18 : 189243.dasm (-3.01% of base)
         -17 : 168719.dasm (-1.19% of base)
         -17 : 168740.dasm (-1.32% of base)

658 total files with Code Size differences (405 improved, 253 regressed), 153 unchanged.

Top method regressions (bytes):
          57 ( 7.47% of base) : 191024.dasm - <>c:<Clamp_MinGreaterThanMax_ThrowsArgumentException>b__128_10():System.Object:this
          48 ( 0.47% of base) : 339792.dasm - System.Xml.Tests.ToTypeTests:TestValid(System.Object[],System.Object[],System.String,System.String[]):int:this
          45 ( 0.40% of base) : 95652.dasm - System.Text.Json.Tests.JsonDocumentTests:ObjectEnumeratorIndependentWalk()
          39 ( 2.97% of base) : 95887.dasm - System.Text.Json.Tests.JsonPropertyTests:NameEquals_UseGoodMatches_True(System.String,System.String)
          38 ( 3.12% of base) : 323597.dasm - <Cast_BigInteger_TestData>d__116:MoveNext():bool:this
          37 ( 6.13% of base) : 283062.dasm - <>c__DisplayClass8_0:<TagMustBeCorrect_Custom>b__3():System.Object:this
          30 ( 1.18% of base) : 160945.dasm - <get_EncoderTestData>d__2:MoveNext():bool:this
          30 ( 1.58% of base) : 160963.dasm - <get_ImageFormatGuidTestData>d__12:MoveNext():bool:this
          29 ( 1.01% of base) : 314248.dasm - System.Reflection.Metadata.Tests.MetadataReaderTests:MemberCollections_TypeMembers_FirstTypeDef():this
          29 ( 0.93% of base) : 314250.dasm - System.Reflection.Metadata.Tests.MetadataReaderTests:MemberCollections_TypeMembers_LastTypeDef():this
          27 ( 0.43% of base) : 78123.dasm - <GuidStrings_Valid_TestData>d__31:MoveNext():bool:this
          25 ( 3.65% of base) : 283060.dasm - <>c__DisplayClass8_0:<TagMustBeCorrect_Custom>b__1():System.Object:this
          24 ( 0.18% of base) : 322076.dasm - <GetObjectForNativeVariant_PrimitivesByRef_TestData>d__81:MoveNext():bool:this
          23 ( 4.78% of base) : 77670.dasm - <>c__DisplayClass62_0:<Parse_Span_Invalid>b__0():System.Object:this
          21 ( 0.39% of base) : 222454.dasm - System.Data.SqlClient.TdsParser:TDSExecuteRPCAddParameter(System.Data.SqlClient.TdsParserStateObject,System.Data.SqlClient.SqlParameter,System.Data.SqlClient.MetaType,ubyte):System.Threading.Tasks.Task:this
          21 ( 0.39% of base) : 218123.dasm - System.Data.SqlClient.TdsParser:TDSExecuteRPCAddParameter(System.Data.SqlClient.TdsParserStateObject,System.Data.SqlClient.SqlParameter,System.Data.SqlClient.MetaType,ubyte):System.Threading.Tasks.Task:this
          20 ( 6.04% of base) : 100966.dasm - System.Text.Json.Serialization.Tests.ClassWithComplexObjects:Initialize():this
          18 ( 0.61% of base) : 314249.dasm - System.Reflection.Metadata.Tests.MetadataReaderTests:MemberCollections_TypeMembers_MiddleTypeDef():this
          17 ( 0.53% of base) : 91222.dasm - <DeserializeIntoJsonElementProperty>d__65:MoveNext():this
          17 ( 0.53% of base) : 104375.dasm - <DeserializeIntoJsonElementProperty>d__65:MoveNext():this

Top method improvements (bytes):
         -85 (-17.14% of base) : 1487.dasm - Roslyn.Utilities.OneOrMany`1[Vector`1][System.Numerics.Vector`1[System.Single]]:Contains(System.Numerics.Vector`1[Single]):bool:this
         -50 (-0.30% of base) : 323364.dasm - <BinaryMinus_TestData>d__2:MoveNext():bool:this
         -30 (-17.05% of base) : 155906.dasm - <>c:<ArithmeticMethods>b__4_3():System.Object:this
         -30 (-0.39% of base) : 347151.dasm - System.Xml.Tests.CArgRemoveParam:RemoveParam11(int,int,int,int):this
         -27 (-2.65% of base) : 226135.dasm - Castle.Core.Logging.TraceLogger:Initialize():this
         -26 (-16.88% of base) : 155905.dasm - <>c:<ArithmeticMethods>b__4_0():System.Object:this
         -24 (-18.46% of base) : 155904.dasm - <>c__DisplayClass4_0:<ArithmeticMethods>b__2():System.Object:this
         -23 (-2.31% of base) : 169125.dasm - <MaxData>d__0:MoveNext():bool:this
         -23 (-0.32% of base) : 346620.dasm - System.Xml.Tests.CArgRemoveParam:RemoveParam11(System.Object,int,int,int,int):this
         -22 (-1.33% of base) : 323354.dasm - <UnaryPlus_TestData>d__0:MoveNext():bool:this
         -21 (-1.64% of base) : 170170.dasm - <NotLoadBalancedDegreeData>d__1:MoveNext():bool:this
         -21 (-3.68% of base) : 189242.dasm - System.TestHelpers:Concat(System.Collections.Generic.IEnumerable`1[__Canon],Xunit.TheoryData`1[__Canon]):Xunit.TheoryData`1[__Canon]
         -19 (-1.90% of base) : 169272.dasm - <MinData>d__0:MoveNext():bool:this
         -19 (-1.25% of base) : 221631.dasm - System.Data.SqlClient.SqlDataReader:IsDBNullAsync(int,System.Threading.CancellationToken):System.Threading.Tasks.Task`1[Boolean]:this
         -19 (-1.25% of base) : 217297.dasm - System.Data.SqlClient.SqlDataReader:IsDBNullAsync(int,System.Threading.CancellationToken):System.Threading.Tasks.Task`1[Boolean]:this
         -18 (-0.31% of base) : 116322.dasm - Microsoft.Build.Tasks.Deployment.Bootstrapper.BootstrapperBuilder:AddBuiltProducts(Microsoft.Build.Tasks.Deployment.Bootstrapper.BuildSettings):this
         -18 (-3.64% of base) : 115188.dasm - Microsoft.Build.Tasks.GenerateManifestBase:FindFileFromItem(Microsoft.Build.Framework.ITaskItem):Microsoft.Build.Tasks.Deployment.ManifestUtilities.FileReference:this
         -18 (-3.01% of base) : 189243.dasm - System.TestHelpers:Concat(System.Collections.Generic.IEnumerable`1[Byte],Xunit.TheoryData`1[Byte]):Xunit.TheoryData`1[Byte]
         -17 (-1.32% of base) : 168740.dasm - <DistinctSourceMultipleData>d__3:MoveNext():bool:this
         -17 (-1.19% of base) : 168719.dasm - <EmptyData>d__0:MoveNext():bool:this

Top method regressions (percentages):
          13 (17.33% of base) : 77607.dasm - <>c__DisplayClass35_0:<Divide_ZeroDenominator_ThrowsDivideByZeroException>b__0():System.Object:this
          13 (17.33% of base) : 77608.dasm - <>c__DisplayClass35_0:<Divide_ZeroDenominator_ThrowsDivideByZeroException>b__1():System.Object:this
          13 (17.33% of base) : 77614.dasm - <>c__DisplayClass37_0:<Divide_Overflows_ThrowsOverflowException>b__0():System.Object:this
          13 (17.33% of base) : 77615.dasm - <>c__DisplayClass37_0:<Divide_Overflows_ThrowsOverflowException>b__1():System.Object:this
          13 (17.33% of base) : 77643.dasm - <>c__DisplayClass53_0:<Multiply_Invalid>b__0():System.Object:this
          13 (17.33% of base) : 77644.dasm - <>c__DisplayClass53_0:<Multiply_Invalid>b__1():System.Object:this
          13 (17.33% of base) : 77685.dasm - <>c__DisplayClass68_0:<Remainder_ZeroDenominator_ThrowsDivideByZeroException>b__0():System.Object:this
          13 (17.33% of base) : 77686.dasm - <>c__DisplayClass68_0:<Remainder_ZeroDenominator_ThrowsDivideByZeroException>b__1():System.Object:this
          13 (16.67% of base) : 77585.dasm - <>c__DisplayClass26_0:<Add_Overflows_ThrowsOverflowException>b__0():System.Object:this
          13 (16.67% of base) : 77586.dasm - <>c__DisplayClass26_0:<Add_Overflows_ThrowsOverflowException>b__1():System.Object:this
          11 (16.42% of base) : 315391.dasm - <>c__DisplayClass6_0:<ReadFromMemoryBlock>b__15():System.Object:this
          11 (16.18% of base) : 315392.dasm - <>c__DisplayClass6_0:<ReadFromMemoryBlock>b__16():System.Object:this
          13 (16.05% of base) : 77718.dasm - <>c__DisplayClass81_0:<Subtract_Invalid>b__0():System.Object:this
          13 (16.05% of base) : 77719.dasm - <>c__DisplayClass81_0:<Subtract_Invalid>b__1():System.Object:this
          14 (15.05% of base) : 13764.dasm - ValueSet[__Canon,Nullable`1][System.__Canon,System.Nullable`1[System.Int32]]:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          11 (14.67% of base) : 315389.dasm - <>c__DisplayClass6_0:<ReadFromMemoryBlock>b__13():System.Object:this
          11 (14.67% of base) : 315390.dasm - <>c__DisplayClass6_0:<ReadFromMemoryBlock>b__14():System.Object:this
          13 (14.61% of base) : 155989.dasm - <>c__DisplayClass26_0:<DecimalToSqlMoney>b__0():System.Object:this
          11 (14.29% of base) : 315397.dasm - <>c__DisplayClass6_0:<ReadFromMemoryBlock>b__21():System.Object:this
          11 (13.92% of base) : 315364.dasm - <>c__DisplayClass4_0:<ReadFromMemoryReader>b__12():System.Object:this

Top method improvements (percentages):
         -24 (-18.46% of base) : 155904.dasm - <>c__DisplayClass4_0:<ArithmeticMethods>b__2():System.Object:this
         -85 (-17.14% of base) : 1487.dasm - Roslyn.Utilities.OneOrMany`1[Vector`1][System.Numerics.Vector`1[System.Single]]:Contains(System.Numerics.Vector`1[Single]):bool:this
         -30 (-17.05% of base) : 155906.dasm - <>c:<ArithmeticMethods>b__4_3():System.Object:this
         -26 (-16.88% of base) : 155905.dasm - <>c:<ArithmeticMethods>b__4_0():System.Object:this
          -9 (-8.41% of base) : 177388.dasm - <>c__DisplayClass4_0:<ArrayAsMemoryWithStartNegative>b__0():System.Object:this
         -12 (-7.64% of base) : 76502.dasm - <>c[Byte][System.Byte]:<Slice_Default_ThrowsInvalidOperationException>b__19_0():System.Object:this
          -8 (-6.56% of base) : 177389.dasm - <>c__DisplayClass5_0:<ArrayAsMemoryWithStartAndLengthNegative>b__0():System.Object:this
         -15 (-6.55% of base) : 12579.dasm - ValueSet[__Canon,Nullable`1][System.__Canon,System.Nullable`1[System.Int32]]:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -8 (-6.15% of base) : 117232.dasm - AssemblyMap:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -8 (-6.15% of base) : 117236.dasm - FileMap:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -5 (-5.75% of base) : 333058.dasm - <>c:<FromCanceled_CreatesCanceledTask>b__74_0():System.Object:this
          -5 (-5.75% of base) : 333046.dasm - <>c:<FromException_CreatesFaultedTask>b__75_0():System.Object:this
          -8 (-5.71% of base) : 76503.dasm - <>c[Byte][System.Byte]:<Slice_Default_ThrowsInvalidOperationException>b__19_1():System.Object:this
         -13 (-5.44% of base) : 232616.dasm - FluentAssertions.Events.EventRecorder:GetEnumerator():System.Collections.Generic.IEnumerator`1[[FluentAssertions.Events.RecordedEvent, FluentAssertions.Core, Version=4.19.4.0, Culture=neutral, PublicKeyToken=33f2691a05b67b6a]]:this
          -5 (-5.43% of base) : 333045.dasm - <>c:<FromCanceled_CreatesCanceledTask>b__74_1():System.Object:this
          -5 (-5.43% of base) : 333047.dasm - <>c:<FromException_CreatesFaultedTask>b__75_1():System.Object:this
          -3 (-5.08% of base) : 1208.dasm - Roslyn.Utilities.ConsList`1[__Canon][System.__Canon]:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -7 (-4.96% of base) : 155958.dasm - <>c__DisplayClass3_0:<ArithmeticMethods>b__3():System.Object:this
          -7 (-4.96% of base) : 154909.dasm - System.Data.Tests.SqlTypes.SqlMoneyTest:<ArithmeticMethods>b__8_0():System.Object:this
          -7 (-4.96% of base) : 154911.dasm - System.Data.Tests.SqlTypes.SqlMoneyTest:<ArithmeticMethods>b__8_2():System.Object:this

658 total methods with Code Size differences (405 improved, 253 regressed), 153 unchanged.

@AndyAyersMS
Copy link
Member Author

/azp run runtime-coreclr libraries-pgo

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AndyAyersMS
Copy link
Member Author

/azp run runtime-coreclr pgo

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AndyAyersMS
Copy link
Member Author

Seeing some failures like:

      !! Assert failure(PID 28237 [0x00006e4d], Thread: 28237 [0x6e4d]): Consistency check failed: FAILED: (!implSlot.IsNull() || pMT->IsInterface()) && "Valid method implementation was not found."
      !!     File: /__w/1/s/src/coreclr/vm/virtualcallstub.cpp Line: 2214
      !!     Image: /datadisks/disk1/work/AA940928/p/corerun

so this will need some more work.

@AndyAyersMS
JIT: fix interaction of GDV and boxing
c8326ca 
In dotnet#56126 we disabled GDV if the object being boxed came from a call with a
hidden return buffer pointer.

Fix this and enable GDV for these cases by inserting the box allocation before
the call.
@AndyAyersMS
Copy link
Member Author

The issue is that in some cases, when generating the box newobj we actually create several statements, so all of them need to move as a group.

@AndyAyersMS
Copy link
Member Author

/azp run runtime-coreclr libraries-pgo

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AndyAyersMS
Copy link
Member Author

Updated diffs

aspnet.run.windows.x64.checked.mch:


Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 11960129 (overridden on cmd)
Total bytes of diff: 11960089 (overridden on cmd)
Total bytes of delta: -40 (-0.00 % of base)
    diff is an improvement.
    relative diff is an improvement.
Detail diffs 


Top file improvements (bytes):
         -20 : 26259.dasm (-0.74% of base)
         -20 : 36504.dasm (-0.75% of base)

2 total files with Code Size differences (2 improved, 0 regressed), 0 unchanged.

Top method improvements (bytes):
         -20 (-0.74% of base) : 26259.dasm - <>c__DisplayClass4_0:<GetOrAdd>g__BuildServiceProvider|3():ValueTuple`2:this
         -20 (-0.75% of base) : 36504.dasm - <>c__DisplayClass4_0:<GetOrAdd>g__BuildServiceProvider|3():ValueTuple`2:this

Top method improvements (percentages):
         -20 (-0.75% of base) : 36504.dasm - <>c__DisplayClass4_0:<GetOrAdd>g__BuildServiceProvider|3():ValueTuple`2:this
         -20 (-0.74% of base) : 26259.dasm - <>c__DisplayClass4_0:<GetOrAdd>g__BuildServiceProvider|3():ValueTuple`2:this

2 total methods with Code Size differences (2 improved, 0 regressed), 0 unchanged.

benchmarks.run.windows.x64.checked.mch:


Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 7218781 (overridden on cmd)
Total bytes of diff: 7218825 (overridden on cmd)
Total bytes of delta: 44 (0.00 % of base)
    diff is a regression.
    relative diff is an improvement.
Detail diffs 


Top file regressions (bytes):
          21 : 18570.dasm (2.88% of base)
          16 : 11445.dasm (1.15% of base)
          10 : 1993.dasm (0.29% of base)
           7 : 5983.dasm (2.71% of base)
           3 : 23035.dasm (3.03% of base)
           3 : 4607.dasm (2.75% of base)

Top file improvements (bytes):
          -4 : 13827.dasm (-1.01% of base)
          -3 : 13656.dasm (-2.03% of base)
          -3 : 17862.dasm (-4.84% of base)
          -2 : 5726.dasm (-2.78% of base)
          -2 : 14670.dasm (-2.78% of base)
          -2 : 14676.dasm (-2.78% of base)

12 total files with Code Size differences (6 improved, 6 regressed), 4 unchanged.

Top method regressions (bytes):
          21 ( 2.88% of base) : 18570.dasm - Microsoft.CodeAnalysis.CSharp.Binder:FoldDecimalBinaryOperators(int,Microsoft.CodeAnalysis.ConstantValue,Microsoft.CodeAnalysis.ConstantValue):System.Object
          16 ( 1.15% of base) : 11445.dasm - System.Runtime.Serialization.Formatters.Binary.BinaryParser:ReadValue(int):System.Object:this
          10 ( 0.29% of base) : 1993.dasm - Newtonsoft.Json.JsonTextReader:ParseReadNumber(int,ushort,int):this
           7 ( 2.71% of base) : 5983.dasm - System.Collections.Immutable.ImmutableDictionary`2[__Canon,__Canon][System.__Canon,System.__Canon]:System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<TKey,TValue>>.GetEnumerator():System.Collections.Generic.IEnumerator`1[KeyValuePair`2]:this
           3 ( 2.75% of base) : 4607.dasm - System.Diagnostics.DiagLinkedList`1[ActivityEvent][System.Diagnostics.ActivityEvent]:System.Collections.Generic.IEnumerable<T>.GetEnumerator():System.Collections.Generic.IEnumerator`1[ActivityEvent]:this
           3 ( 3.03% of base) : 23035.dasm - TagsLinkedList:System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<System.String,System.Object>>.GetEnumerator():System.Collections.Generic.IEnumerator`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Object, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]]:this

Top method improvements (bytes):
          -4 (-1.01% of base) : 13827.dasm - MicroBenchmarks.Serializers.MyEventsListerItemTask:get_FormattedDate():System.String:this
          -3 (-4.84% of base) : 17862.dasm - Microsoft.CodeAnalysis.PooledObjects.ArrayBuilder`1[__Canon][System.__Canon]:System.Collections.Generic.IEnumerable<T>.GetEnumerator():System.Collections.Generic.IEnumerator`1[__Canon]:this
          -3 (-2.03% of base) : 13656.dasm - System.Text.Json.Serialization.Converters.ObjectConverter:Read(byref,System.Type,System.Text.Json.JsonSerializerOptions):System.Object:this
          -2 (-2.78% of base) : 14676.dasm - System.Net.NetworkInformation.InternalIPAddressCollection:GetEnumerator():System.Collections.Generic.IEnumerator`1[[System.Net.IPAddress, System.Net.Primitives, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]]:this
          -2 (-2.78% of base) : 14670.dasm - System.Net.NetworkInformation.IPAddressInformationCollection:GetEnumerator():System.Collections.Generic.IEnumerator`1[[System.Net.NetworkInformation.IPAddressInformation, System.Net.NetworkInformation, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]]:this
          -2 (-2.78% of base) : 5726.dasm - System.Text.Json.Serialization.ConverterList:GetEnumerator():System.Collections.Generic.IEnumerator`1[[System.Text.Json.Serialization.JsonConverter, System.Text.Json, Version=7.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]]:this

Top method regressions (percentages):
           3 ( 3.03% of base) : 23035.dasm - TagsLinkedList:System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<System.String,System.Object>>.GetEnumerator():System.Collections.Generic.IEnumerator`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Object, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]]:this
          21 ( 2.88% of base) : 18570.dasm - Microsoft.CodeAnalysis.CSharp.Binder:FoldDecimalBinaryOperators(int,Microsoft.CodeAnalysis.ConstantValue,Microsoft.CodeAnalysis.ConstantValue):System.Object
           3 ( 2.75% of base) : 4607.dasm - System.Diagnostics.DiagLinkedList`1[ActivityEvent][System.Diagnostics.ActivityEvent]:System.Collections.Generic.IEnumerable<T>.GetEnumerator():System.Collections.Generic.IEnumerator`1[ActivityEvent]:this
           7 ( 2.71% of base) : 5983.dasm - System.Collections.Immutable.ImmutableDictionary`2[__Canon,__Canon][System.__Canon,System.__Canon]:System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<TKey,TValue>>.GetEnumerator():System.Collections.Generic.IEnumerator`1[KeyValuePair`2]:this
          16 ( 1.15% of base) : 11445.dasm - System.Runtime.Serialization.Formatters.Binary.BinaryParser:ReadValue(int):System.Object:this
          10 ( 0.29% of base) : 1993.dasm - Newtonsoft.Json.JsonTextReader:ParseReadNumber(int,ushort,int):this

Top method improvements (percentages):
          -3 (-4.84% of base) : 17862.dasm - Microsoft.CodeAnalysis.PooledObjects.ArrayBuilder`1[__Canon][System.__Canon]:System.Collections.Generic.IEnumerable<T>.GetEnumerator():System.Collections.Generic.IEnumerator`1[__Canon]:this
          -2 (-2.78% of base) : 14676.dasm - System.Net.NetworkInformation.InternalIPAddressCollection:GetEnumerator():System.Collections.Generic.IEnumerator`1[[System.Net.IPAddress, System.Net.Primitives, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]]:this
          -2 (-2.78% of base) : 14670.dasm - System.Net.NetworkInformation.IPAddressInformationCollection:GetEnumerator():System.Collections.Generic.IEnumerator`1[[System.Net.NetworkInformation.IPAddressInformation, System.Net.NetworkInformation, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]]:this
          -2 (-2.78% of base) : 5726.dasm - System.Text.Json.Serialization.ConverterList:GetEnumerator():System.Collections.Generic.IEnumerator`1[[System.Text.Json.Serialization.JsonConverter, System.Text.Json, Version=7.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]]:this
          -3 (-2.03% of base) : 13656.dasm - System.Text.Json.Serialization.Converters.ObjectConverter:Read(byref,System.Type,System.Text.Json.JsonSerializerOptions):System.Object:this
          -4 (-1.01% of base) : 13827.dasm - MicroBenchmarks.Serializers.MyEventsListerItemTask:get_FormattedDate():System.String:this

12 total methods with Code Size differences (6 improved, 6 regressed), 4 unchanged.

coreclr_tests.pmi.windows.x64.checked.mch:


Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 127706717 (overridden on cmd)
Total bytes of diff: 127706412 (overridden on cmd)
Total bytes of delta: -305 (-0.00 % of base)
    diff is an improvement.
    relative diff is an improvement.
Detail diffs 


Top file regressions (bytes):
           5 : 210797.dasm (0.37% of base)

Top file improvements (bytes):
         -36 : 247840.dasm (-7.64% of base)
         -36 : 247830.dasm (-7.64% of base)
         -24 : 247798.dasm (-6.40% of base)
         -24 : 248038.dasm (-6.78% of base)
         -24 : 248061.dasm (-6.78% of base)
         -24 : 248031.dasm (-6.78% of base)
         -24 : 247784.dasm (-6.30% of base)
         -24 : 248068.dasm (-6.78% of base)
         -18 : 247879.dasm (-5.25% of base)
         -18 : 247891.dasm (-5.25% of base)
         -18 : 247930.dasm (-5.26% of base)
         -18 : 247940.dasm (-5.26% of base)
         -17 : 210790.dasm (-2.38% of base)
          -5 : 212598.dasm (-4.31% of base)

15 total files with Code Size differences (14 improved, 1 regressed), 2 unchanged.

Top method regressions (bytes):
           5 ( 0.37% of base) : 210797.dasm - <Verify>d__9:MoveNext():bool:this

Top method improvements (bytes):
         -36 (-7.64% of base) : 247840.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -36 (-7.64% of base) : 247830.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -24 (-6.78% of base) : 248061.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single])
         -24 (-6.78% of base) : 248068.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single])
         -24 (-6.40% of base) : 247798.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -24 (-6.78% of base) : 248038.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -24 (-6.78% of base) : 248031.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -24 (-6.30% of base) : 247784.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -18 (-5.26% of base) : 247930.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single])
         -18 (-5.26% of base) : 247940.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single])
         -18 (-5.25% of base) : 247879.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -18 (-5.25% of base) : 247891.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -17 (-2.38% of base) : 210790.dasm - <Verify>d__8:MoveNext():bool:this
          -5 (-4.31% of base) : 212598.dasm - DispatchTesting:ExplicitGetEnumerator():System.Collections.IEnumerator:this

Top method regressions (percentages):
           5 ( 0.37% of base) : 210797.dasm - <Verify>d__9:MoveNext():bool:this

Top method improvements (percentages):
         -36 (-7.64% of base) : 247840.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -36 (-7.64% of base) : 247830.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -24 (-6.78% of base) : 248061.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single])
         -24 (-6.78% of base) : 248068.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single])
         -24 (-6.78% of base) : 248038.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -24 (-6.78% of base) : 248031.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -24 (-6.40% of base) : 247798.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -24 (-6.30% of base) : 247784.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -18 (-5.26% of base) : 247930.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single])
         -18 (-5.26% of base) : 247940.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single])
         -18 (-5.25% of base) : 247879.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
         -18 (-5.25% of base) : 247891.dasm - Gen`1[Vector`1][System.Numerics.Vector`1[System.Single]]:PassAsParameter(System.Numerics.Vector`1[Single],System.Numerics.Vector`1[Single]):this
          -5 (-4.31% of base) : 212598.dasm - DispatchTesting:ExplicitGetEnumerator():System.Collections.IEnumerator:this
         -17 (-2.38% of base) : 210790.dasm - <Verify>d__8:MoveNext():bool:this

15 total methods with Code Size differences (14 improved, 1 regressed), 2 unchanged.

libraries.crossgen2.windows.x64.checked.mch:


Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 34847879 (overridden on cmd)
Total bytes of diff: 34849311 (overridden on cmd)
Total bytes of delta: 1432 (0.00 % of base)
    diff is a regression.
    relative diff is a regression.
Detail diffs 


Top file regressions (bytes):
          38 : 103613.dasm (15.97% of base)
          38 : 103523.dasm (15.26% of base)
          38 : 103597.dasm (15.26% of base)
          38 : 103588.dasm (14.62% of base)
          38 : 103550.dasm (15.97% of base)
          34 : 103558.dasm (12.93% of base)
          29 : 103507.dasm (13.06% of base)
          23 : 103542.dasm (10.75% of base)
          23 : 103534.dasm (10.75% of base)
          23 : 103621.dasm (11.33% of base)
          23 : 103605.dasm (11.33% of base)
          20 : 177879.dasm (9.26% of base)
          18 : 95790.dasm (25.35% of base)
          18 : 95798.dasm (25.35% of base)
          18 : 102594.dasm (8.04% of base)
          17 : 107366.dasm (10.37% of base)
          16 : 178301.dasm (6.32% of base)
          16 : 91842.dasm (6.37% of base)
          16 : 177700.dasm (8.29% of base)
          15 : 107578.dasm (7.54% of base)

Top file improvements (bytes):
         -28 : 123784.dasm (-1.98% of base)
         -10 : 144812.dasm (-1.73% of base)
          -6 : 92030.dasm (-8.82% of base)
          -6 : 92038.dasm (-8.82% of base)
          -6 : 92046.dasm (-8.82% of base)
          -6 : 92470.dasm (-8.82% of base)
          -6 : 92480.dasm (-8.82% of base)
          -6 : 92489.dasm (-8.82% of base)
          -6 : 92499.dasm (-8.82% of base)
          -6 : 91993.dasm (-8.82% of base)
          -6 : 92002.dasm (-8.82% of base)
          -6 : 92010.dasm (-8.82% of base)
          -6 : 92018.dasm (-8.82% of base)
          -6 : 92424.dasm (-8.82% of base)
          -6 : 92433.dasm (-8.82% of base)
          -6 : 92450.dasm (-8.82% of base)
          -6 : 92460.dasm (-8.82% of base)
          -5 : 216484.dasm (-7.58% of base)
          -3 : 151279.dasm (-4.69% of base)
          -3 : 93840.dasm (-1.94% of base)

513 total files with Code Size differences (98 improved, 415 regressed), 93 unchanged.

Top method regressions (bytes):
          38 (15.97% of base) : 103613.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata10TemplateHATraceData:PayloadValue(int):System.Object:this
          38 (15.26% of base) : 103523.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata13TemplateHATraceData:PayloadValue(int):System.Object:this
          38 (14.62% of base) : 103588.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata3TemplateHATraceData:PayloadValue(int):System.Object:this
          38 (15.26% of base) : 103597.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata4TemplateHATraceData:PayloadValue(int):System.Object:this
          38 (15.97% of base) : 103550.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata7TemplateHATraceData:PayloadValue(int):System.Object:this
          34 (12.93% of base) : 103558.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata5TemplateHATraceData:PayloadValue(int):System.Object:this
          29 (13.06% of base) : 103507.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata14TemplateHATraceData:PayloadValue(int):System.Object:this
          23 (10.75% of base) : 103542.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata11TemplateHATraceData:PayloadValue(int):System.Object:this
          23 (10.75% of base) : 103534.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata12TemplateHATraceData:PayloadValue(int):System.Object:this
          23 (11.33% of base) : 103605.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata8TemplateHATraceData:PayloadValue(int):System.Object:this
          23 (11.33% of base) : 103621.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata9TemplateHATraceData:PayloadValue(int):System.Object:this
          20 ( 9.26% of base) : 177879.dasm - HashBucket:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          18 (25.35% of base) : 95798.dasm - ArrayEnumerator:System.Collections.Generic.IEnumerable<System.Text.Json.JsonElement>.GetEnumerator():System.Collections.Generic.IEnumerator`1[System.Text.Json.JsonElement]:this
          18 ( 8.04% of base) : 102594.dasm - Microsoft.Diagnostics.Tracing.Parsers.MicrosoftAntimalwareEngine.BehaviorMonitoringBmDetectionArgsTraceData:PayloadValue(int):System.Object:this
          18 (25.35% of base) : 95790.dasm - ObjectEnumerator:System.Collections.Generic.IEnumerable<System.Text.Json.JsonProperty>.GetEnumerator():System.Collections.Generic.IEnumerator`1[System.Text.Json.JsonProperty]:this
          17 (10.37% of base) : 107366.dasm - Microsoft.Diagnostics.Tracing.Parsers.IIS_Trace.IISGeneralHandlerChanged:PayloadValue(int):System.Object:this
          16 ( 6.32% of base) : 178301.dasm - System.Collections.Immutable.ImmutableHashSet`1:System.Collections.Generic.IEnumerable<T>.GetEnumerator():System.Collections.Generic.IEnumerator`1[System.__Canon]:this
          16 ( 8.29% of base) : 177700.dasm - System.Collections.Immutable.ImmutableList`1:System.Collections.Generic.IEnumerable<T>.GetEnumerator():System.Collections.Generic.IEnumerator`1[System.__Canon]:this
          16 ( 6.37% of base) : 91842.dasm - System.Reflection.Metadata.SequencePointCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.SequencePoint>.GetEnumerator():System.Collections.Generic.IEnumerator`1[System.Reflection.Metadata.SequencePoint]:this
          15 ( 7.54% of base) : 107578.dasm - Microsoft.Diagnostics.Tracing.Parsers.IIS_Trace.W3GeneralEndpointInformation:PayloadValue(int):System.Object:this

Top method improvements (bytes):
         -28 (-1.98% of base) : 123784.dasm - System.Xml.Xsl.Runtime.XsltConvert:ConvertToType(System.Xml.Schema.XmlAtomicValue,System.Xml.Xsl.XmlQueryType):System.Xml.Schema.XmlAtomicValue
         -10 (-1.73% of base) : 144812.dasm - Microsoft.VisualBasic.Conversion:Int(System.Object):System.Object
          -6 (-8.82% of base) : 92499.dasm - System.Reflection.Metadata.CustomAttributeHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 91993.dasm - System.Reflection.Metadata.CustomDebugInformationHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92489.dasm - System.Reflection.Metadata.DeclarativeSecurityAttributeHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92046.dasm - System.Reflection.Metadata.DocumentHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92450.dasm - System.Reflection.Metadata.EventDefinitionHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92470.dasm - System.Reflection.Metadata.FieldDefinitionHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92002.dasm - System.Reflection.Metadata.ImportScopeCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92424.dasm - System.Reflection.Metadata.InterfaceImplementationHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92010.dasm - System.Reflection.Metadata.LocalConstantHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92030.dasm - System.Reflection.Metadata.LocalScopeHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92018.dasm - System.Reflection.Metadata.LocalVariableHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92038.dasm - System.Reflection.Metadata.MethodDebugInformationHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92480.dasm - System.Reflection.Metadata.MethodDefinitionHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92433.dasm - System.Reflection.Metadata.ParameterHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92460.dasm - System.Reflection.Metadata.PropertyDefinitionHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -5 (-7.58% of base) : 216484.dasm - System.Diagnostics.DiagLinkedList`1:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -3 (-4.69% of base) : 151279.dasm - Microsoft.CodeAnalysis.ArrayBuilder`1:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -3 (-4.92% of base) : 149680.dasm - Roslyn.Utilities.ConsList`1:System.Collections.Generic.IEnumerable<T>.GetEnumerator():System.Collections.Generic.IEnumerator`1[System.__Canon]:this

Top method regressions (percentages):
          18 (25.35% of base) : 95798.dasm - ArrayEnumerator:System.Collections.Generic.IEnumerable<System.Text.Json.JsonElement>.GetEnumerator():System.Collections.Generic.IEnumerator`1[System.Text.Json.JsonElement]:this
          18 (25.35% of base) : 95790.dasm - ObjectEnumerator:System.Collections.Generic.IEnumerable<System.Text.Json.JsonProperty>.GetEnumerator():System.Collections.Generic.IEnumerator`1[System.Text.Json.JsonProperty]:this
          38 (15.97% of base) : 103613.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata10TemplateHATraceData:PayloadValue(int):System.Object:this
          38 (15.97% of base) : 103550.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata7TemplateHATraceData:PayloadValue(int):System.Object:this
          38 (15.26% of base) : 103523.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata13TemplateHATraceData:PayloadValue(int):System.Object:this
          38 (15.26% of base) : 103597.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata4TemplateHATraceData:PayloadValue(int):System.Object:this
          38 (14.62% of base) : 103588.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata3TemplateHATraceData:PayloadValue(int):System.Object:this
          29 (13.06% of base) : 103507.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata14TemplateHATraceData:PayloadValue(int):System.Object:this
          34 (12.93% of base) : 103558.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata5TemplateHATraceData:PayloadValue(int):System.Object:this
          23 (11.33% of base) : 103605.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata8TemplateHATraceData:PayloadValue(int):System.Object:this
          23 (11.33% of base) : 103621.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata9TemplateHATraceData:PayloadValue(int):System.Object:this
          23 (10.75% of base) : 103542.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata11TemplateHATraceData:PayloadValue(int):System.Object:this
          23 (10.75% of base) : 103534.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata12TemplateHATraceData:PayloadValue(int):System.Object:this
          17 (10.37% of base) : 107366.dasm - Microsoft.Diagnostics.Tracing.Parsers.IIS_Trace.IISGeneralHandlerChanged:PayloadValue(int):System.Object:this
          20 ( 9.26% of base) : 177879.dasm - HashBucket:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          14 ( 8.97% of base) : 103371.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata86TemplateHATraceData:PayloadValue(int):System.Object:this
          16 ( 8.29% of base) : 177700.dasm - System.Collections.Immutable.ImmutableList`1:System.Collections.Generic.IEnumerable<T>.GetEnumerator():System.Collections.Generic.IEnumerator`1[System.__Canon]:this
           6 ( 8.22% of base) : 103207.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata17TemplateATraceData:PayloadValue(int):System.Object:this
           6 ( 8.22% of base) : 107634.dasm - Microsoft.Diagnostics.Tracing.Parsers.IIS_Trace.IISGeneralConfigChangeNotification:PayloadValue(int):System.Object:this
           6 ( 8.22% of base) : 107625.dasm - Microsoft.Diagnostics.Tracing.Parsers.IIS_Trace.IISGeneralFileChangeNotification:PayloadValue(int):System.Object:this

Top method improvements (percentages):
          -6 (-8.82% of base) : 92499.dasm - System.Reflection.Metadata.CustomAttributeHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 91993.dasm - System.Reflection.Metadata.CustomDebugInformationHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92489.dasm - System.Reflection.Metadata.DeclarativeSecurityAttributeHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92046.dasm - System.Reflection.Metadata.DocumentHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92450.dasm - System.Reflection.Metadata.EventDefinitionHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92470.dasm - System.Reflection.Metadata.FieldDefinitionHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92002.dasm - System.Reflection.Metadata.ImportScopeCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92424.dasm - System.Reflection.Metadata.InterfaceImplementationHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92010.dasm - System.Reflection.Metadata.LocalConstantHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92030.dasm - System.Reflection.Metadata.LocalScopeHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92018.dasm - System.Reflection.Metadata.LocalVariableHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92038.dasm - System.Reflection.Metadata.MethodDebugInformationHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92480.dasm - System.Reflection.Metadata.MethodDefinitionHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92433.dasm - System.Reflection.Metadata.ParameterHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -6 (-8.82% of base) : 92460.dasm - System.Reflection.Metadata.PropertyDefinitionHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -5 (-7.58% of base) : 216484.dasm - System.Diagnostics.DiagLinkedList`1:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -3 (-4.92% of base) : 149680.dasm - Roslyn.Utilities.ConsList`1:System.Collections.Generic.IEnumerable<T>.GetEnumerator():System.Collections.Generic.IEnumerator`1[System.__Canon]:this
          -3 (-4.69% of base) : 151279.dasm - Microsoft.CodeAnalysis.ArrayBuilder`1:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -3 (-4.55% of base) : 96728.dasm - System.Net.Http.Headers.ObjectCollection`1:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -2 (-3.45% of base) : 92376.dasm - System.Reflection.Metadata.AssemblyReferenceHandleCollection:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this

513 total methods with Code Size differences (98 improved, 415 regressed), 93 unchanged.

libraries.pmi.windows.x64.checked.mch:


Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 46038169 (overridden on cmd)
Total bytes of diff: 46039841 (overridden on cmd)
Total bytes of delta: 1672 (0.00 % of base)
    diff is a regression.
    relative diff is a regression.
Detail diffs 


Top file regressions (bytes):
          87 : 183512.dasm (4.32% of base)
          65 : 104409.dasm (19.40% of base)
          58 : 101215.dasm (24.07% of base)
          55 : 101277.dasm (23.50% of base)
          55 : 101206.dasm (23.50% of base)
          52 : 101253.dasm (22.91% of base)
          52 : 101189.dasm (22.91% of base)
          37 : 101245.dasm (14.18% of base)
          29 : 101285.dasm (13.81% of base)
          28 : 104410.dasm (8.89% of base)
          27 : 184272.dasm (2.79% of base)
          26 : 101102.dasm (18.44% of base)
          26 : 101167.dasm (18.44% of base)
          26 : 101146.dasm (18.44% of base)
          26 : 101261.dasm (12.81% of base)
          26 : 101138.dasm (18.44% of base)
          26 : 101153.dasm (18.44% of base)
          26 : 101269.dasm (12.81% of base)
          26 : 97470.dasm (18.44% of base)
          26 : 97478.dasm (18.44% of base)

Top file improvements (bytes):
         -65 : 187939.dasm (-2.63% of base)
         -33 : 164944.dasm (-1.54% of base)
         -26 : 164671.dasm (-1.39% of base)
         -26 : 187940.dasm (-2.26% of base)
         -26 : 187941.dasm (-2.25% of base)
         -26 : 187935.dasm (-2.27% of base)
         -26 : 187944.dasm (-2.25% of base)
         -26 : 187945.dasm (-2.25% of base)
         -26 : 188013.dasm (-2.55% of base)
         -23 : 164675.dasm (-1.87% of base)
         -23 : 109056.dasm (-1.87% of base)
         -21 : 188603.dasm (-1.97% of base)
         -20 : 187930.dasm (-1.95% of base)
         -17 : 215288.dasm (-1.18% of base)
         -17 : 109052.dasm (-0.71% of base)
         -17 : 146441.dasm (-2.00% of base)
         -16 : 187947.dasm (-1.36% of base)
         -16 : 187942.dasm (-1.35% of base)
         -16 : 187943.dasm (-1.35% of base)
         -16 : 187946.dasm (-1.35% of base)

446 total files with Code Size differences (106 improved, 340 regressed), 349 unchanged.

Top method regressions (bytes):
          87 ( 4.32% of base) : 183512.dasm - System.Data.Odbc.OdbcParameter:Bind(System.Data.Odbc.OdbcStatementHandle,System.Data.Odbc.OdbcCommand,short,System.Data.Odbc.CNativeBuffer,bool):this
          65 (19.40% of base) : 104409.dasm - Microsoft.VisualBasic.CompilerServices.Operators:MultiplyInt64(long,long):System.Object
          58 (24.07% of base) : 101215.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata3TemplateHATraceData:PayloadValue(int):System.Object:this
          55 (23.50% of base) : 101277.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata13TemplateHATraceData:PayloadValue(int):System.Object:this
          55 (23.50% of base) : 101206.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata4TemplateHATraceData:PayloadValue(int):System.Object:this
          52 (22.91% of base) : 101189.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata10TemplateHATraceData:PayloadValue(int):System.Object:this
          52 (22.91% of base) : 101253.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata7TemplateHATraceData:PayloadValue(int):System.Object:this
          37 (14.18% of base) : 101245.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata5TemplateHATraceData:PayloadValue(int):System.Object:this
          29 (13.81% of base) : 101285.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata14TemplateHATraceData:PayloadValue(int):System.Object:this
          28 ( 8.89% of base) : 104410.dasm - Microsoft.VisualBasic.CompilerServices.Operators:MultiplyUInt64(long,long):System.Object
          27 ( 2.79% of base) : 184272.dasm - System.Data.OleDb.OleDbParameter:CoerceValue(System.Object,System.Data.OleDb.NativeDBType):System.Object
          26 (12.81% of base) : 101261.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata11TemplateHATraceData:PayloadValue(int):System.Object:this
          26 (12.81% of base) : 101269.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata12TemplateHATraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101412.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata32TemplateHATraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101102.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagCriticalEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101109.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagErrorEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101123.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagInfoEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101160.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagResumeEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101138.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagStartEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101146.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagStopEventTraceData:PayloadValue(int):System.Object:this

Top method improvements (bytes):
         -65 (-2.63% of base) : 187939.dasm - System.Diagnostics.TraceInternal:TraceEvent(int,int,System.String,System.Object[])
         -33 (-1.54% of base) : 164944.dasm - <WriteArrayAsync>d__5:MoveNext():this
         -26 (-1.39% of base) : 164671.dasm - Newtonsoft.Json.Bson.BsonBinaryWriter:WriteTokenInternal(Newtonsoft.Json.Bson.BsonToken):this
         -26 (-2.27% of base) : 187935.dasm - System.Diagnostics.TraceInternal:Fail(System.String)
         -26 (-2.25% of base) : 187941.dasm - System.Diagnostics.TraceInternal:Write(System.Object)
         -26 (-2.26% of base) : 187940.dasm - System.Diagnostics.TraceInternal:Write(System.String)
         -26 (-2.25% of base) : 187945.dasm - System.Diagnostics.TraceInternal:WriteLine(System.Object)
         -26 (-2.25% of base) : 187944.dasm - System.Diagnostics.TraceInternal:WriteLine(System.String)
         -26 (-2.55% of base) : 188013.dasm - System.Diagnostics.TraceSource:Flush():this
         -23 (-1.87% of base) : 164675.dasm - Newtonsoft.Json.Bson.BsonBinaryWriter:CalculateSize(Newtonsoft.Json.Bson.BsonToken):int:this
         -23 (-1.87% of base) : 109056.dasm - Newtonsoft.Json.Bson.BsonBinaryWriter:CalculateSize(Newtonsoft.Json.Bson.BsonToken):int:this
         -21 (-1.97% of base) : 188603.dasm - System.DirectoryServices.AccountManagement.PrincipalCollectionEnumerator:MoveNext():bool:this
         -20 (-1.95% of base) : 187930.dasm - System.Diagnostics.TraceInternal:Flush()
         -17 (-0.71% of base) : 109052.dasm - Newtonsoft.Json.Bson.BsonBinaryWriter:WriteTokenInternal(Newtonsoft.Json.Bson.BsonToken):this
         -17 (-1.18% of base) : 215288.dasm - System.Runtime.Serialization.Formatters.Binary.BinaryParser:ReadValue(int):System.Object:this
         -17 (-2.00% of base) : 146441.dasm - System.Xml.Serialization.XmlSerializationPrimitiveReader:Read_decimal():System.Object:this
         -16 (-1.35% of base) : 187943.dasm - System.Diagnostics.TraceInternal:Write(System.Object,System.String)
         -16 (-1.35% of base) : 187942.dasm - System.Diagnostics.TraceInternal:Write(System.String,System.String)
         -16 (-1.36% of base) : 187947.dasm - System.Diagnostics.TraceInternal:WriteLine(System.Object,System.String)
         -16 (-1.35% of base) : 187946.dasm - System.Diagnostics.TraceInternal:WriteLine(System.String,System.String)

Top method regressions (percentages):
          58 (24.07% of base) : 101215.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata3TemplateHATraceData:PayloadValue(int):System.Object:this
          20 (23.81% of base) : 153298.dasm - ArrayEnumerator:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          20 (23.81% of base) : 153306.dasm - ObjectEnumerator:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          55 (23.50% of base) : 101277.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata13TemplateHATraceData:PayloadValue(int):System.Object:this
          55 (23.50% of base) : 101206.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata4TemplateHATraceData:PayloadValue(int):System.Object:this
          52 (22.91% of base) : 101189.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata10TemplateHATraceData:PayloadValue(int):System.Object:this
          52 (22.91% of base) : 101253.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata7TemplateHATraceData:PayloadValue(int):System.Object:this
          65 (19.40% of base) : 104409.dasm - Microsoft.VisualBasic.CompilerServices.Operators:MultiplyInt64(long,long):System.Object
          26 (18.44% of base) : 101412.dasm - Microsoft.Diagnostics.Tracing.Parsers.ApplicationServer.Multidata32TemplateHATraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101102.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagCriticalEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101109.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagErrorEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101123.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagInfoEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101160.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagResumeEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101138.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagStartEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101146.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagStopEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101153.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagSuspendEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101167.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagTransferEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101131.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagVerboseEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101116.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetModuleDiagWarningEventTraceData:PayloadValue(int):System.Object:this
          26 (18.44% of base) : 101087.dasm - Microsoft.Diagnostics.Tracing.Parsers.AspNet.AspNetPageTraceWarnEventTraceData:PayloadValue(int):System.Object:this

Top method improvements (percentages):
          -6 (-7.89% of base) : 147845.dasm - System.Reflection.Metadata.CustomAttributeHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.CustomAttributeHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[CustomAttributeHandle]:this
          -6 (-7.89% of base) : 148354.dasm - System.Reflection.Metadata.CustomDebugInformationHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.CustomDebugInformationHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[CustomDebugInformationHandle]:this
          -6 (-7.89% of base) : 147855.dasm - System.Reflection.Metadata.DeclarativeSecurityAttributeHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.DeclarativeSecurityAttributeHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[DeclarativeSecurityAttributeHandle]:this
          -6 (-7.89% of base) : 148302.dasm - System.Reflection.Metadata.DocumentHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.DocumentHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[DocumentHandle]:this
          -6 (-7.89% of base) : 147894.dasm - System.Reflection.Metadata.EventDefinitionHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.EventDefinitionHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[EventDefinitionHandle]:this
          -6 (-7.89% of base) : 147874.dasm - System.Reflection.Metadata.FieldDefinitionHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.FieldDefinitionHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[FieldDefinitionHandle]:this
          -6 (-7.89% of base) : 148346.dasm - System.Reflection.Metadata.ImportScopeCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.ImportScopeHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[ImportScopeHandle]:this
          -6 (-7.89% of base) : 147921.dasm - System.Reflection.Metadata.InterfaceImplementationHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.InterfaceImplementationHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[InterfaceImplementationHandle]:this
          -6 (-7.89% of base) : 148338.dasm - System.Reflection.Metadata.LocalConstantHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.LocalConstantHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[LocalConstantHandle]:this
          -6 (-7.89% of base) : 148318.dasm - System.Reflection.Metadata.LocalScopeHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.LocalScopeHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[LocalScopeHandle]:this
          -6 (-7.89% of base) : 148330.dasm - System.Reflection.Metadata.LocalVariableHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.LocalVariableHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[LocalVariableHandle]:this
          -6 (-7.89% of base) : 148310.dasm - System.Reflection.Metadata.MethodDebugInformationHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.MethodDebugInformationHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[MethodDebugInformationHandle]:this
          -6 (-7.89% of base) : 147864.dasm - System.Reflection.Metadata.MethodDefinitionHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.MethodDefinitionHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[MethodDefinitionHandle]:this
          -6 (-7.89% of base) : 147912.dasm - System.Reflection.Metadata.ParameterHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.ParameterHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[ParameterHandle]:this
          -6 (-7.89% of base) : 147884.dasm - System.Reflection.Metadata.PropertyDefinitionHandleCollection:System.Collections.Generic.IEnumerable<System.Reflection.Metadata.PropertyDefinitionHandle>.GetEnumerator():System.Collections.Generic.IEnumerator`1[PropertyDefinitionHandle]:this
          -5 (-7.81% of base) : 185730.dasm - System.Diagnostics.DiagLinkedList`1[__Canon][System.__Canon]:System.Collections.Generic.IEnumerable<T>.GetEnumerator():System.Collections.Generic.IEnumerator`1[__Canon]:this
         -12 (-7.79% of base) : 171680.dasm - Builder[Byte][System.Byte]:System.Collections.Generic.IEnumerable<T>.GetEnumerator():System.Collections.Generic.IEnumerator`1[Byte]:this
          -8 (-7.02% of base) : 114666.dasm - System.Data.Common.BigIntegerStorage:ConvertXmlToObject(System.String):System.Object:this
          -8 (-6.15% of base) : 85543.dasm - Microsoft.Diagnostics.Tracing.Etlx.TraceEventStats:System.Collections.Generic.IEnumerable<Microsoft.Diagnostics.Tracing.Etlx.TraceEventCounts>.GetEnumerator():System.Collections.Generic.IEnumerator`1[[Microsoft.Diagnostics.Tracing.Etlx.TraceEventCounts, Microsoft.Diagnostics.Tracing.TraceEvent, Version=2.0.65.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]]:this
          -5 (-6.02% of base) : 162273.dasm - Microsoft.Extensions.FileProviders.Composite.CompositeDirectoryContents:GetEnumerator():System.Collections.Generic.IEnumerator`1[[Microsoft.Extensions.FileProviders.IFileInfo, Microsoft.Extensions.FileProviders.Abstractions, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60]]:this

446 total methods with Code Size differences (106 improved, 340 regressed), 349 unchanged.

libraries_tests.pmi.windows.x64.checked.mch:


Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 114857601 (overridden on cmd)
Total bytes of diff: 114857456 (overridden on cmd)
Total bytes of delta: -145 (-0.00 % of base)
    diff is an improvement.
    relative diff is an improvement.
Detail diffs 


Top file regressions (bytes):
          57 : 191055.dasm (7.47% of base)
          49 : 339838.dasm (0.48% of base)
          45 : 95430.dasm (0.39% of base)
          39 : 95665.dasm (2.93% of base)
          38 : 322123.dasm (3.12% of base)
          37 : 283260.dasm (6.13% of base)
          30 : 160930.dasm (1.18% of base)
          30 : 160948.dasm (1.58% of base)
          29 : 314442.dasm (1.00% of base)
          29 : 314444.dasm (0.92% of base)
          27 : 77902.dasm (0.43% of base)
          25 : 283258.dasm (3.65% of base)
          24 : 192426.dasm (0.18% of base)
          23 : 77449.dasm (4.78% of base)
          21 : 222423.dasm (0.39% of base)
          21 : 218157.dasm (0.39% of base)
          20 : 100744.dasm (6.04% of base)
          18 : 314443.dasm (0.61% of base)
          17 : 91000.dasm (0.53% of base)
          17 : 104150.dasm (0.53% of base)

Top file improvements (bytes):
         -85 : 1487.dasm (-17.14% of base)
         -50 : 321891.dasm (-0.30% of base)
         -30 : 155889.dasm (-17.05% of base)
         -30 : 347197.dasm (-0.38% of base)
         -27 : 226101.dasm (-2.65% of base)
         -26 : 155888.dasm (-16.88% of base)
         -24 : 155887.dasm (-18.46% of base)
         -23 : 169297.dasm (-2.26% of base)
         -23 : 346666.dasm (-0.32% of base)
         -22 : 321881.dasm (-1.33% of base)
         -21 : 189274.dasm (-3.57% of base)
         -21 : 170196.dasm (-1.60% of base)
         -19 : 221600.dasm (-1.25% of base)
         -19 : 217331.dasm (-1.25% of base)
         -18 : 115184.dasm (-3.56% of base)
         -18 : 116318.dasm (-0.30% of base)
         -18 : 189275.dasm (-2.86% of base)
         -17 : 168744.dasm (-1.14% of base)
         -17 : 168765.dasm (-1.28% of base)
         -16 : 177496.dasm (-2.40% of base)

657 total files with Code Size differences (405 improved, 252 regressed), 154 unchanged.

Top method regressions (bytes):
          57 ( 7.47% of base) : 191055.dasm - <>c:<Clamp_MinGreaterThanMax_ThrowsArgumentException>b__128_10():System.Object:this
          49 ( 0.48% of base) : 339838.dasm - System.Xml.Tests.ToTypeTests:TestValid(System.Object[],System.Object[],System.String,System.String[]):int:this
          45 ( 0.39% of base) : 95430.dasm - System.Text.Json.Tests.JsonDocumentTests:ObjectEnumeratorIndependentWalk()
          39 ( 2.93% of base) : 95665.dasm - System.Text.Json.Tests.JsonPropertyTests:NameEquals_UseGoodMatches_True(System.String,System.String)
          38 ( 3.12% of base) : 322123.dasm - <Cast_BigInteger_TestData>d__116:MoveNext():bool:this
          37 ( 6.13% of base) : 283260.dasm - <>c__DisplayClass8_0:<TagMustBeCorrect_Custom>b__3():System.Object:this
          30 ( 1.18% of base) : 160930.dasm - <get_EncoderTestData>d__2:MoveNext():bool:this
          30 ( 1.58% of base) : 160948.dasm - <get_ImageFormatGuidTestData>d__12:MoveNext():bool:this
          29 ( 1.00% of base) : 314442.dasm - System.Reflection.Metadata.Tests.MetadataReaderTests:MemberCollections_TypeMembers_FirstTypeDef():this
          29 ( 0.92% of base) : 314444.dasm - System.Reflection.Metadata.Tests.MetadataReaderTests:MemberCollections_TypeMembers_LastTypeDef():this
          27 ( 0.43% of base) : 77902.dasm - <GuidStrings_Valid_TestData>d__31:MoveNext():bool:this
          25 ( 3.65% of base) : 283258.dasm - <>c__DisplayClass8_0:<TagMustBeCorrect_Custom>b__1():System.Object:this
          24 ( 0.18% of base) : 192426.dasm - <GetObjectForNativeVariant_PrimitivesByRef_TestData>d__81:MoveNext():bool:this
          23 ( 4.78% of base) : 77449.dasm - <>c__DisplayClass62_0:<Parse_Span_Invalid>b__0():System.Object:this
          21 ( 0.39% of base) : 222423.dasm - System.Data.SqlClient.TdsParser:TDSExecuteRPCAddParameter(System.Data.SqlClient.TdsParserStateObject,System.Data.SqlClient.SqlParameter,System.Data.SqlClient.MetaType,ubyte):System.Threading.Tasks.Task:this
          21 ( 0.39% of base) : 218157.dasm - System.Data.SqlClient.TdsParser:TDSExecuteRPCAddParameter(System.Data.SqlClient.TdsParserStateObject,System.Data.SqlClient.SqlParameter,System.Data.SqlClient.MetaType,ubyte):System.Threading.Tasks.Task:this
          20 ( 6.04% of base) : 100744.dasm - System.Text.Json.Serialization.Tests.ClassWithComplexObjects:Initialize():this
          18 ( 0.61% of base) : 314443.dasm - System.Reflection.Metadata.Tests.MetadataReaderTests:MemberCollections_TypeMembers_MiddleTypeDef():this
          17 ( 0.53% of base) : 91000.dasm - <DeserializeIntoJsonElementProperty>d__65:MoveNext():this
          17 ( 0.53% of base) : 104150.dasm - <DeserializeIntoJsonElementProperty>d__65:MoveNext():this

Top method improvements (bytes):
         -85 (-17.14% of base) : 1487.dasm - Roslyn.Utilities.OneOrMany`1[Vector`1][System.Numerics.Vector`1[System.Single]]:Contains(System.Numerics.Vector`1[Single]):bool:this
         -50 (-0.30% of base) : 321891.dasm - <BinaryMinus_TestData>d__2:MoveNext():bool:this
         -30 (-17.05% of base) : 155889.dasm - <>c:<ArithmeticMethods>b__4_3():System.Object:this
         -30 (-0.38% of base) : 347197.dasm - System.Xml.Tests.CArgRemoveParam:RemoveParam11(int,int,int,int):this
         -27 (-2.65% of base) : 226101.dasm - Castle.Core.Logging.TraceLogger:Initialize():this
         -26 (-16.88% of base) : 155888.dasm - <>c:<ArithmeticMethods>b__4_0():System.Object:this
         -24 (-18.46% of base) : 155887.dasm - <>c__DisplayClass4_0:<ArithmeticMethods>b__2():System.Object:this
         -23 (-2.26% of base) : 169297.dasm - <MinData>d__0:MoveNext():bool:this
         -23 (-0.32% of base) : 346666.dasm - System.Xml.Tests.CArgRemoveParam:RemoveParam11(System.Object,int,int,int,int):this
         -22 (-1.33% of base) : 321881.dasm - <UnaryPlus_TestData>d__0:MoveNext():bool:this
         -21 (-1.60% of base) : 170196.dasm - <NotLoadBalancedDegreeData>d__1:MoveNext():bool:this
         -21 (-3.57% of base) : 189274.dasm - System.TestHelpers:Concat(System.Collections.Generic.IEnumerable`1[__Canon],Xunit.TheoryData`1[__Canon]):Xunit.TheoryData`1[__Canon]
         -19 (-1.25% of base) : 221600.dasm - System.Data.SqlClient.SqlDataReader:IsDBNullAsync(int,System.Threading.CancellationToken):System.Threading.Tasks.Task`1[Boolean]:this
         -19 (-1.25% of base) : 217331.dasm - System.Data.SqlClient.SqlDataReader:IsDBNullAsync(int,System.Threading.CancellationToken):System.Threading.Tasks.Task`1[Boolean]:this
         -18 (-0.30% of base) : 116318.dasm - Microsoft.Build.Tasks.Deployment.Bootstrapper.BootstrapperBuilder:AddBuiltProducts(Microsoft.Build.Tasks.Deployment.Bootstrapper.BuildSettings):this
         -18 (-3.56% of base) : 115184.dasm - Microsoft.Build.Tasks.GenerateManifestBase:FindFileFromItem(Microsoft.Build.Framework.ITaskItem):Microsoft.Build.Tasks.Deployment.ManifestUtilities.FileReference:this
         -18 (-2.86% of base) : 189275.dasm - System.TestHelpers:Concat(System.Collections.Generic.IEnumerable`1[Byte],Xunit.TheoryData`1[Byte]):Xunit.TheoryData`1[Byte]
         -17 (-1.28% of base) : 168765.dasm - <DistinctSourceMultipleData>d__3:MoveNext():bool:this
         -17 (-1.14% of base) : 168744.dasm - <EmptyData>d__0:MoveNext():bool:this
         -16 (-2.40% of base) : 177496.dasm - <ReadOnlyMemoryCharInstances>d__2:MoveNext():bool:this

Top method regressions (percentages):
          13 (17.33% of base) : 77386.dasm - <>c__DisplayClass35_0:<Divide_ZeroDenominator_ThrowsDivideByZeroException>b__0():System.Object:this
          13 (17.33% of base) : 77387.dasm - <>c__DisplayClass35_0:<Divide_ZeroDenominator_ThrowsDivideByZeroException>b__1():System.Object:this
          13 (17.33% of base) : 77393.dasm - <>c__DisplayClass37_0:<Divide_Overflows_ThrowsOverflowException>b__0():System.Object:this
          13 (17.33% of base) : 77394.dasm - <>c__DisplayClass37_0:<Divide_Overflows_ThrowsOverflowException>b__1():System.Object:this
          13 (17.33% of base) : 77422.dasm - <>c__DisplayClass53_0:<Multiply_Invalid>b__0():System.Object:this
          13 (17.33% of base) : 77423.dasm - <>c__DisplayClass53_0:<Multiply_Invalid>b__1():System.Object:this
          13 (17.33% of base) : 77464.dasm - <>c__DisplayClass68_0:<Remainder_ZeroDenominator_ThrowsDivideByZeroException>b__0():System.Object:this
          13 (17.33% of base) : 77465.dasm - <>c__DisplayClass68_0:<Remainder_ZeroDenominator_ThrowsDivideByZeroException>b__1():System.Object:this
          13 (16.67% of base) : 77364.dasm - <>c__DisplayClass26_0:<Add_Overflows_ThrowsOverflowException>b__0():System.Object:this
          13 (16.67% of base) : 77365.dasm - <>c__DisplayClass26_0:<Add_Overflows_ThrowsOverflowException>b__1():System.Object:this
          11 (16.42% of base) : 315585.dasm - <>c__DisplayClass6_0:<ReadFromMemoryBlock>b__15():System.Object:this
          11 (16.18% of base) : 315586.dasm - <>c__DisplayClass6_0:<ReadFromMemoryBlock>b__16():System.Object:this
          13 (16.05% of base) : 77497.dasm - <>c__DisplayClass81_0:<Subtract_Invalid>b__0():System.Object:this
          13 (16.05% of base) : 77498.dasm - <>c__DisplayClass81_0:<Subtract_Invalid>b__1():System.Object:this
          14 (15.05% of base) : 13764.dasm - ValueSet[__Canon,Nullable`1][System.__Canon,System.Nullable`1[System.Int32]]:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          11 (14.67% of base) : 315583.dasm - <>c__DisplayClass6_0:<ReadFromMemoryBlock>b__13():System.Object:this
          11 (14.67% of base) : 315584.dasm - <>c__DisplayClass6_0:<ReadFromMemoryBlock>b__14():System.Object:this
          13 (14.61% of base) : 155972.dasm - <>c__DisplayClass26_0:<DecimalToSqlMoney>b__0():System.Object:this
          11 (14.29% of base) : 315591.dasm - <>c__DisplayClass6_0:<ReadFromMemoryBlock>b__21():System.Object:this
          11 (13.92% of base) : 315558.dasm - <>c__DisplayClass4_0:<ReadFromMemoryReader>b__12():System.Object:this

Top method improvements (percentages):
         -24 (-18.46% of base) : 155887.dasm - <>c__DisplayClass4_0:<ArithmeticMethods>b__2():System.Object:this
         -85 (-17.14% of base) : 1487.dasm - Roslyn.Utilities.OneOrMany`1[Vector`1][System.Numerics.Vector`1[System.Single]]:Contains(System.Numerics.Vector`1[Single]):bool:this
         -30 (-17.05% of base) : 155889.dasm - <>c:<ArithmeticMethods>b__4_3():System.Object:this
         -26 (-16.88% of base) : 155888.dasm - <>c:<ArithmeticMethods>b__4_0():System.Object:this
          -9 (-8.41% of base) : 177415.dasm - <>c__DisplayClass4_0:<ArrayAsMemoryWithStartNegative>b__0():System.Object:this
         -12 (-7.64% of base) : 76281.dasm - <>c[Byte][System.Byte]:<Slice_Default_ThrowsInvalidOperationException>b__19_0():System.Object:this
          -8 (-6.56% of base) : 177416.dasm - <>c__DisplayClass5_0:<ArrayAsMemoryWithStartAndLengthNegative>b__0():System.Object:this
         -15 (-6.55% of base) : 12579.dasm - ValueSet[__Canon,Nullable`1][System.__Canon,System.Nullable`1[System.Int32]]:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -8 (-6.15% of base) : 117226.dasm - AssemblyMap:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -8 (-6.15% of base) : 117230.dasm - FileMap:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -5 (-5.75% of base) : 333101.dasm - <>c:<FromCanceled_CreatesCanceledTask>b__74_0():System.Object:this
          -5 (-5.75% of base) : 333089.dasm - <>c:<FromException_CreatesFaultedTask>b__75_0():System.Object:this
          -8 (-5.71% of base) : 76282.dasm - <>c[Byte][System.Byte]:<Slice_Default_ThrowsInvalidOperationException>b__19_1():System.Object:this
         -13 (-5.44% of base) : 232582.dasm - FluentAssertions.Events.EventRecorder:GetEnumerator():System.Collections.Generic.IEnumerator`1[[FluentAssertions.Events.RecordedEvent, FluentAssertions.Core, Version=4.19.4.0, Culture=neutral, PublicKeyToken=33f2691a05b67b6a]]:this
          -5 (-5.43% of base) : 333088.dasm - <>c:<FromCanceled_CreatesCanceledTask>b__74_1():System.Object:this
          -5 (-5.43% of base) : 333090.dasm - <>c:<FromException_CreatesFaultedTask>b__75_1():System.Object:this
          -3 (-5.08% of base) : 1208.dasm - Roslyn.Utilities.ConsList`1[__Canon][System.__Canon]:System.Collections.IEnumerable.GetEnumerator():System.Collections.IEnumerator:this
          -7 (-4.96% of base) : 155941.dasm - <>c__DisplayClass3_0:<ArithmeticMethods>b__3():System.Object:this
          -7 (-4.96% of base) : 154892.dasm - System.Data.Tests.SqlTypes.SqlMoneyTest:<ArithmeticMethods>b__8_0():System.Object:this
          -7 (-4.96% of base) : 154894.dasm - System.Data.Tests.SqlTypes.SqlMoneyTest:<ArithmeticMethods>b__8_2():System.Object:this

657 total methods with Code Size differences (405 improved, 252 regressed), 154 unchanged.

@AndyAyersMS
Copy link
Member Author

I am seeing jit asserts in the dll import generator tests on Arm64 (which are new: #59579)

/root/helix/work/correlation/dotnet exec --runtimeconfig DllImportGenerator.Tests.runtimeconfig.json --depsfile DllImportGenerator.Tests.deps.json xunit.console.dll DllImportGenerator.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing 
popd
===========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e
  Discovering: DllImportGenerator.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  DllImportGenerator.Tests (found 94 test cases)
  Starting:    DllImportGenerator.Tests (parallel test collections = on, max threads = 4)

Assert failure(PID 27 [0x0000001b], Thread: 43 [0x002b]): Assertion failed 'op2->TypeIs(TYP_LONG)' in 'Span:AndAllMembers(System.Span`1[BoolStruct],int):bool' during 'Lowering nodeinfo' (IL size 180)

    File: /__w/1/s/src/coreclr/jit/gentree.cpp Line: 2449
    Image: /root/helix/work/correlation/dotnet

Not sure if this is a PGO specific failure yet.

cc @AaronRobinsonMSFT

@AndyAyersMS
Copy link
Member Author

Other than the failure above (which I suspect is unrelated) I think this is ready to go.

@EgorBo PTAL
cc @dotnet/jit-contrib

@AndyAyersMS
Copy link
Member Author

dll import generator arm64 test runs are also failing in jitstress, eg https://dev.azure.com/dnceng/public/_build/results?buildId=1429275&view=ms.vss-test-web.build-test-results-tab

So it looks like these failures are more widespread.

@AndyAyersMS
Copy link
Member Author

Opened #60624 for these new failures.

@AndyAyersMS AndyAyersMS merged commit 3126d58 into dotnet:main Oct 19, 2021
@AndyAyersMS AndyAyersMS deleted the FixBoxGdvInliningInteraction branch October 19, 2021 15:55
@ghost ghost locked as resolved and limited conversation to collaborators Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EgorBo EgorBo EgorBo approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndyAyersMS @EgorBo