[metadata] Replace uses of MonoType:byref by a getter #60313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call `mono_type_is_byref_internal` instead of accessing the byref bit directly. No functional change. (I hope). This is in preparation for exploring alternative representations of ref types.
lambdageek
requested review from
BrzVlad,
imhameed,
marek-safar,
SamMonoRT,
thaystg and
vargaz
as code owners
|
Tagging subscribers to this area: Issue DetailsCall No functional change. (I hope). This is in preparation for exploring alternative representations of ref types.
|
lambdageek
added
area-AssemblyLoader-mono
area-VM-meta-mono
and removed
area-VM-meta-mono
area-AssemblyLoader-mono
labels
|
Tagging subscribers to this area: Issue DetailsCall No functional change. (I hope). This is in preparation for exploring alternative representations of ref types.
|
|
Can it have a shorter name like m_type_is_byref () ? |
|
@vargaz changed to a shorter name. How's it look? |
vargaz
approved these changes
Oct 14, 2021
lambdageek
added a commit
to lambdageek/runtime
that referenced
this pull request
Oct 15, 2021
* [metadata] Replace uses of MonoType:byref by a getter Call `mono_type_is_byref_internal` instead of accessing the byref bit directly. No functional change. (I hope). This is in preparation for exploring alternative representations of ref types. * Change mono_type_is_byref_internal to take a const argument * Missed a couple byref reads * rename mono_type_is_byref_internal -> m_type_is_byref [NFC] * more missed byrefs * revert unintended change
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
Oct 18, 2021
Those were missed in dotnet#60313 and caused a build break on s390x. I fixed all other occurences I could find too.
akoeplinger
added a commit
that referenced
this pull request
Oct 18, 2021
Those were missed in #60313 and caused a build break on s390x. I fixed all other occurences I could find too.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call
m_type_is_byrefinstead of accessing the byref bit directly.No functional change. (I hope).
This is in preparation for exploring alternative representations of ref types.