Obsolete Regex.CompileToAssembly #59734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @eerhardt, @dotnet/area-system-text-regularexpressions Issue DetailsIt's never worked on .NET Core and for .NET 7 we'll now have the regex source generator. Fixes #50535
|
stephentoub
force-pushed
the
obsoletecompiletoassembly
branch
from
d8e4c5f
to
eb52697
Compare
danmoseley
approved these changes
Sep 30, 2021
src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/Regex.cs
Outdated
Show resolved
Hide resolved
It's never worked on .NET Core and for .NET 7 we'll now have the regex source generator.
Per PR feedback
stephentoub
force-pushed
the
obsoletecompiletoassembly
branch
from
eb52697
to
4759212
Compare
This was referenced Sep 30, 2021
|
Corresponding aka.ms link has been created and the docs issue is filed here: dotnet/docs#26328 |
This was referenced Sep 30, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's never worked on .NET Core and for .NET 7 we'll now have the regex source generator.
Fixes #50535