Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CROSSGEN_COMPILE define usage #57697

Merged
5 commits merged into from
Aug 19, 2021

Conversation

jkoritzinsky
Copy link
Member

Fixes #57657

Contributes to #54129 and #53007

cc: @dotnet/crossgen-contrib @AaronRobinsonMSFT @elinor-fung @jkotas @agocke

@ghost
Copy link

ghost commented Aug 19, 2021

Hello @jkoritzinsky!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Member

@mangod9 mangod9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@ghost ghost merged commit 948770a into dotnet:main Aug 19, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 19, 2021
@jkoritzinsky jkoritzinsky deleted the remove_dcrossgen_compile branch September 28, 2021 00:04
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove code guarded by CROSSGEN_COMPILE
5 participants