[release/6.0-rc1] JIT: don't clone loops where init or limit is a cast local #57690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The loop cloner assumes all computations it introduces are compatible with TYP_INT, so don't allow cloning when the initial or final value are variables with incompatible types. Fixes #57535.
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsBackport of #57602 to release/6.0-rc1 /cc @AndyAyersMS Customer ImpactTestingRisk
|
jeffschwMSFT
approved these changes
Aug 18, 2021
|
@kunalspathak ptal |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #57602 to release/6.0-rc1
/cc @AndyAyersMS
Customer Impact
Already reported by one customer (in 6p7). Caused crossgen2 to fail.
Testing
Verified it fixes the customer issue, plus new tests added. No diffs in existing tests (per SPMI).
Risk
Low, this is a change to disable an optimization in an uncommon situation.