Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Don't fold NEG(NEG(X)) to X when NEG(x) is a CSE candidate #57478

Merged
merged 4 commits into from
Aug 17, 2021
Merged

JIT: Don't fold NEG(NEG(X)) to X when NEG(x) is a CSE candidate #57478

merged 4 commits into from
Aug 17, 2021

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Aug 16, 2021 •
edited
Loading

Fixes #57470

cc @dotnet/jit-contrib

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 16, 2021
@ghost
Copy link

ghost commented Aug 16, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Not sure it fixes #57470 but it looks like a potential issue.

cc @dotnet/jit-contrib

Author: EgorBo
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@adamsitnik adamsitnik mentioned this pull request Aug 16, 2021
Merged
@EgorBo EgorBo mentioned this pull request Aug 16, 2021
Closed
@EgorBo
Copy link
Member Author

EgorBo commented Aug 16, 2021

NOTE: missing "Is CSE candidate" is a quite popular issue in morph 😞

I think we can write a stress-test where we set "IsCseCandidate" bit early in global morph and detect all transformations which ignore it and still modify trees, something like that.

kunalspathak
kunalspathak approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@kunalspathak
Copy link
Member

@EgorBo - did you get chance to check CI failures? If they are existing, we can go ahead and merge this PR.

@EgorBo
Copy link
Member Author

EgorBo commented Aug 17, 2021

@EgorBo - did you get chance to check CI failures? If they are existing, we can go ahead and merge this PR.

Yeah, all of them are unrelated and fail on other PRs too (just checked all of them on runfo)

@EgorBo EgorBo merged commit 492a520 into dotnet:main Aug 17, 2021
@runfoapp runfoapp bot mentioned this pull request Aug 17, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kunalspathak kunalspathak kunalspathak approved these changes

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to find expression in a statement during CSE
3 participants
@EgorBo @kunalspathak @jakobbotsch