Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Enable tests blocked by IL2105 #57457

Merged
merged 7 commits into from
Aug 17, 2021
Merged

[wasm] Enable tests blocked by IL2105 #57457

merged 7 commits into from
Aug 17, 2021

Conversation

lewing
Copy link
Member

@lewing lewing commented Aug 16, 2021 •
edited
Loading

No description provided.

@ghost
Copy link

ghost commented Aug 16, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

…rimming

Author: lewing
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

@lewing lewing changed the title Disable ReflectionCachesUpdateHandler_CachesCleared with aggressive t… [wasm] Disable ReflectionCachesUpdateHandler_CachesCleared with aggressive t… Aug 16, 2021
@lewing lewing added the arch-wasm WebAssembly architecture label Aug 16, 2021
@ghost
Copy link

ghost commented Aug 16, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

…rimming

Author: lewing
Assignees: -
Labels:

arch-wasm, area-Infrastructure-libraries
Milestone: -

@lewing lewing changed the title [wasm] Disable ReflectionCachesUpdateHandler_CachesCleared with aggressive t… [wasm] Enable tests blocked by IL2105 Aug 16, 2021
@lewing lewing requested a review from radical August 16, 2021 01:10
@lewing
Copy link
Member Author

lewing commented Aug 16, 2021

resolves #51602

@lewing lewing requested a review from akoeplinger August 16, 2021 01:24
@lewing
Copy link
Member Author

lewing commented Aug 16, 2021

I skipped the suppression so there might be some errors still.

@lewing lewing added the trimming-for-aot `EnableAggressiveTrimming=true` used for running tests with AOT label Aug 16, 2021
@lewing
Copy link
Member Author

lewing commented Aug 16, 2021 •
edited
Loading

a stack of https://github.com/dotnet/core-eng/issues/13691 here :(

https://dev.azure.com/dnceng/public/_build/results?buildId=1295107&view=logs&j=eb51b6b1-acd4-5d0e-ec03-d6dd16ab13c9&t=01d65644-2e0a-5b21-5167-e35202b4b294&l=512

https://dev.azure.com/dnceng/public/_build/results?buildId=1295107&view=logs&j=79ebbb2e-07f2-5457-c5e5-132dd7ee4ba8&t=19d75d51-494c-5498-c708-7a0aae08aa93&l=136

https://dev.azure.com/dnceng/public/_build/results?buildId=1295107&view=logs&j=81a0f8c2-d4db-561f-9b8e-3f045280d7fe&t=2a104984-c43b-5b93-1361-6bd8a1e96b04&l=113

@lewing
Copy link
Member Author

lewing commented Aug 16, 2021 •
edited
Loading 

@azure-pipelinesazure-pipelines
/ runtime (Libraries Build windows allConfigurations x64 Debug)
.dotnet\sdk\6.0.100-rc.1.21411.28\NuGet.RestoreEx.targets#L19
.dotnet\sdk\6.0.100-rc.1.21411.28\NuGet.RestoreEx.targets(19,5): error : (NETCORE_ENGINEERING_TELEMETRY=Restore) Failed to retrieve information about 'NETStandard.Library.Ref' from remote source 'https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/c9f8ac11-6bd8-4926-8306-f075241547f7/nuget/v3/flat2/netstandard.library.ref/index.json'.
   at NuGet.Protocol.HttpFileSystemBasedFindPackageByIdResource.FindPackagesByIdAsync(String id, SourceCacheContext cacheContext, ILogger logger, CancellationToken cancellationToken)
   at NuGet.Protocol.HttpFileSystemBasedFindPackageByIdResource.EnsurePackagesAsync(String id, SourceCacheContext cacheContext, ILogger logger, CancellationToken cancellationToken)
   at NuGet.Protocol.HttpFileSystemBasedFindPackageByIdResource.DoesPackageExistAsync(String id, NuGetVersion version, SourceCacheContext cacheContext, ILogger logger, CancellationToken cancellationToken)
   at NuGet.Commands.SourceRepositoryDependencyProvider.FindLibraryCoreAsync(LibraryRange libraryRange, SourceCacheContext cacheContext, ILogger logger, CancellationToken cancellationToken)
   at NuGet.Commands.SourceRepositoryDependencyProvider.<>c__DisplayClass19_0.<<FindLibraryAsync>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at NuGet.Commands.SourceRepositoryDependencyProvider.FindLibraryAsync(LibraryRange libraryRange, NuGetFramework targetFramework, SourceCacheContext cacheContext, ILogger logger, CancellationToken cancellationToken)
   at NuGet.DependencyResolver.ResolverUtility.<>c__DisplayClass9_1.<<FindLibraryFromSourcesAsync>b__0>d.MoveNext()

is one I haven't seen before

https://dev.azure.com/dnceng/public/_build/results?buildId=1295110&view=logs&j=f9ca8601-c4c2-5da2-61cf-0da7d83d7557&t=b13641db-40b3-5434-6257-21682c42fb2a&l=46

@lewing
Copy link
Member Author

lewing commented Aug 16, 2021

cc @danmoseley

stephentoub
stephentoub reviewed Aug 16, 2021
View reviewed changes
eng/testing/tests.mobile.targets Outdated
@@ -14,7 +14,7 @@
<!-- Suppress linker warnings as these are tests -->
<SuppressTrimAnalysisWarnings>true</SuppressTrimAnalysisWarnings>
<!-- Can be removed when SDK update picks up https://github.com/dotnet/sdk/pull/18655. -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was merged two weeks ago. Is the comment still accurate?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the current plan is to continue to suppress warnings on this leg. I removed the comment.

@lewing
Copy link
Member Author

lewing commented Aug 17, 2021

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jaredpar jaredpar mentioned this pull request Aug 17, 2021
Closed
@runfoapp runfoapp bot mentioned this pull request Aug 17, 2021
Closed
@lewing
Copy link
Member Author

lewing commented Aug 17, 2021

this only turns on new tests for the browser lanes and they are green.

@lewing lewing merged commit 82f7144 into dotnet:main Aug 17, 2021
@lewing lewing deleted the wasm-enable-more-tests branch August 17, 2021 21:28
@karelz karelz mentioned this pull request Aug 19, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub left review comments

@akoeplinger akoeplinger akoeplinger approved these changes

@radical radical Awaiting requested review from radical

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Infrastructure-libraries trimming-for-aot `EnableAggressiveTrimming=true` used for running tests with AOT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lewing @akoeplinger @stephentoub